Skip to content

convert circleci workflows to github actions for android build and test - #43644

Closed
robandpdx wants to merge 5 commits into
react:mainfrom
robandpdx-org:convert-circleci-to-gha-android-only
Closed

convert circleci workflows to github actions for android build and test#43644
robandpdx wants to merge 5 commits into
react:mainfrom
robandpdx-org:convert-circleci-to-gha-android-only

Conversation

@robandpdx

@robandpdxrobandpdx commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

Summary:

This pull request converts the CircleCI workflows to GitHub actions workflows. This change only inlcudes the android build and test jobs.

Changelog:

Test Plan:

Here is the latest workflow run in my fork.

https://fburl.com/workplace/f6mz6tmw

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2024
@github-actions

github-actionsBot commented Mar 25, 2024•
edited
Loading

Copy link
Copy Markdown
Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against a5d75cc

@facebook-github-botfacebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 25, 2024
@analysis-bot

analysis-bot commented Mar 25, 2024•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a18,446,480-430,798
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a21,819,718-430,479
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: 2205880
Branch: main

@robandpdxrobandpdx mentioned this pull request Mar 26, 2024
Closed
cortinico
cortinico approved these changes Mar 26, 2024
View reviewed changes

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👍 I've left a couple of comments but then we can import this one

Comment thread.github/workflows/test-all.yml
Comment thread.github/workflows/test-all.yml Outdated
Comment thread.github/workflows/test-all.yml Outdated
Comment thread.github/workflows/test-all.yml Outdated
Comment thread.github/workflows/test-all.yml
Comment thread.github/workflows/test-all.yml Outdated
Comment thread.github/workflows/test-all.yml
@robandpdx

robandpdx commented Mar 26, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@cortinicoHere is the latest workflow run in my fork with the latest changes.

@facebook-github-bot

facebook-github-bot commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cortinico
cortinico reviewed Mar 28, 2024
View reviewed changes
Comment thread.github/workflows/test-all.yml
- name: Cache android build artifacts
uses: actions/cache@v4.0.0
with:
key: android-build-cache-${{ github.run_number}}

@cortinicocortinicoMar 28, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we specify also a restore key here?

@robandpdxrobandpdxMar 29, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you need a different restore key, it is not needed.

Comment thread.github/workflows/test-all.yml

echo ${{ steps.hermes-version.outputs.version }}
build_andriod:
runs-on: ubuntu-latest

@cortinicocortinicoMar 28, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: ubuntu-latest
runs-on: 8-core-ubuntu

Can we make this and other compilation heavy jobs on 8-core-ubuntu? This should be similar to the same machine we had on CircleCI

@robandpdxrobandpdxMar 29, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could, however these larger runners would need to be configured in your org with the label 8-core-ubuntu in order to run. There are no runners with this label available by default.

cortinico
cortinico reviewed Apr 2, 2024
View reviewed changes
Comment thread.github/workflows/test-all.yml Outdated
Comment thread.github/workflows/test-all.yml Outdated
@facebook-github-bot

facebook-github-bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Apr 2, 2024
@facebook-github-bot

facebook-github-bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in 036ffbc.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robandpdx@analysis-bot@facebook-github-bot@cortinico