Uh oh!
There was an error while loading. Please reload this page.
[CLI] Remove dependency on Ruby - #440
Conversation
vjeux
commented
Mar 29, 2015
Sweet! init.sh should be outside of the cli folder. Since the cli is global, it's super hard to update. What it does is just forward all the commands to react-native which can be updated easily. |
7fb25db to
1a2357bCompareJoeStanton
commented
Mar 29, 2015
Ah that makes sense, global packages are annoying to update. Moved it back out. |
vjeux
commented
Mar 29, 2015
Looks good, i'll test it and merge it later today or tomorrow, thanks! |
There was a problem hiding this comment.
This file no longer has to be invoked via shell. Since it's all JS, you can just require and run it from cli.js
frantic
commented
Mar 30, 2015
Awesome job @JoeStanton! I have a few suggestions - see inline comments |
There was a problem hiding this comment.
Not 100% on this, but from when I started this over the weekend as well, I think that ruby’s __FILE__ returns just the filename (init.sh), while node’s __filename includes the full path resolution (/Users/user/path/to/react-native/init.sh).
nicklockwood
commented
May 5, 2015
@frantic what happened to this? Can we resurrect it? |
JoeStanton
commented
May 5, 2015
Hey! My fault - Life got in the way for a few weeks. I can finish this up in the next couple of days if there's still the appetite for it? |
nicklockwood
commented
May 5, 2015
@JoeStanton yes please! |
This will remove the dependency on Ruby.
2f43e1d to
71abc5fCompareb15f5ed to
526890dCompare8571ce3 to
52e7b80CompareJoeStanton
commented
May 14, 2015
Hey Guys - Finally had a little bit of time, can you take a look at this? AFAIK I can't put Secondly, the |
vjeux
commented
May 14, 2015
@JoeStanton you can't put it in react-native-cli, but you CAN put it in local-cli (that's the right place where to put it) |
JoeStanton
commented
May 14, 2015
Excellent - fixed that up. |
vjeux
commented
May 14, 2015
Thanks, a few minor details and we're good to go :) |
vjeux
commented
May 14, 2015
Oh you are right, nevermind me |
Resolves#275, #293. Discussed in #405.
Rewritten the init script in Node to remove the dependency on Ruby. I've also moved it into the
react-native-clidirectory as I thought it was cleaner.