Uh oh!
There was an error while loading. Please reload this page.
[iOS][Local] Fix breaking changes in 0.74-rc.8 - #44025
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
cipolleschiforce-pushed
the
cipolleschi/fix-brreaking-change
branch
from
April 10, 2024 16:38
7b47ef5 to
eb7c552Comparecipolleschi
marked this pull request as ready for review
April 10, 2024 16:38
analysis-bot
commented
Apr 10, 2024
Base commit: 3f2b1d7 |
ContributorAuthor
the failing gh action is okay. It is pulling hermes from main, but, of course, it can't work when the target branch is a stable one, which expect hermes from the stable version. |
cortinico
commented
Jun 10, 2024
Contributor
Closing as no longer necessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With #43757, we pushed some breaking changes in RC.8
This change makes those changes not breaking.
Note (for framework developers): if you keep the old version of the APIs - which are now marked as deprecated - some feature (for example DeepLinking) won't be working, because they rely on the new parameters that needs to be passed to RCTHost.
Changelog:
[iOS][Fixed] - Make the changes from #43757 not breaking
Test Plan:
Tested locally