Uh oh!
There was an error while loading. Please reload this page.
Fix getDevSupportManager() in ReactDelegate - #44344
Closed
arushikesarwani94 wants to merge 1 commit into
Closed
Conversation
Summary: In react#43520, this was moved to supply with the relevant DevSupportManager, however this check for `useDeveloperSupport` is already part of https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L263https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.java#L68-L70 Having this check here was causing early exit for Bridge RELEASE mode instead of returning the ReleaseDevSupportManager. Changelog: [ANDROID][FIXED] - Fixed `getDevSupportManager()` in ReactDelegate Reviewed By: javache Differential Revision: D56739764
arushikesarwani94force-pushed
the
export-D56739764
branch
from
April 30, 2024 20:10
c942d71 to
4d2bd8cCompareanalysis-bot
commented
Apr 30, 2024
Base commit: c96c893 |
javache
commented
Jun 27, 2024
Contributor
Closed internally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In #43520, this was moved to supply with the relevant DevSupportManager, however this check for
useDeveloperSupportis already part of https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L263https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.java#L68-L70
Having this check here was causing early exit for Bridge RELEASE mode instead of returning the ReleaseDevSupportManager.
Changelog:
[ANDROID][FIXED] - Fixed
getDevSupportManager()in ReactDelegateReviewed By: javache
Differential Revision: D56739764