Avoid setting a lineHeight lower of the fontSize lineHeight with Text and TextInput

[fabOnReact]

Summary:

Avoids setting a lineHeight lower of the fontSize lineHeight with Text and TextInput.
The check was previously introduced on the Paper Renderer with PR #37465.

fixesExpensify/App#14445fixes#29507
related #38359 and Expensify/react-native-live-markdown#350

Changelog:

[IOS] [FIXED] - Avoid setting a lineHeight lower of the fontSize lineHeight with Text and TextInput

Test Plan:

CLICK TO OPEN SOURCE CODE

/** * Copyright (c) Meta Platforms, Inc. and affiliates. * * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * * @format * @flow */importtype{RNTesterModuleInfo}from'./types/RNTesterTypes';import*asReactfrom'react';import{StyleSheet,Text,TextInput,View}from'react-native';// RNTester App currently uses in memory storage for storing navigation stateconstRNTesterApp=({
testList,}: {testList?: {components?: Array<RNTesterModuleInfo>,apis?: Array<RNTesterModuleInfo>,},}): React.Node=>{return(<Viewstyle={styles.container}><Text>This is some Text</Text><Textstyle={styles.text}><Text>jjjj</Text>{'\n'}<Text>💀</Text></Text><Text>This is some TextInput</Text><TextInputmultilinestyle={styles.input}/></View>);};exportdefaultRNTesterApp;conststyles=StyleSheet.create({container: {marginTop: 250,},text: {lineHeight: 14,borderWidth: 1,},input: {lineHeight: 14,borderWidth: 1,},});

Before	After

Expensify

Before	After

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	19,542,749	-4
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,912,802	-15
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 93c079b
Branch: main

[fabOnReact]

RN-Tester - lineHeight examples

There is a difference in the RNTester test results.

• I believe this PR introduces the correct behavior
• The changes were previously merged and approved with PR #37465
• PR 37465 was reverted for the slight difference in the text baseline, but no issues were reported with the changes in the lineHeight of the text/textinput.

Before	After

Before	After

[facebook-github-bot]

@sammy-SC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[react-native-bot]

This PR was closed because it has been stalled for 7 days with no activity.