Uh oh!
There was an error while loading. Please reload this page.
RNGP - Autolinking. Add support for linking projects. - #44799
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Jun 5, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58190363 |
facebook-github-bot
commented
Jun 5, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58190363 |
facebook-github-bot
commented
Jun 5, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58190363 |
Base commit: f57d624 |
facebook-github-bot
commented
Jun 6, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58190363 |
facebook-github-bot
commented
Jun 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58190363 |
facebook-github-bot
commented
Jun 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58190363 |
facebook-github-bot
commented
Jun 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58190363 |
facebook-github-bot
commented
Jun 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58190363 |
Summary: Pull Request resolved: react#44799 This is the final part of core autolinking: 1. I split RNGP into an `app-plugin` and a `settings-plugin`. This was necessary as the Gradle modules need to be loaded inside the settings.gradle.kts. 2. I've introduced a Settings Plugin to take care of either invoking the `config` command from CLI or receiving a file in input. 3. I've removed the former `RunAutolinkingConfigTask` as now the command is invoked inside the settings plugin 4. I've added hashing computed based on the lockfiles so we won't be re-executing teh `config` command if the lockfiles are not changed. 5. I've updated RN-Tester to use the core autolinking rather than manual linking for the 2 libraries it's using. Changelog:linking [Internal] [Changed] - RNGP - Autolinking. Add support for linking projects Reviewed By: blakef Differential Revision: D58190363
facebook-github-bot
commented
Jun 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58190363 |
2 tasks
facebook-github-bot
commented
Jun 7, 2024
Contributor
This pull request has been merged in cf914e4. |
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: react#44799 This is the final part of core autolinking: 1. I split RNGP into an `app-plugin` and a `settings-plugin`. This was necessary as the Gradle modules need to be loaded inside the settings.gradle.kts. 2. I've introduced a Settings Plugin to take care of either invoking the `config` command from CLI or receiving a file in input. 3. I've removed the former `RunAutolinkingConfigTask` as now the command is invoked inside the settings plugin 4. I've added hashing computed based on the lockfiles so we won't be re-executing teh `config` command if the lockfiles are not changed. 5. I've updated RN-Tester to use the core autolinking rather than manual linking for the 2 libraries it's using. Changelog:linking [Internal] [Changed] - RNGP - Autolinking. Add support for linking projects Reviewed By: blakef Differential Revision: D58190363 fbshipit-source-id: 6ab8b36729e77ca715f50a4a00aa0ca4eb5b63b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is the final part of core autolinking:
app-pluginand asettings-plugin. This was necessary as the Gradle modules need to be loaded inside the settings.gradle.kts.configcommand from CLI or receiving a file in input.RunAutolinkingConfigTaskas now the command is invoked inside the settings pluginconfigcommand if the lockfiles are not changed.Changelog:linking
[Internal] [Changed] - RNGP - Autolinking. Add support for linking projects
Differential Revision: D58190363