Uh oh!
There was an error while loading. Please reload this page.
Make getContentOriginOffset to know info about if call-site want transform or not - #44822
Closed
realsoelynn wants to merge 1 commit into
Closed
Make getContentOriginOffset to know info about if call-site want transform or not#44822realsoelynn wants to merge 1 commit into
realsoelynn wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Jun 6, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
Base commit: c9d7774 |
facebook-github-bot
commented
Jun 6, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynnforce-pushed
the
export-D58223380
branch
from
June 6, 2024 23:42
6d61761 to
bb1f50fComparerealsoelynn
commented
Jun 6, 2024
MemberAuthor
This is a pre-req for this bugfix #44168 |
facebook-github-bot
commented
Jun 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynnforce-pushed
the
export-D58223380
branch
from
June 7, 2024 00:01
bb1f50f to
cd5dea1Comparefacebook-github-bot
commented
Jun 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynnforce-pushed
the
export-D58223380
branch
from
June 7, 2024 17:55
cd5dea1 to
87fc8d4Comparerealsoelynn added a commit
to realsoelynn/react-native
that referenced
this pull request
Jun 7, 2024
…sform or not (react#44822) Summary: Pull Request resolved: react#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (react#44822) Summary: Pull Request resolved: react#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (react#44822) Summary: Pull Request resolved: react#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
facebook-github-bot
commented
Jun 11, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynnforce-pushed
the
export-D58223380
branch
from
June 11, 2024 17:46
87fc8d4 to
0bbf3dcComparefacebook-github-bot
commented
Jun 11, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynnforce-pushed
the
export-D58223380
branch
from
June 11, 2024 17:53
0bbf3dc to
7dc9c9cComparefacebook-github-bot
commented
Jun 11, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynnforce-pushed
the
export-D58223380
branch
from
June 11, 2024 18:00
7dc9c9c to
2f4221aComparekosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (react#44822) Summary: Pull Request resolved: react#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
facebook-github-bot
commented
Jun 11, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynnforce-pushed
the
export-D58223380
branch
from
June 11, 2024 18:32
2f4221a to
549a3f3Comparefacebook-github-bot
commented
Jun 11, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynnforce-pushed
the
export-D58223380
branch
from
June 11, 2024 18:39
549a3f3 to
291b0c9Compare…sform or not (react#44822) Summary: Pull Request resolved: react#44822 Changelog: [Breaking] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Reviewed By: NickGerleman Differential Revision: D58223380
facebook-github-bot
commented
Jun 12, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynnforce-pushed
the
export-D58223380
branch
from
June 12, 2024 00:09
291b0c9 to
f8bf87fComparefacebook-github-bot
commented
Jun 12, 2024
Contributor
This pull request has been merged in ce588db. |
This pull request was successfully merged by @realsoelynn in ce588db. When will my fix make it into a release? | How to file a pick request? |
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 12, 2024
…sform or not (react#44822) Summary: Pull Request resolved: react#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This is to make
getContentOriginOffsetto haveincludeTransforminformation passed during Layout computation.Differential Revision: D58223380