New implementation of PerformanceObserver and related APIs (fixes #45122) - #45206

Closed

robik wants to merge 60 commits into

robik:robik/improve-performance-observer

Commits on Sep 20, 2024

refactor: extract performance observers to native layer and push entries to each observer
robik
committed
5129b07
update JS code to reflect native changes
robik
committed
df5cade
chore: undo CMakeLists change
robik
committed
2a47fdc
fix: wrap Plugins.h include into ifdef
robik
committed
cecdd2f
chore: add comment on PerformanceObserver TurboModule inclusion
robik
committed
b4c02b3
fix: use type from timing/Primitives
robik
committed
cc46c94
fix reporting logic for entries of event type
robik
committed
ae9c73b
fix: handle LongTask in getBuffer() switch
robik
committed
b8705e4
fix: use DOMHighResTimestamp
robik
committed
7819498
fix: remove checking for duration threshold in observer and move filtering of observer event types to observer registry
robik
committed
a4e404d
fix: remove const ref getEventFilter and add [[nodiscard]] attributes
robik
committed
2b0f107
feat: add [[nodiscard]] attributes
robik
committed
284971e
feat: add [[nodiscard]] attributes; clean up data flow to make it simpler
robik
committed
751aba1
reorganize files; clean up logic; split PerformanceEntry buffers
robik
committed
30642ec
improve `PerformanceObserver` options bridging
robik
committed
6862527
chore: prettify Performance Observer public API
robik
committed
863d50e
chore: moved PushStatus back to `BoundedConsumableBuffer`
robik
committed
dbf0775
chore: add more comments about testing only code
robik
committed
6e0319c
chore: add comment about divergence vs the spec
robik
committed
f3450b6
fix: narrow down the public API and move the responsibility of filtering to PerformanceObserver from PerformanceObserverRegistry
robik
committed
13f1200
chore: remove unnecessary [[nodiscard]] attirubtes
robik
committed
573b329
chore: rename `PerformanceObserverRegistry::emit` to `queuePerformanceEntry`
robik
committed
b2f039a
chore: add `OpaqueNativeObserverHandle` type
robik
committed
f613d44
chore: remove generic `pushEntry` from PerformanceEntryReporter
robik
committed
8e1217d
chore: bring back public `getBuffer`
robik
committed
254613f
fix: multiple types buffering is not allowed
robik
committed
b7a1732
fix: update JS layer; make observer buffer a vector; support `durationThreshold`
robik
committed
574fa98
fix: update native and JS layer
robik
committed
6dc3b4a
fix: make performance observer inherit from NativeState
robik
committed
6a12b19
fix: tests
robik
committed
6056aa7
chore: cleanup PerformanceObserver and PerformanceObserverRegistry dependency
robik
committed
e0aa0a2
chore: cleanup PerformanceObserver and PerformanceObserverRegistry dependency
robik
committed
a2f54b1
chore: style fixes
robik
committed
1452d44
chore: narrow down CircularBuffer API
robik
committed
11ebbef
chore: remove LinearBuffer and `pendingMessagesCount`
robik
committed
9a59aec
chore: fix getEventCounts position
robik
committed
a1f7bb6
chore: fix lock_guard initialization style
robik
committed
187be80
style: rename `entriesMutex_` to `buffersMutex_`
robik
committed
a2bf9cf
fix: remove concept of consuming, renamed `BoundedConsumableBuffer` to `CircularBuffer`, cleaned up buffer API
robik
committed
1cc3928
chore: remove allEntries cache from keyed buffer
robik
committed
771537e
fix: refactor EntryReporter public API
robik
committed
88cc8ad
style: format code
robik
committed
a8cbb48
chore: make add/removeObserver part of registry public API
robik
committed
40b6200
chore: remove getNextOverwriteCandidate
robik
committed
055ae21
fix: schedule buffer flush only when its not empty
robik
committed
4a9372c
chore: cleanup optionals as arguments
robik
committed
8c987ab
chore: remove vector after clearing elements by name
robik
committed
d22f590
chore: remove pointer aliases, make PerformanceObserver shared instead of owned
robik
committed
dfd9413
style: fix
robik
committed
8d78ccd
style: update comment
robik
committed
56d04ab
chore: remove default max size from circular buffer
robik
committed
fb3197c
fix: optimize JS native call
robik
committed
23802a4
fix: tests
robik
committed
8fe46c2
fix: tests
robik
committed
4f4f6b3
undo testing stuff
robik
committed
8f717c0
fix if condition
robik
committed
ecf035a
remove weak ptrs from registry;
robik
committed
3b20278
remove clearing the observer in native module
robik
committed
aeba178

Commits on Sep 23, 2024

rename `logEvent` to `testOnly_logEvent` in NativePerformanceObserver
robik
committed
8cfb905
style: fix
robik
committed
f136f65