Uh oh!
There was an error while loading. Please reload this page.
[Hermes] Bump Hermes - #45220
Merged
Merged
Conversation
cipolleschiforce-pushed
the
cipolleschi/bump-hermes
branch
from
June 28, 2024 14:10
b2e22b4 to
d818083Comparecipolleschi
commented
Jun 28, 2024
Comment on lines
+129
to
+131
| void queueMicrotask(const jsi::Function& callback) override { | ||
| return plain().queueMicrotask(callback); | ||
| } |
ContributorAuthor
There was a problem hiding this comment.
facebook/hermes@0a632b7 adds this change in JSI. We need it in React Native as well
cipolleschi
commented
Jun 28, 2024
| Around around{with_}; | ||
| return RD::evaluatePreparedJavaScript(js); | ||
| } | ||
| void queueMicrotask(const Function& callback) override { |
ContributorAuthor
There was a problem hiding this comment.
facebook/hermes@0a632b7 adds this change in JSI. We need it in React Native as well
cipolleschi
commented
Jun 28, 2024
| /// its event loop implementation. | ||
| /// | ||
| /// \param callback a function to be executed as a microtask. | ||
| virtual void queueMicrotask(const jsi::Function& callback) = 0; |
ContributorAuthor
There was a problem hiding this comment.
facebook/hermes@7bda0c2 adds this change in JSI. We need it in React Native as well
cipolleschi
marked this pull request as ready for review
June 28, 2024 14:12
Summary: Changelog: [internal] ## Context We want to enable the new React Native event loop by default for all users on the new RN architecture (on the bridgeless initialization path more concretely), which requires support for microtasks in all the JS engines that the support (Hermes already has it, JSC doesn't). ## Changes This adds initial support for microtasks in JSC, so we can schedule and execute microtasks in this runtime. One limitation about this approach is that, AFAIK, the public API for JSC doesn't allow us to customize its internal microtask queue or specify the method to be used by its built-in `Promise` or native `async function`, so we're forced to continue using a polyfill in that case (which uses `setImmediate` that will be mapped to `queueMicrotask`). Reviewed By: NickGerleman Differential Revision: D54302534 fbshipit-source-id: 47f71620344a81bc6624917f77452106ffbf55a3
analysis-bot
commented
Jun 28, 2024
Base commit: 9833338 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR bumps hermes in 0.74. This is needed because we need the microTask queue that has been shipped in Hermes
Changelog:
[Internal] - Bump Hermes
Test Plan:
CCI is green again for
build_android