Uh oh!
There was an error while loading. Please reload this page.
Introduce getDiffProps for <View> - #45552
Closed
mdvacca wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Jul 20, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
facebook-github-bot
commented
Sep 18, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
mdvaccaforce-pushed
the
export-D59969328
branch
from
September 18, 2024 03:31
b144389 to
b2671bdComparefacebook-github-bot
commented
Sep 18, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
facebook-github-bot
commented
Jan 7, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
facebook-github-bot
commented
Jan 7, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
mdvaccaforce-pushed
the
export-D59969328
branch
from
January 21, 2025 22:52
c29eb87 to
e8925daComparefacebook-github-bot
commented
Jan 21, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
mdvaccaforce-pushed
the
export-D59969328
branch
from
January 21, 2025 22:55
e8925da to
a16398bComparefacebook-github-bot
commented
Jan 21, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
mdvaccaforce-pushed
the
export-D59969328
branch
from
January 21, 2025 22:57
a16398b to
3b8aa81Comparefacebook-github-bot
commented
Jan 21, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
mdvaccaforce-pushed
the
export-D59969328
branch
from
January 22, 2025 04:21
3b8aa81 to
f4ec19aComparefacebook-github-bot
commented
Jan 22, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
Summary: In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328
mdvacca added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
Summary: In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328
mdvacca added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
Summary: In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328
mdvaccaforce-pushed
the
export-D59969328
branch
from
January 22, 2025 17:34
f4ec19a to
c2c8800Comparemdvacca added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
Summary: In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328
mdvacca added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
Summary: In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328
facebook-github-bot
commented
Jan 22, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D59969328 |
mdvacca added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
Summary: In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328
mdvacca added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
Summary: In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328
facebook-github-bot
commented
Jan 22, 2025
Contributor
This pull request has been merged in 5ee2289. |
react-native-bot
commented
Jan 22, 2025
Collaborator
This pull request was successfully merged by @mdvacca in 5ee2289 When will my fix make it into a release? | How to file a pick request? |
ghost
pushed a commit
to discord/react-native-archived
that referenced
this pull request
May 14, 2025
Summary: Pull Request resolved: react#45552 In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328 fbshipit-source-id: ce141528581e46e9ced4175dca040ddf8bed5ddb
ghost
pushed a commit
to discord/react-native-archived
that referenced
this pull request
May 14, 2025
Summary: Pull Request resolved: react#45552 In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328 fbshipit-source-id: ce141528581e46e9ced4175dca040ddf8bed5ddb Co-authored-by: David Vacca <dvacca@meta.com>
bdbaraban pushed a commit
to discord/react-native-archived
that referenced
this pull request
May 22, 2025
Summary: Pull Request resolved: react#45552 In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328 fbshipit-source-id: ce141528581e46e9ced4175dca040ddf8bed5ddb Co-authored-by: David Vacca <dvacca@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff I'm overriding the getDiffProps for ViewProps.
The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps.
Once we verify what are the implication we will automatic implement this diffing.
The full implementation of this method will be implemented in the following diffs
changelog: [internal] internal
Reviewed By: NickGerleman
Differential Revision: D59969328