Uh oh!
There was an error while loading. Please reload this page.
fix: minor fixes for hermes scripts - #45841
Conversation
5d75cef to
37a3a69Compare37a3a69 to
bb7670bCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bb7670b to
7384cd7Compareefstathiosntonas
commented
Jul 31, 2024
@okwasniewski this targets this, correct? (just trying to link them in gh) |
okwasniewski
commented
Jul 31, 2024
Not really, this is a PR with additional fixes that will prevent this happening in the future, we are working together with @cipolleschi here: #45840 |
okwasniewski
commented
Aug 5, 2024
Hey @cipolleschi is this one good to merge or should I do some additional changes? |
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for working on this!
facebook-github-bot
commented
Aug 7, 2024
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Aug 7, 2024
@cipolleschi merged this pull request in c17da4e. |
react-native-bot
commented
Aug 7, 2024
This pull request was successfully merged by @okwasniewski in c17da4e When will my fix make it into a release? | How to file a pick request? |
Summary:
This PR fixes few issues with Hermes scripts:
Changelog:
[INTERNAL] [FIXED] - Hermes script should fail when no deployment target is set
Test Plan:
Try to build Hermes