Skip to content

Fixes LayoutAnimations strict weak ordering sorted check failed - #46614

Closed
realsoelynn wants to merge 1 commit into
react:mainfrom
realsoelynn:export-D63302091
Closed

Fixes LayoutAnimations strict weak ordering sorted check failed#46614
realsoelynn wants to merge 1 commit into
react:mainfrom
realsoelynn:export-D63302091

Conversation

@realsoelynn

@realsoelynnrealsoelynn commented Sep 24, 2024

Copy link
Copy Markdown
Member

Summary:
Changelog [Internal]:
Update to make sure Mutation sorting compare function follow strict weak ordering.

Differential Revision: D63302091

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 24, 2024
@facebook-github-bot

facebook-github-bot commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D63302091

@facebook-github-bot

facebook-github-bot commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D63302091

@facebook-github-bot

facebook-github-bot commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D63302091

@realsoelynn@facebook-github-bot
Fixes LayoutAnimations strict weak ordering sorted check failed (reac…
08ab073
…t#46614)
Summary:
Pull Request resolved: react#46614
Changelog [Internal]:
Update to make sure Mutation sorting compare function follow strict weak ordering.
Differential Revision: D63302091
@facebook-github-bot

facebook-github-bot commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D63302091

@zhongwuzw

zhongwuzw commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

@realsoelynn Hi.
I also made a PR #46582. My thoughts is to change shouldFirstComeBeforeSecondRemovesOnly to only sort removed layout mutations. I don't know which one is better, just FYI 🙂 What do you think? 😅

@realsoelynn

realsoelynn commented Sep 25, 2024

Copy link
Copy Markdown
MemberAuthor

@realsoelynn Hi. I also made a PR #46582. My thoughts is to change shouldFirstComeBeforeSecondRemovesOnly to only sort removed layout mutations. I don't know which one is better, just FYI 🙂 What do you think? 😅

Hey hey, we will go with your PR. i will be closing this.

We will continue the conversation on your PR.

@realsoelynn
realsoelynn deleted the export-D63302091 branch September 25, 2024 16:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedp: FacebookPartner: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@realsoelynn@facebook-github-bot@zhongwuzw