Extend earlyjs c++ pipeline for soft errors by RSNara · Pull Request #46893 · react/react-native

RSNara · 2024-10-08T17:32:17Z

Summary:
Before, the c++ pipeline only supported fatal errors.

Now, it supports soft errors!

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D63927090

facebook-github-bot · 2024-10-08T17:32:26Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-08T17:53:55Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-08T18:05:34Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-08T18:06:00Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-08T21:14:20Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T13:54:29Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T15:37:42Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T20:05:59Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T20:08:28Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T20:24:44Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T21:11:57Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T21:47:25Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T21:47:55Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T21:49:08Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T21:50:12Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T22:38:42Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T23:17:11Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-09T23:27:32Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-10T00:14:33Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-10T18:35:47Z

This pull request was exported from Phabricator. Differential Revision: D63927090

Summary: For the js error handling pipeline, the javascript data structure looks like [this](https://www.internalfb.com/code/fbsource/[6181b57f4ba3619f58056bcec65382650d6ff59a]/xplat/js/react-native-github/packages/react-native/src/private/specs/modules/NativeExceptionsManager.js?lines=17-35): ``` export type StackFrame = {| column: ?number, file: ?string, lineNumber: ?number, methodName: string, collapse?: boolean, |}; export type ExceptionData = { message: string, originalMessage: ?string, name: ?string, componentStack: ?string, stack: Array<StackFrame>, id: number, isFatal: boolean, // flowlint-next-line unclear-type:off extraData?: Object, ... }; ``` So, I made the c++ data structure look similar ``` struct ParsedError { struct StackFrame { std::optional<std::string> file; std::string methodName; std::optional<int> lineNumber; std::optional<int> column; }; std::string message; std::optional<std::string> originalMessage; std::optional<std::string> name; std::optional<std::string> componentStack; std::vector<StackFrame> stack; int id; bool isFatal; jsi::Object extraData; }; ``` Notes: * [parseErrorStack](https://fburl.com/code/e27q9gkc) doesn't actually generate a collapse property on the error object. So, I omitted it from the c++. * ExceptionsManager [always provides an extraData field](https://fburl.com/code/2bvcsxac). So, I made it required. * In C++, I just stored extraData as a jsi::Object. I wanted the freedom to store arbitrary key/value pairs. But, I also didn't want to use folly::dynamic. Changelog: [Internal] Differential Revision: D63929580

Summary: This diff re-implements [js error stack trace parsing](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseErrorStack.js#L41-L57) in c++. Details: - I migrated [stacktrace-parser](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/src/stack-trace-parser.js#L7) - I migrated [parseHermesStack.js](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseHermesStack.js#L82) I also migrated all their tests to c++: - [stacktrace-parser tests](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/test/stack-trace-parser.spec.js#L5) - [parseHermesStack tests](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/__tests__/parseHermesStack-test.js#L16) Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D63659013

Summary: Before, the c++ pipeline only supported fatal errors. Now, it supports soft errors! Changelog: [Internal] Reviewed By: javache Differential Revision: D63927090

facebook-github-bot · 2024-10-10T18:36:48Z

This pull request was exported from Phabricator. Differential Revision: D63927090

facebook-github-bot · 2024-10-10T23:07:46Z

This pull request has been merged in 509abff.

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024

facebook-github-bot added fb-exported p: Facebook Partner: Facebook Partner labels Oct 8, 2024

RSNara force-pushed the export-D63927090 branch from f89965e to 08cbe04Compare October 8, 2024 17:53

RSNara force-pushed the export-D63927090 branch from 08cbe04 to 1bb96e8Compare October 8, 2024 18:05

RSNara force-pushed the export-D63927090 branch from 1bb96e8 to 82dece9Compare October 8, 2024 18:05

RSNara force-pushed the export-D63927090 branch from 82dece9 to 2c8782aCompare October 8, 2024 21:14

RSNara force-pushed the export-D63927090 branch from 2c8782a to a530e02Compare October 9, 2024 13:54

RSNara force-pushed the export-D63927090 branch from a530e02 to 416211bCompare October 9, 2024 15:37

RSNara force-pushed the export-D63927090 branch from 416211b to de32a02Compare October 9, 2024 20:05

RSNara force-pushed the export-D63927090 branch from de32a02 to 7828fd0Compare October 9, 2024 20:08

RSNara force-pushed the export-D63927090 branch from 7828fd0 to fc1c4ebCompare October 9, 2024 20:24

RSNara force-pushed the export-D63927090 branch 2 times, most recently from bd79484 to 1d9b94eCompare October 9, 2024 21:11

RSNara force-pushed the export-D63927090 branch from 1d9b94e to c53a300Compare October 9, 2024 21:18

RSNara force-pushed the export-D63927090 branch from e37ee5a to 3ec51e2Compare October 9, 2024 21:47

RSNara force-pushed the export-D63927090 branch from 3ec51e2 to fd77fdeCompare October 9, 2024 21:48

RSNara force-pushed the export-D63927090 branch from fd77fde to 03e2acbCompare October 9, 2024 21:49

RSNara force-pushed the export-D63927090 branch from 03e2acb to e800df7Compare October 9, 2024 22:38

RSNara force-pushed the export-D63927090 branch from e800df7 to c143dffCompare October 9, 2024 23:16

RSNara force-pushed the export-D63927090 branch from c143dff to fafb0daCompare October 9, 2024 23:27

RSNara force-pushed the export-D63927090 branch from fafb0da to 3a8af84Compare October 10, 2024 00:14

RSNara force-pushed the export-D63927090 branch from 3a8af84 to 0caf1a7Compare October 10, 2024 18:35

RSNara added 3 commits October 10, 2024 11:35

Extend earlyjs c++ pipeline for soft errors (react#46893)
6c3cadf
Summary: Before, the c++ pipeline only supported fatal errors. Now, it supports soft errors! Changelog: [Internal] Reviewed By: javache Differential Revision: D63927090

RSNara force-pushed the export-D63927090 branch from 0caf1a7 to 6c3cadfCompare October 10, 2024 18:36

facebook-github-bot closed this in 509abffOct 10, 2024

facebook-github-bot added the Merged This PR has been merged. label Oct 10, 2024

This was referenced Nov 7, 2024
Integrate RN Nightly 10/20 microsoft/react-native-windows#14092
Merged
Integrate RN Nightly 10/15 microsoft/react-native-windows#14107
Merged

Uh oh!

Conversation

RSNara commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 10, 2024

Uh oh!

facebook-github-bot commented Oct 10, 2024

Uh oh!

facebook-github-bot commented Oct 10, 2024

Uh oh!

facebook-github-bot commented Oct 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants