Skip to content

Remove default false/null props from Text#46956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
Closed

Remove default false/null props from Text #46956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/react-native/Libraries/Text/Text.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,7 +115,7 @@ const Text: component(

// TODO: Move this processing to the view configuration.
const _selectionColor =
selectionColor == null ? null : processColor(selectionColor);
selectionColor != null ? processColor(selectionColor) : undefined;

let _style = style;
if (__DEV__) {
Expand DownExpand Up@@ -208,8 +208,6 @@ const Text: component(
{...restProps}
accessibilityLabel={_accessibilityLabel}
accessibilityState={_accessibilityState}
isHighlighted={false}
isPressable={false}
nativeID={_nativeID}
numberOfLines={_numberOfLines}
ref={forwardedRef}
Expand DownExpand Up@@ -288,7 +286,6 @@ const Text: component(
allowFontScaling={allowFontScaling !== false}
disabled={_disabled}
ellipsizeMode={ellipsizeMode ?? 'tail'}
isHighlighted={false}
nativeID={_nativeID}
numberOfLines={_numberOfLines}
ref={forwardedRef}
Expand Down
8 changes: 0 additions & 8 deletions packages/react-native/Libraries/Text/__tests__/Text-test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,8 +36,6 @@ describe('Text', () => {
accessible={true}
allowFontScaling={true}
ellipsizeMode="tail"
isHighlighted={false}
selectionColor={null}
/>
`);
});
Expand All@@ -62,9 +60,7 @@ describe('Text compat with web', () => {
accessible={true}
allowFontScaling={true}
ellipsizeMode="tail"
isHighlighted={false}
nativeID="id"
selectionColor={null}
tabIndex={0}
testID="testID"
/>
Expand DownExpand Up@@ -178,9 +174,7 @@ describe('Text compat with web', () => {
aria-valuetext="3"
disabled={true}
ellipsizeMode="tail"
isHighlighted={false}
role="main"
selectionColor={null}
/>
`);
});
Expand All@@ -202,9 +196,7 @@ describe('Text compat with web', () => {
accessible={true}
allowFontScaling={true}
ellipsizeMode="tail"
isHighlighted={false}
selectable={false}
selectionColor={null}
style={
Object {
"backgroundColor": "white",
Expand Down