Skip to content

[LOCAL] fix/0.75 stable windows cmake - #48139

Merged
cipolleschi merged 1 commit into
0.75-stablefrom
fix/0.75-stable-windows-cmake
Dec 6, 2024
Merged

[LOCAL] fix/0.75 stable windows cmake#48139
cipolleschi merged 1 commit into
0.75-stablefrom
fix/0.75-stable-windows-cmake

Conversation

@blakef

@blakefblakef commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Do not install CMake on Windows machine

This replicates a fix in 00d5cae. 0.75 hadn't factored this out into a separate action.

Changelog: [Internal]

This covers all instances:

$ git grep 'choco install --no-progress cmake'| wc -l
0

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
@blakef
blakef changed the base branch from main to 0.75-stableDecember 6, 2024 10:51
@react-native-bot

Copy link
Copy Markdown
Collaborator
Fails
🚫

📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 0b6650479b30145bf7ac4a120d5d15d5960b81f7

@github-actions

github-actionsBot commented Dec 6, 2024

Copy link
Copy Markdown
Warnings
⚠️📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 6e715c0

This replicates a fix in 00d5cae. 0.75 hadn't factored this out into
a separate action.
@blakef
blakefforce-pushed the fix/0.75-stable-windows-cmake branch from 0b66504 to 6e715c0CompareDecember 6, 2024 10:52
@blakefblakef changed the title fix/0.75 stable windows cmake[LOCAL] fix/0.75 stable windows cmakeDec 6, 2024

@cipolleschicipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cipolleschi
cipolleschi merged commit a2d8cbf into 0.75-stableDec 6, 2024
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a20,743,798-611,058
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a23,945,550-604,441
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: fcd526d
Branch: main

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android - aliasing on borderRadius

5 participants

@blakef@react-native-bot@analysis-bot@cipolleschi@facebook-github-bot