[PushNotification] Add soundName config for UILocalNotification

[pecheriere]

Current version wasn't triggering any sound when a local notification was fired. I added the possibility to provide a custom sound and fallback to the default iOS sound if not provided.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @vjeux, @andrewimm and @ericvicenti to be potential reviewers.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

[facebook-github-bot]

@pecheriere updated the pull request.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[skevy]

@facebook-github-bot shipit

[skevy]

Thanks!

[skevy]

@facebook-github-bot shipit

[skevy]

@mkonicek pinging on this one (i know you're flying right now, so no rush).

Interestingly, this one didn't even send back the Facebook import message

[vjeux]

@facebook-github-bot shipit

[satya164]

@facebook-github-bot shipit

[facebook-github-bot]

@pecheriere updated the pull request.

[satya164]

@facebook-github-bot shipit

[vjeux]

@facebook-github-bot shipit

[vjeux]

There's something seriously wrong with the bot :(

[mkonicek]

I'll debug the bot.

[mkonicek]

It's working on other PRs: #5146 Will take a look soon.

[mkonicek]

@facebook-github-bot shipit

[mkonicek]

It fails with:

Patch is malformed: From 99865befd2608a6b8853f5733a27dea45a9cce53 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Etienne=20Cheri=C3=A8re?=
<pecheriere@users.noreply.github.com>
Date: Thu, 17 Dec 2015 10:01:20 +0100
Subject: [PATCH 1/2] Add soundName config for UILocalNotification
...

[mkonicek]

Oh lol, here's the code that throws that :)

list($status, $matches) = Regex::match('/From: (.*) <(.*)>/', $patch);
if (!$status) {
throw new SystemException('Patch is malformed: '.$patch);
}

Changed to Regex::match('/From: (.*)\s+<(.*)>/', $patch)

[mkonicek]

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/963270950405628/int_phab to review.

[mkonicek]

I'm not sure we support non-ASCII user names well though :(

[mkonicek]

OK the merge worked but didn't manage to preserve the author, sorry about that: ac72611

It has to do with the newline in the From field, first time I saw that:

From: =?UTF-8?q?Pierre-Etienne=20Cheri=C3=A8re?=
<pecheriere@users.noreply.github.com>
Date: Thu, 17 Dec 2015 10:01:20 +0100

[npomfret]

I cannot get my custom sound to play in a local notification, it always plays the default sound. Is there a 'trick' to getting this working?