Uh oh!
There was an error while loading. Please reload this page.
Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode - #48585
Closed
christophpurrer wants to merge 1 commit into
Closed
Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode#48585christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Jan 10, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrerforce-pushed
the
export-D68004755
branch
from
January 15, 2025 22:02
7d54a21 to
e0bee1aComparefacebook-github-bot
commented
Jan 15, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrerforce-pushed
the
export-D68004755
branch
from
January 16, 2025 19:47
e0bee1a to
6411ed7Comparefacebook-github-bot
commented
Jan 16, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrerforce-pushed
the
export-D68004755
branch
from
February 15, 2025 03:00
6411ed7 to
818cdc4Comparefacebook-github-bot
commented
Feb 15, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrerforce-pushed
the
export-D68004755
branch
from
February 15, 2025 03:10
818cdc4 to
ba69fadComparefacebook-github-bot
commented
Feb 15, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D68004755 |
…ed with AndroidTextInputShadowNode (react#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for react#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
christophpurrerforce-pushed
the
export-D68004755
branch
from
February 15, 2025 03:11
ba69fad to
4ae8d36Comparefacebook-github-bot
commented
Feb 15, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D68004755 |
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…ed with AndroidTextInputShadowNode (react#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for react#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…ed with AndroidTextInputShadowNode (react#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for react#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
react-native-bot
commented
Feb 15, 2025
Collaborator
This pull request was successfully merged by @christophpurrer in 1498566 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
commented
Feb 15, 2025
Contributor
This pull request has been merged in 1498566. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode
As a preparation for #48165 this aligns the implementation of those 2 methods
Differential Revision: D68004755