Uh oh!
There was an error while loading. Please reload this page.
[Local] Disable useInsertionEffectsForAnimations - #48668
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
useInsertionEffectsForAnimationscipolleschi
marked this pull request as ready for review
January 14, 2025 14:53
Contributor
FYI - The corresponding commit to main has landed as c799aa0 - I'm going to cherry-pick that for consistency, rather than merge this. |
robhogan
commented
Jan 15, 2025
Contributor
Picked as 2013bad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Enabling
useInsertionEffectsForAnimationswas causing a regression where<Pressable>components becomes unresponsive. This happens when the<Pressable>'s position is controlled by a<ScrollView>offset and it is animated withnativeDriver.Changelog:
[General][Changed] - Disable useInsertionEffectsForAnimations
Test Plan:
Tested on RNTester, using the API > Animated > Pressability with Native Driver example