Uh oh!
There was an error while loading. Please reload this page.
[RN][CI][Releases] Remove the v prefix from the version passed by GHA to the script - #50130
Merged
Merged
Conversation
cipolleschi
marked this pull request as ready for review
March 19, 2025 13:31
cortinico
approved these changes
Mar 19, 2025
cipolleschiforce-pushed
the
cipolleschi/fix-release-script
branch
2 times, most recently
from
March 19, 2025 13:55
7bbc9c0 to
34cb912Comparecipolleschiforce-pushed
the
cipolleschi/fix-release-script
branch
from
March 19, 2025 13:58
34cb912 to
19a7445Comparecortinico
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
GHA passes the version to the script using the tag, therefore, the version we receive is something like
v0.X.Y.The script, instead, expect the version to be
0.X.Y, with no leadingv.This change fixes the script removing the
vif present. It also mimic a fix we already have on main.An example of a failing job is here
Changelog:
[Internal] - Fix release script by dropping the passed
v.Test Plan:
Next release.