Uh oh!
There was an error while loading. Please reload this page.
[CI][Windows] Downgrade CMake to 3.31.6 - #50459
Merged
Merged
Conversation
cipolleschiforce-pushed
the
cipolleschi/downgrade-cmake-windows
branch
from
April 3, 2025 06:46
94bb1c8 to
0880282CompareJob Summary for GradleTest All :: build_android
|
cipolleschi
marked this pull request as ready for review
April 3, 2025 06:56
cipolleschiforce-pushed
the
cipolleschi/downgrade-cmake-windows
branch
from
April 3, 2025 07:23
0880282 to
13a0a7cComparecipolleschi
requested review from
cortinico and fabriziocucci
and removed request for
fabriziocucciApril 3, 2025 07:26
fabriziocucci
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Windows executor has been updated by github and they now ship with CMake 4.0. (actions/runner-images#11926)
This is not compatible with building HermesC on windows machines. This change attempts to downgrade cmake to 3.31.6, the same version we used to use before.
Changelog:
[Internal] - downgrage Cmake to 3.31.6
Test Plan:
GHA