Uh oh!
There was an error while loading. Please reload this page.
[UIExplorer] Add defaultSource / loadingIndicatorSource - #5074
Conversation
brentvatne
commented
Jan 1, 2016
- Wanted to test [Image] loadingIndicatorSrc / defaultSource not working as expected #5017 but there was no example in UIExplorer
- Also re-order a bit and limit ImageSizeExample to iOS (was causing UIExplorer to redbox on Android)
- defaultSource and loadingIndicatorSource appear to be broken as reported in [Image] loadingIndicatorSrc / defaultSource not working as expected #5017
- Also re-order a bit and limit ImageSizeExample to iOS
brentvatne
commented
Jan 1, 2016
@facebook-github-bot shipit |
facebook-github-bot
commented
Jan 1, 2016
By analyzing the blame information on this pull request, we identified @amasad, @sahrens and @nicklockwood to be potential reviewers. |
facebook-github-bot
commented
Jan 1, 2016
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1680276885585191/int_phab to review. |
bestander
commented
Jan 6, 2016
@nicklockwood is comandeering the revision manually |
nicklockwood
commented
Jan 6, 2016
@brentvatne it turns out that I'm still considering whether we want to keep |
brentvatne
commented
Jan 6, 2016
Ah great to know, thanks for the follow up @nicklockwood! I created an issue for that at #5158 :) No need to keep this one open. |
Summary: Closes#5074 Reviewed By: svcscm Differential Revision: D2798023 Pulled By: nicklockwood fb-gh-sync-id: d8aa87bf8dcbecf53b341d5914bbe3354cc753aa