Skip to content

[UIExplorer] Add defaultSource / loadingIndicatorSource - #5074

Closed
brentvatne wants to merge 1 commit into
react:masterfrom
expo:uiexplorer-image-example-fixes
Closed

[UIExplorer] Add defaultSource / loadingIndicatorSource#5074
brentvatne wants to merge 1 commit into
react:masterfrom
expo:uiexplorer-image-example-fixes

Conversation

@brentvatne

Copy link
Copy Markdown
Collaborator

- Also re-order a bit and limit ImageSizeExample to iOS
@brentvatne

Copy link
Copy Markdown
CollaboratorAuthor

@facebook-github-bot shipit

@facebook-github-bot

Copy link
Copy Markdown
Contributor

By analyzing the blame information on this pull request, we identified @amasad, @sahrens and @nicklockwood to be potential reviewers.

@facebook-github-botfacebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 1, 2016
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1680276885585191/int_phab to review.

@bestander

Copy link
Copy Markdown
Contributor

@nicklockwood is comandeering the revision manually

@nicklockwood

Copy link
Copy Markdown
Contributor

@brentvatne it turns out that loadingIndicatorSource is something that was added hastily for an internal use case, and it's not something we want to support as it has really weird semantics that are very specific to how Fresco works internally.

I'm still considering whether we want to keep defaultSource. It's potentially useful, but only if it can be ported to Android, I think.

@brentvatne

Copy link
Copy Markdown
CollaboratorAuthor

Ah great to know, thanks for the follow up @nicklockwood! I created an issue for that at #5158 :) No need to keep this one open.

ghost pushed a commit that referenced this pull request Feb 1, 2016
Summary: Closes#5074
Reviewed By: svcscm
Differential Revision: D2798023
Pulled By: nicklockwood
fb-gh-sync-id: d8aa87bf8dcbecf53b341d5914bbe3354cc753aa
@ide
ide deleted the uiexplorer-image-example-fixes branch March 11, 2016 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@brentvatne@facebook-github-bot@bestander@nicklockwood@skevy