Uh oh!
There was an error while loading. Please reload this page.
See issue #4886 - #5093
Conversation
On iOS the plist key NSLocationAlwaysUsageDescription was ignored and the location could not be retreived when using this key. Now both keys NSLocationWhenInUseUsageDescription and NSLocationAlwaysUsageDescription are supported. If NSLocationAlwaysUsageDescription is set, NSLocationWhenInUseUsageDescription will be simply ignored according to https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html#//apple_ref/doc/uid/TP40009251-SW18
facebook-github-bot
commented
Jan 3, 2016
By analyzing the blame information on this pull request, we identified @brentvatne, @nicklockwood and @zjj010104 to be potential reviewers. |
facebook-github-bot
commented
Jan 3, 2016
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
facebook-github-bot
commented
Jan 3, 2016
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
onchainguy-btc
commented
Jan 12, 2016
@brentvatne how can I restart the build for this pull request. Seems that the failing build was due to other problems |
nicklockwood
commented
Jan 12, 2016
This is great, thanks! I was looking for a way to support both background and foreground update modes without needing to add proprietary properties to Geolocation.js, and this is a neat solution. |
nicklockwood
commented
Jan 12, 2016
@facebook-github-bot shipit |
facebook-github-bot
commented
Jan 12, 2016
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1658356151101610/int_phab to review. |
@brentvatne this is the pull request you requested
See issue #4886
On iOS the plist key NSLocationAlwaysUsageDescription was ignored and the location could not be retreived when using this key. Now both keys NSLocationWhenInUseUsageDescription and NSLocationAlwaysUsageDescription are supported. If NSLocationAlwaysUsageDescription is set, NSLocationWhenInUseUsageDescription will be simply ignored according to https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html#//apple_ref/doc/uid/TP40009251-SW18
I read the contribution guidelines regarding the Objective-C coding standards. Hopefully my line length breaks are okay - otherwise just give me a shout and I will fix that. Didn't write any line of Objective-C before so^^