Extended icon and selectedIcon propType to include scale

[cem2ran]

Resolves issue #4591

Not sure what the best practice is with regards to de-duplication in propTypes, and if that proptype should therefore be declared as a variable and reused for icon and selectedIcon?

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @nicklockwood, @vjeux and @sahrens to be potential reviewers.

[nicklockwood]

Image.propTypes.source is already the canonical representation for image source shape. It doesn't currently include scale, but it probably should, along with width and height.

[cem2ran]

That was my initial thought too. I tried adding scale to an Image in ImageExample to test it out, but it didn't seem to scale:

<Image style={{
width: 75,
height: 75,
backgroundColor: 'transparent',
marginRight: 10,
}}
source={{uri: base64Icon, scale: 3}} />

Is this the expected behaviour? Where should I be looking to determine the missing propTypes?
This is my first deep dive into source.

[facebook-github-bot]

@cem2ran updated the pull request.

[mkonicek]

Image.propTypes.source is already the canonical representation for image source shape.

I tried adding scale to an Image in ImageExample to test it out, but it didn't seem to scale:

I believe we should solve that problem in a generic way as discussed above, rather than this PR. I'll close this. Let me know if I'm mistaken :)

[nicklockwood]

@cem2ran setting scale in an <Image> source is unlikely to have any effect, as the scaling of images is controlled by the width, height and resizeMode styles.

The scale property is useful only in cases where the image size isn't specified any other way, such as the icons in a TabBarIOS.