Skip to content

RuntimeExecutor: Refine the variables and comments again - #51429

Closed
RSNara wants to merge 1 commit into
react:mainfrom
RSNara:export-D74941734
Closed

RuntimeExecutor: Refine the variables and comments again#51429
RSNara wants to merge 1 commit into
react:mainfrom
RSNara:export-D74941734

Conversation

@RSNara

@RSNaraRSNara commented May 17, 2025

Copy link
Copy Markdown
Contributor

Summary:
Just refactoring an renaming the variables inside RuntimeExecutor again (in a separate diff). Just so that the logic in the subsequent diffs is easier to read: D74769326

Changelog: [Internal]

Differential Revision: D74941734

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 17, 2025
@facebook-github-bot

facebook-github-bot commented May 17, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from 7d437a7 to 3f15164CompareMay 18, 2025 16:23
@facebook-github-bot

facebook-github-bot commented May 18, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from 3f15164 to e39a03aCompareMay 19, 2025 00:58
@facebook-github-bot

facebook-github-bot commented May 19, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from e39a03a to e197eeeCompareMay 19, 2025 01:48
@facebook-github-bot

facebook-github-bot commented May 19, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from e197eee to 2ac9436CompareMay 19, 2025 18:56
@facebook-github-bot

facebook-github-bot commented May 19, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from 2ac9436 to 98c4338CompareMay 20, 2025 20:35
@facebook-github-bot

facebook-github-bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from 98c4338 to 7d7293fCompareMay 20, 2025 20:40
@facebook-github-bot

facebook-github-bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from 7d7293f to ced90a9CompareMay 20, 2025 20:45
@RSNara
RSNaraforce-pushed the export-D74941734 branch from ced90a9 to d164547CompareMay 20, 2025 22:37
@facebook-github-bot

facebook-github-bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from d164547 to b55f6f7CompareMay 20, 2025 22:41
@RSNara
RSNaraforce-pushed the export-D74941734 branch from b55f6f7 to 57d6846CompareMay 21, 2025 01:02
@facebook-github-bot

facebook-github-bot commented May 21, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from 57d6846 to 5e429f1CompareMay 21, 2025 14:30
@RSNara
RSNaraforce-pushed the export-D74941734 branch from ae994c4 to 0651383CompareMay 21, 2025 21:44
@RSNara
RSNaraforce-pushed the export-D74941734 branch from 0651383 to cb7bfe6CompareMay 21, 2025 21:50
@facebook-github-bot

facebook-github-bot commented May 21, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@facebook-github-bot

facebook-github-bot commented May 21, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from cb7bfe6 to 625b0d1CompareMay 21, 2025 21:53
@RSNara
RSNaraforce-pushed the export-D74941734 branch from 625b0d1 to d251808CompareMay 21, 2025 23:35
@facebook-github-bot

facebook-github-bot commented May 21, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from d251808 to 17801f3CompareMay 22, 2025 00:23
@facebook-github-bot

facebook-github-bot commented May 22, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara
RSNaraforce-pushed the export-D74941734 branch from 17801f3 to 42c713fCompareMay 22, 2025 16:30
@facebook-github-bot

facebook-github-bot commented May 22, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

7 similar comments
@facebook-github-bot

facebook-github-bot commented May 23, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@facebook-github-bot

facebook-github-bot commented May 23, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@facebook-github-bot

facebook-github-bot commented May 23, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@facebook-github-bot

facebook-github-bot commented May 23, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@facebook-github-bot

facebook-github-bot commented May 23, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@facebook-github-bot

facebook-github-bot commented May 24, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@facebook-github-bot

facebook-github-bot commented May 24, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@RSNara@facebook-github-bot
RuntimeExecutor: Use promises in sync ui thread utils (react#51429)
52f7225
Summary:
Pull Request resolved: react#51429
If we use promises, I believe the code is just easier to understand.
Changelog: [Internal]
Reviewed By: javache, yungsters
Differential Revision: D74941734
@facebook-github-bot

facebook-github-bot commented May 27, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74941734

@react-native-bot

react-native-bot commented May 27, 2025

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @RSNara in 4974839

When will my fix make it into a release? | How to file a pick request?

@facebook-github-bot

facebook-github-bot commented May 27, 2025

Copy link
Copy Markdown
Contributor

This pull request has been merged in 4974839.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RSNara@facebook-github-bot@react-native-bot