Skip to content

fix: exclusion of selectively disabled libraries from codegen generation#51838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aattola wants to merge 2 commits into from
Closed

fix: exclusion of selectively disabled libraries from codegen generation #51838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d3ec18
fix: exclusion of selectively disabled libraries from codegen generation
aattola Jun 5, 2025
6698918
fix(tests): to expect name in extractLibrariesFromJSON
aattola Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/scripts/codegen/__tests__/generate-artifacts-executor-test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,6 +96,7 @@ const packageJson = JSON.stringify({
jsSrcsDir: '.',
},
libraryPath: rootPath,
name: 'react-native',
});
});

Expand All@@ -112,6 +113,7 @@ const packageJson = JSON.stringify({
jsSrcsDir: '.',
},
libraryPath: myDependencyPath,
name: 'react-native',
});
expect(libraries[1]).toEqual({
config: {
Expand All@@ -120,6 +122,7 @@ const packageJson = JSON.stringify({
jsSrcsDir: 'component/js',
},
libraryPath: myDependencyPath,
name: 'my-component',
});
expect(libraries[2]).toEqual({
config: {
Expand All@@ -128,6 +131,7 @@ const packageJson = JSON.stringify({
jsSrcsDir: 'module/js',
},
libraryPath: myDependencyPath,
name: 'my-module',
});
});
});
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -236,6 +236,7 @@ function extractLibrariesFromJSON(
const config = configFile.codegenConfig;
return [
{
name: configFile.name,
config,
libraryPath: dependencyPath,
},
Expand DownExpand Up@@ -290,6 +291,7 @@ function extractLibrariesFromConfigurationArray(
) {
return configFile.codegenConfig.libraries.map(config => {
return {
name: config.name,
config,
libraryPath: dependencyPath,
};
Expand Down