[WIP] Initial implementation of Modal on Android

[satya164]

The <Modal /> component has the same API as on iOS - http://facebook.github.io/react-native/docs/modal.html#content

The animated prop is not implemented yet.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @mkonicek, @ajwhite and @bestander to be potential reviewers.

[mkonicek]

nit: add a license header please

[satya164]

@mkonicek Done :)

[facebook-github-bot]

@satya164 updated the pull request.

[mkonicek]

Wow that was fast! I assume I'll have to update some internal Buck files in order to merge this, let's see :)

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/741802762587821/int_phab to review.

[facebook-github-bot]

@satya164 updated the pull request.

[satya164]

Import failed? @mkonicek

[mkonicek]

Yup need to update BUCK files.

[satya164]

Resolved conflicts.

[facebook-github-bot]

@satya164 updated the pull request.

[Ehesp]

Nice work :)

[mkonicek]

Cool, will update the Buck files and merge this. I'm doing an internal hackathon today with Shawn Wilsher from the Buck team trying to get OSS RN to build with Buck. Will move the release to Monday.

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/741802762587821/int_phab to review.

[mkonicek]

Does the Modal work well for you? I've added ModalExample to UIExplorerList.android.js, here's a screen recording: https://youtu.be/nRe_Clx4Y-k

[satya164]

@mkonicek I had only tried closing the modal with back button. Will investigate what's happening. Thanks.

[facebook-github-bot]

@satya164 updated the pull request.

[facebook-github-bot]

@satya164 updated the pull request.

[satya164]

So, I've been trying to fix the <Modal /> the whole night. The issue is that the view inside the modal doesn't receive touch. I think this is because the createViewInstance method returns a ReactModalHostView which is initialized and configured to receive touches and stuff, but it's not really used anywhere. A different ReactViewGroup instance is created which is added to the dialog, and it's not configured to respond to touches.

I cannot add the instance of the class to the dialog either, because that instance is appended to a parent view on it's creation

[satya164]

cc @AaaChiuuu

[mkonicek]

Thanks for looking into it and sorry about that, I assumed it worked out of the box!

[satya164]

@mkonicek Me too. Let's get it fixed. It's gonna save me a bunch of really ugly code :D

[mpretty-cyro]

@satya164@mkonicek has there been any movement on this? I'm about to start adding in some platform checks to avoid attempting to display UI modally but would love to avoid having to do that if this PR is going to drop some time soon.

[satya164]

@mpretty-homepass Nope. There are some technical difficulties we need to handle before this can be merged. It might take some time.

[mpretty-cyro]

@satya164 Ok I'll set Android up to push all modals for the time being, thanks for the update.

[satya164]

<Modal /> was open sourced in db7a154