[Refactor] Add cross-platform Linking module by satya164 · Pull Request #5336 · react/react-native

satya164 · 2016-01-15T14:02:14Z

A promise based API for handling Link for Android and iOS. Refer #4971

The iOS part doesn't handle errors. Will need someone with iOS knowledge to do that.

cc @skevy @ide @brentvatne @mkonicek @vjeux @nicklockwood

facebook-github-bot · 2016-01-15T14:04:44Z

By analyzing the blame information on this pull request, we identified @mkonicek and @satya164 to be potential reviewers.

satya164 · 2016-01-15T14:07:40Z

We also need to decide what to do with IntentAndroid and LinkingIOS.

Show warnings stating that they are deprecated and use 'Linking', while they continue to work.
Show errors stating that they are deprecated and use 'Linking', making them noop.

It'd also be nice to provide a codemod to automate the transition. Will see if I can work on it.

Expose Linking module Use Flow in Linking

nicklockwood · 2016-01-15T14:56:01Z

@satya164

We also need to decide what to do with IntentAndroid and LinkingIOS.

Option 1 is my preferred approach. Then in the next release we can maybe move to option 2, and then eventually remove them altogether.

satya164 · 2016-01-15T15:00:57Z

@nicklockwood Awesome. I'll add the warnings.

facebook-github-bot · 2016-01-15T15:11:31Z

@satya164 updated the pull request.

satya164 · 2016-01-16T20:15:16Z

@skevy @chirag04 Wanna help with the iOS implementation?

facebook-github-bot · 2016-01-23T21:53:15Z

@satya164 updated the pull request.

satya164 · 2016-01-23T21:55:24Z

cc @dmmiller @nicklockwood

mkonicek · 2016-01-25T00:13:17Z

mkonicek · 2016-01-25T00:13:32Z

Awesome! Thanks for working on this!

satya164 · 2016-01-25T17:41:54Z

I'm confused on what should I resolve with here.

facebook-github-bot · 2016-01-25T17:46:19Z

@satya164 updated the pull request.

satya164 · 2016-01-25T18:29:16Z

Maybe this can be just a warning, and not error?

christopherdro · 2016-01-25T19:09:52Z

Nice one @satya164!
I'm wondering if we can work on getting https://github.com/facebook/react-native-applinks to work with this new API and have android support?

mkonicek · 2016-01-26T16:04:31Z

Had a quick look again, once you're happy with it feel free to shipit :)

satya164 · 2016-01-26T20:43:44Z

@christopherdro I don't use that lib, but if someone can fix it to work with this change, it'll surely be great.

@mkonicek Only one doubt, what should I resolve with here - https://github.com/facebook/react-native/pull/5336/files#diff-fab623097f5131602a9aa8e4829fb6a9R90

null seems to be good candidate, but then I've no idea how to do the same with iOS - https://github.com/facebook/react-native/pull/5336/files#diff-07733d30787de00582b6e9693d4be698R83

facebook-github-bot · 2016-01-26T21:09:13Z

@satya164 updated the pull request.

satya164 · 2016-01-26T21:09:31Z

Talked to @dmmiller . He's fine with true.

facebook-github-bot · 2016-01-26T21:13:17Z

@satya164 updated the pull request.

satya164 · 2016-01-26T21:13:18Z

@facebook-github-bot shipit

facebook-github-bot · 2016-01-26T21:13:32Z

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/844257825700338/int_phab to review.

Summary: A promise based API for handling Link for Android and iOS. Refer react#4971 The iOS part doesn't handle errors. Will need someone with iOS knowledge to do that. cc skevy ide brentvatne mkonicek vjeux nicklockwood Closesreact#5336 Reviewed By: svcscm Differential Revision: D2866664 Pulled By: androidtrunkagent fb-gh-sync-id: 67e68a827e6b85886bfa84e79b897f079e78b1b5

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 15, 2016

satya164 added 2 commits January 15, 2016 19:48

Add cross-platform linking component
26f33c3
Expose Linking module Use Flow in Linking

Use Linking in LinkingIOS and IntentAndroid
a773991

satya164 changed the title ~~Add cross-platform linking component~~[WIP] Add cross-platform linking componentJan 15, 2016

satya164 changed the title ~~[WIP] Add cross-platform linking component~~[WIP] Add cross-platform Linking componentJan 15, 2016

satya164 changed the title ~~[WIP] Add cross-platform Linking component~~[WIP] Add cross-platform Linking moduleJan 15, 2016

satya164 mentioned this pull request Jan 15, 2016
Simplified AlertIOS #5286
Closed

chirag04 mentioned this pull request Jan 15, 2016
Universal Linking component #4546
Closed

Add deprecation wanrings
9908892

satya164 added the Work in progress label Jan 17, 2016

Merge branch 'master' into linking
55f9d13

satya164 removed the Work in progress label Jan 23, 2016

satya164 changed the title ~~[WIP] Add cross-platform Linking module~~[Refactor] Add cross-platform Linking moduleJan 23, 2016

mkonicek reviewed Jan 25, 2016
View reviewed changes

Comment threadLibraries/Components/Intent/IntentAndroid.android.js
mkonicekJan 25, 2016
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!

satya164 reviewed Jan 25, 2016
View reviewed changes

Use promises in RCTLinkingManager on iOS
5a1b2cc

satya164 mentioned this pull request Jan 25, 2016
IntentAndroid.openChooserWithOptions implements #5476
Closed

satya164 reviewed Jan 25, 2016
View reviewed changes

Comment threadLibraries/Linking/Linking.js Outdated
satya164Jan 25, 2016
Copy link
Copy Markdown
ContributorAuthor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be just a warning, and not error?

mkonicek added the GH Review: accepted label Jan 26, 2016

Show warning instead of error
ce316fa

Add type annotations
b75fc47

ghost closed this in e33e6abJan 26, 2016

satya164 deleted the linking branch January 26, 2016 22:40

corbt mentioned this pull request Jan 27, 2016
Switch to Promise-based API react-native-camera/react-native-camera#168
Closed

This pull request was closed.

Uh oh!

Conversation

satya164 commented Jan 15, 2016

Uh oh!

facebook-github-bot commented Jan 15, 2016

Uh oh!

satya164 commented Jan 15, 2016

Uh oh!

nicklockwood commented Jan 15, 2016

Uh oh!

satya164 commented Jan 15, 2016

Uh oh!

facebook-github-bot commented Jan 15, 2016

Uh oh!

satya164 commented Jan 16, 2016

Uh oh!

facebook-github-bot commented Jan 23, 2016

Uh oh!

satya164 commented Jan 23, 2016

Uh oh!

mkonicekJan 25, 2016

Choose a reason for hiding this comment

Uh oh!

mkonicek commented Jan 25, 2016

Uh oh!

satya164Jan 25, 2016

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jan 25, 2016

Uh oh!

satya164Jan 25, 2016

Choose a reason for hiding this comment

Uh oh!

christopherdro commented Jan 25, 2016

Uh oh!

mkonicek commented Jan 26, 2016

Uh oh!

satya164 commented Jan 26, 2016

Uh oh!

facebook-github-bot commented Jan 26, 2016

Uh oh!

satya164 commented Jan 26, 2016

Uh oh!

facebook-github-bot commented Jan 26, 2016

Uh oh!

satya164 commented Jan 26, 2016

Uh oh!

facebook-github-bot commented Jan 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants