Skip to content

Fix CQS signal readability-redundant-smartptr-get in xplat/js/react-native-github/packages#54065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
facebook-github-bot wants to merge 1 commit into from
Closed

Fix CQS signal readability-redundant-smartptr-get in xplat/js/react-native-github/packages #54065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/React/Fabric/Mounting/RCTMountingManager.mm
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -299,7 +299,7 @@ - (void)synchronouslyUpdateViewOnUIThread:(ReactTag)reactTag
SurfaceId surfaceId = RCTSurfaceIdForView(componentView);
Props::Shared oldProps = [componentView props];
Props::Shared newProps = componentDescriptor.cloneProps(
PropsParserContext{surfaceId, *_contextContainer.get()}, oldProps, RawProps(std::move(props)));
PropsParserContext{surfaceId, *_contextContainer}, oldProps, RawProps(std::move(props)));

NSSet<NSString *> *propKeys = componentView.propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN ?: [NSSet new];
propKeys = [propKeys setByAddingObjectsFromArray:propsKeysToBeUpdated];
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -225,7 +225,7 @@ Size SurfaceHandler::measure(
link_.shadowTree->getCurrentRevision().rootShadowNode;

PropsParserContext propsParserContext{
parameters_.surfaceId, *parameters_.contextContainer.get()};
parameters_.surfaceId, *parameters_.contextContainer};

auto rootShadowNode = currentRootShadowNode->clone(
propsParserContext, layoutConstraints, layoutContext);
Expand DownExpand Up@@ -329,7 +329,7 @@ void SurfaceHandler::constraintLayout(
}

PropsParserContext propsParserContext{
parameters_.surfaceId, *parameters_.contextContainer.get()};
parameters_.surfaceId, *parameters_.contextContainer};

react_native_assert(
link_.shadowTree && "`link_.shadowTree` must not be null.");
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,7 +70,7 @@ std::shared_ptr<ShadowNode> UIManager::createNode(
auto fallbackDescriptor =
componentDescriptorRegistry_->getFallbackComponentDescriptor();

PropsParserContext propsParserContext{surfaceId, *contextContainer_.get()};
PropsParserContext propsParserContext{surfaceId, *contextContainer_};

auto family = componentDescriptor.createFamily(
{tag, surfaceId, std::move(instanceHandle)});
Expand DownExpand Up@@ -111,7 +111,7 @@ std::shared_ptr<ShadowNode> UIManager::cloneNode(
"UIManager::cloneNode", "componentName", shadowNode.getComponentName());

PropsParserContext propsParserContext{
shadowNode.getFamily().getSurfaceId(), *contextContainer_.get()};
shadowNode.getFamily().getSurfaceId(), *contextContainer_};

auto& componentDescriptor = shadowNode.getComponentDescriptor();
auto& family = shadowNode.getFamily();
Expand DownExpand Up@@ -455,7 +455,7 @@ void UIManager::setNativeProps_DEPRECATED(
componentDescriptorRegistry_->at(
shadowNode->getComponentHandle());
PropsParserContext propsParserContext{
family.getSurfaceId(), *contextContainer_.get()};
family.getSurfaceId(), *contextContainer_};
auto props = componentDescriptor.cloneProps(
propsParserContext,
getShadowNodeInSubtree(*shadowNode, ancestorShadowNode)
Expand Down
Loading