Add Performance Issues to Perf Monitor (1/2)#54265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 1 commit into from
Closed

Add Performance Issues to Perf Monitor (1/2) #54265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<3ea1ee77358d99334a7c40bed44f2d90>>
* @generated SignedSource<<bac9e360daa589cba476d208f75ef2ca>>
*/

/**
Expand DownExpand Up@@ -372,6 +372,12 @@ public object ReactNativeFeatureFlags {
@JvmStatic
public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()

/**
* Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
*/
@JvmStatic
public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()

/**
* Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
*/
Expand Down
12 changes: 11 additions & 1 deletion .../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<007a5a1235a999716b382ffd4ca23158>>
* @generated SignedSource<<2003ae7fc2c782b997d21938cc7b2380>>
*/

/**
Expand DownExpand Up@@ -77,6 +77,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
private var perfIssuesEnabledCache: Boolean? = null
private var perfMonitorV2EnabledCache: Boolean? = null
private var preparedTextCacheSizeCache: Double? = null
private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -615,6 +616,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
return cached
}

override fun perfIssuesEnabled(): Boolean {
var cached = perfIssuesEnabledCache
if (cached == null) {
cached = ReactNativeFeatureFlagsCxxInterop.perfIssuesEnabled()
perfIssuesEnabledCache = cached
}
return cached
}

override fun perfMonitorV2Enabled(): Boolean {
var cached = perfMonitorV2EnabledCache
if (cached == null) {
Expand Down
4 changes: 3 additions & 1 deletion ...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<8a775646d455cdb6d017fd08aee3e807>>
* @generated SignedSource<<986b35ba4f323ab1a65dd70a559889e9>>
*/

/**
Expand DownExpand Up@@ -142,6 +142,8 @@ public object ReactNativeFeatureFlagsCxxInterop {

@DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

@DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean

@DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean

@DoNotStrip @JvmStatic public external fun preparedTextCacheSize(): Double
Expand Down
4 changes: 3 additions & 1 deletion ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<afccaed3066598724041c48bfb524234>>
* @generated SignedSource<<43f629e3be734826b241d7e596daf6f4>>
*/

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false

override fun perfIssuesEnabled(): Boolean = false

override fun perfMonitorV2Enabled(): Boolean = false

override fun preparedTextCacheSize(): Double = 200.0
Expand Down
13 changes: 12 additions & 1 deletion ...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<ebeb9b37b8d3d0e31f4d4966cbf42b3f>>
* @generated SignedSource<<806741418f4ff7e3b6dcac3d78fa27dd>>
*/

/**
Expand DownExpand Up@@ -81,6 +81,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
private var perfIssuesEnabledCache: Boolean? = null
private var perfMonitorV2EnabledCache: Boolean? = null
private var preparedTextCacheSizeCache: Double? = null
private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -676,6 +677,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
return cached
}

override fun perfIssuesEnabled(): Boolean {
var cached = perfIssuesEnabledCache
if (cached == null) {
cached = currentProvider.perfIssuesEnabled()
accessedFeatureFlags.add("perfIssuesEnabled")
perfIssuesEnabledCache = cached
}
return cached
}

override fun perfMonitorV2Enabled(): Boolean {
var cached = perfMonitorV2EnabledCache
if (cached == null) {
Expand Down
4 changes: 3 additions & 1 deletion ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<1c4ea60d119996f37742542976fedcc8>>
* @generated SignedSource<<1a08578b36cb91a183a435b881ca272f>>
*/

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public interface ReactNativeFeatureFlagsProvider {

@DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

@DoNotStrip public fun perfIssuesEnabled(): Boolean

@DoNotStrip public fun perfMonitorV2Enabled(): Boolean

@DoNotStrip public fun preparedTextCacheSize(): Double
Expand Down
16 changes: 15 additions & 1 deletion ...ative/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d04720bbbd42eaf338be612a0f3e36a6>>
* @generated SignedSource<<4c22217e5a773fd97f4041ef6e052ebc>>
*/

/**
Expand DownExpand Up@@ -381,6 +381,12 @@ class ReactNativeFeatureFlagsJavaProvider
return method(javaProvider_);
}

bool perfIssuesEnabled() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
return method(javaProvider_);
}

bool perfMonitorV2Enabled() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfMonitorV2Enabled");
Expand DownExpand Up@@ -814,6 +820,11 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
}

bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::perfIssuesEnabled();
}

bool JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::perfMonitorV2Enabled();
Expand DownExpand Up@@ -1136,6 +1147,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
makeNativeMethod(
"overrideBySynchronousMountPropsAtMountingAndroid",
JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
makeNativeMethod(
"perfIssuesEnabled",
JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),
makeNativeMethod(
"perfMonitorV2Enabled",
JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled),
Expand Down
5 changes: 4 additions & 1 deletion ...-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<7679a91daba1f8941b78a4be4baea6ef>>
* @generated SignedSource<<91f5bbbab5f34321687c6f6d31ca49d8>>
*/

/**
Expand DownExpand Up@@ -201,6 +201,9 @@ class JReactNativeFeatureFlagsCxxInterop
static bool overrideBySynchronousMountPropsAtMountingAndroid(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

static bool perfIssuesEnabled(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

static bool perfMonitorV2Enabled(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

Expand Down
6 changes: 5 additions & 1 deletion packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<303e8208cbdf0b9b9041942822c5597d>>
* @generated SignedSource<<91ecd61e5e2ed1a15248db4e40993018>>
*/

/**
Expand DownExpand Up@@ -254,6 +254,10 @@ bool ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid()
return getAccessor().overrideBySynchronousMountPropsAtMountingAndroid();
}

bool ReactNativeFeatureFlags::perfIssuesEnabled() {
return getAccessor().perfIssuesEnabled();
}

bool ReactNativeFeatureFlags::perfMonitorV2Enabled() {
return getAccessor().perfMonitorV2Enabled();
}
Expand Down
7 changes: 6 additions & 1 deletion packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<07b665ad842faafaf7520051f636d805>>
* @generated SignedSource<<e996f8acef4c9feeda40ea920a2e5353>>
*/

/**
Expand DownExpand Up@@ -324,6 +324,11 @@ class ReactNativeFeatureFlags {
*/
RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();

/**
* Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
*/
RN_EXPORT static bool perfIssuesEnabled();

/**
* Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
*/
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add Performance Issues to Perf Monitor (1/2)#54265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add Performance Issues to Perf Monitor (1/2)
#54265
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<3ea1ee77358d99334a7c40bed44f2d90>>
 * @generated SignedSource<<bac9e360daa589cba476d208f75ef2ca>>
 */

/**
Expand DownExpand Up@@ -372,6 +372,12 @@ public object ReactNativeFeatureFlags {
 @JvmStatic
 public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 @JvmStatic
 public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down

12 changes: 11 additions & 1 deletion
.../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<007a5a1235a999716b382ffd4ca23158>>
 * @generated SignedSource<<2003ae7fc2c782b997d21938cc7b2380>>
 */

/**
Expand DownExpand Up@@ -77,6 +77,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -615,6 +616,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = ReactNativeFeatureFlagsCxxInterop.perfIssuesEnabled()
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<8a775646d455cdb6d017fd08aee3e807>>
 * @generated SignedSource<<986b35ba4f323ab1a65dd70a559889e9>>
 */

/**
Expand DownExpand Up@@ -142,6 +142,8 @@ public object ReactNativeFeatureFlagsCxxInterop {

 @DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean

 @DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip @JvmStatic public external fun preparedTextCacheSize(): Double
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<afccaed3066598724041c48bfb524234>>
 * @generated SignedSource<<43f629e3be734826b241d7e596daf6f4>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

 override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false

 override fun perfIssuesEnabled(): Boolean = false

 override fun perfMonitorV2Enabled(): Boolean = false

 override fun preparedTextCacheSize(): Double = 200.0
Expand Down

13 changes: 12 additions & 1 deletion
...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<ebeb9b37b8d3d0e31f4d4966cbf42b3f>>
 * @generated SignedSource<<806741418f4ff7e3b6dcac3d78fa27dd>>
 */

/**
Expand DownExpand Up@@ -81,6 +81,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -676,6 +677,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = currentProvider.perfIssuesEnabled()
 accessedFeatureFlags.add("perfIssuesEnabled")
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<1c4ea60d119996f37742542976fedcc8>>
 * @generated SignedSource<<1a08578b36cb91a183a435b881ca272f>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public interface ReactNativeFeatureFlagsProvider {

 @DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip public fun perfIssuesEnabled(): Boolean

 @DoNotStrip public fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip public fun preparedTextCacheSize(): Double
Expand Down

16 changes: 15 additions & 1 deletion
...ative/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<d04720bbbd42eaf338be612a0f3e36a6>>
 * @generated SignedSource<<4c22217e5a773fd97f4041ef6e052ebc>>
 */

/**
Expand DownExpand Up@@ -381,6 +381,12 @@ class ReactNativeFeatureFlagsJavaProvider
 return method(javaProvider_);
 }

 bool perfIssuesEnabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
 return method(javaProvider_);
 }

 bool perfMonitorV2Enabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfMonitorV2Enabled");
Expand DownExpand Up@@ -814,6 +820,11 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
 return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
}

bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfIssuesEnabled();
}

bool JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfMonitorV2Enabled();
Expand DownExpand Up@@ -1136,6 +1147,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
 makeNativeMethod(
 "overrideBySynchronousMountPropsAtMountingAndroid",
 JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
 makeNativeMethod(
 "perfIssuesEnabled",
 JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),
 makeNativeMethod(
 "perfMonitorV2Enabled",
 JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled),
Expand Down

5 changes: 4 additions & 1 deletion
...-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<7679a91daba1f8941b78a4be4baea6ef>>
 * @generated SignedSource<<91f5bbbab5f34321687c6f6d31ca49d8>>
 */

/**
Expand DownExpand Up@@ -201,6 +201,9 @@ class JReactNativeFeatureFlagsCxxInterop
 static bool overrideBySynchronousMountPropsAtMountingAndroid(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

Expand Down

6 changes: 5 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<303e8208cbdf0b9b9041942822c5597d>>
 * @generated SignedSource<<91ecd61e5e2ed1a15248db4e40993018>>
 */

/**
Expand DownExpand Up@@ -254,6 +254,10 @@ bool ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid()
 return getAccessor().overrideBySynchronousMountPropsAtMountingAndroid();
}

bool ReactNativeFeatureFlags::perfIssuesEnabled() {
 return getAccessor().perfIssuesEnabled();
}

bool ReactNativeFeatureFlags::perfMonitorV2Enabled() {
 return getAccessor().perfMonitorV2Enabled();
}
Expand Down

7 changes: 6 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<07b665ad842faafaf7520051f636d805>>
 * @generated SignedSource<<e996f8acef4c9feeda40ea920a2e5353>>
 */

/**
Expand DownExpand Up@@ -324,6 +324,11 @@ class ReactNativeFeatureFlags {
 */
 RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 RN_EXPORT static bool perfIssuesEnabled();

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Performance Issues to Perf Monitor (1/2)#54265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add Performance Issues to Perf Monitor (1/2)
#54265
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<3ea1ee77358d99334a7c40bed44f2d90>>
 * @generated SignedSource<<bac9e360daa589cba476d208f75ef2ca>>
 */

/**
Expand DownExpand Up@@ -372,6 +372,12 @@ public object ReactNativeFeatureFlags {
 @JvmStatic
 public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 @JvmStatic
 public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down

12 changes: 11 additions & 1 deletion
.../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<007a5a1235a999716b382ffd4ca23158>>
 * @generated SignedSource<<2003ae7fc2c782b997d21938cc7b2380>>
 */

/**
Expand DownExpand Up@@ -77,6 +77,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -615,6 +616,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = ReactNativeFeatureFlagsCxxInterop.perfIssuesEnabled()
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<8a775646d455cdb6d017fd08aee3e807>>
 * @generated SignedSource<<986b35ba4f323ab1a65dd70a559889e9>>
 */

/**
Expand DownExpand Up@@ -142,6 +142,8 @@ public object ReactNativeFeatureFlagsCxxInterop {

 @DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean

 @DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip @JvmStatic public external fun preparedTextCacheSize(): Double
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<afccaed3066598724041c48bfb524234>>
 * @generated SignedSource<<43f629e3be734826b241d7e596daf6f4>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

 override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false

 override fun perfIssuesEnabled(): Boolean = false

 override fun perfMonitorV2Enabled(): Boolean = false

 override fun preparedTextCacheSize(): Double = 200.0
Expand Down

13 changes: 12 additions & 1 deletion
...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<ebeb9b37b8d3d0e31f4d4966cbf42b3f>>
 * @generated SignedSource<<806741418f4ff7e3b6dcac3d78fa27dd>>
 */

/**
Expand DownExpand Up@@ -81,6 +81,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -676,6 +677,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = currentProvider.perfIssuesEnabled()
 accessedFeatureFlags.add("perfIssuesEnabled")
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<1c4ea60d119996f37742542976fedcc8>>
 * @generated SignedSource<<1a08578b36cb91a183a435b881ca272f>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public interface ReactNativeFeatureFlagsProvider {

 @DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip public fun perfIssuesEnabled(): Boolean

 @DoNotStrip public fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip public fun preparedTextCacheSize(): Double
Expand Down

16 changes: 15 additions & 1 deletion
...ative/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<d04720bbbd42eaf338be612a0f3e36a6>>
 * @generated SignedSource<<4c22217e5a773fd97f4041ef6e052ebc>>
 */

/**
Expand DownExpand Up@@ -381,6 +381,12 @@ class ReactNativeFeatureFlagsJavaProvider
 return method(javaProvider_);
 }

 bool perfIssuesEnabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
 return method(javaProvider_);
 }

 bool perfMonitorV2Enabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfMonitorV2Enabled");
Expand DownExpand Up@@ -814,6 +820,11 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
 return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
}

bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfIssuesEnabled();
}

bool JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfMonitorV2Enabled();
Expand DownExpand Up@@ -1136,6 +1147,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
 makeNativeMethod(
 "overrideBySynchronousMountPropsAtMountingAndroid",
 JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
 makeNativeMethod(
 "perfIssuesEnabled",
 JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),
 makeNativeMethod(
 "perfMonitorV2Enabled",
 JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled),
Expand Down

5 changes: 4 additions & 1 deletion
...-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<7679a91daba1f8941b78a4be4baea6ef>>
 * @generated SignedSource<<91f5bbbab5f34321687c6f6d31ca49d8>>
 */

/**
Expand DownExpand Up@@ -201,6 +201,9 @@ class JReactNativeFeatureFlagsCxxInterop
 static bool overrideBySynchronousMountPropsAtMountingAndroid(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

Expand Down

6 changes: 5 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<303e8208cbdf0b9b9041942822c5597d>>
 * @generated SignedSource<<91ecd61e5e2ed1a15248db4e40993018>>
 */

/**
Expand DownExpand Up@@ -254,6 +254,10 @@ bool ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid()
 return getAccessor().overrideBySynchronousMountPropsAtMountingAndroid();
}

bool ReactNativeFeatureFlags::perfIssuesEnabled() {
 return getAccessor().perfIssuesEnabled();
}

bool ReactNativeFeatureFlags::perfMonitorV2Enabled() {
 return getAccessor().perfMonitorV2Enabled();
}
Expand Down

7 changes: 6 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<07b665ad842faafaf7520051f636d805>>
 * @generated SignedSource<<e996f8acef4c9feeda40ea920a2e5353>>
 */

/**
Expand DownExpand Up@@ -324,6 +324,11 @@ class ReactNativeFeatureFlags {
 */
 RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 RN_EXPORT static bool perfIssuesEnabled();

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Performance Issues to Perf Monitor (1/2)#54265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add Performance Issues to Perf Monitor (1/2)
#54265
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<3ea1ee77358d99334a7c40bed44f2d90>>
 * @generated SignedSource<<bac9e360daa589cba476d208f75ef2ca>>
 */

/**
Expand DownExpand Up@@ -372,6 +372,12 @@ public object ReactNativeFeatureFlags {
 @JvmStatic
 public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 @JvmStatic
 public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down

12 changes: 11 additions & 1 deletion
.../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<007a5a1235a999716b382ffd4ca23158>>
 * @generated SignedSource<<2003ae7fc2c782b997d21938cc7b2380>>
 */

/**
Expand DownExpand Up@@ -77,6 +77,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -615,6 +616,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = ReactNativeFeatureFlagsCxxInterop.perfIssuesEnabled()
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<8a775646d455cdb6d017fd08aee3e807>>
 * @generated SignedSource<<986b35ba4f323ab1a65dd70a559889e9>>
 */

/**
Expand DownExpand Up@@ -142,6 +142,8 @@ public object ReactNativeFeatureFlagsCxxInterop {

 @DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean

 @DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip @JvmStatic public external fun preparedTextCacheSize(): Double
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<afccaed3066598724041c48bfb524234>>
 * @generated SignedSource<<43f629e3be734826b241d7e596daf6f4>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

 override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false

 override fun perfIssuesEnabled(): Boolean = false

 override fun perfMonitorV2Enabled(): Boolean = false

 override fun preparedTextCacheSize(): Double = 200.0
Expand Down

13 changes: 12 additions & 1 deletion
...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<ebeb9b37b8d3d0e31f4d4966cbf42b3f>>
 * @generated SignedSource<<806741418f4ff7e3b6dcac3d78fa27dd>>
 */

/**
Expand DownExpand Up@@ -81,6 +81,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -676,6 +677,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = currentProvider.perfIssuesEnabled()
 accessedFeatureFlags.add("perfIssuesEnabled")
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<1c4ea60d119996f37742542976fedcc8>>
 * @generated SignedSource<<1a08578b36cb91a183a435b881ca272f>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public interface ReactNativeFeatureFlagsProvider {

 @DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip public fun perfIssuesEnabled(): Boolean

 @DoNotStrip public fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip public fun preparedTextCacheSize(): Double
Expand Down

16 changes: 15 additions & 1 deletion
...ative/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<d04720bbbd42eaf338be612a0f3e36a6>>
 * @generated SignedSource<<4c22217e5a773fd97f4041ef6e052ebc>>
 */

/**
Expand DownExpand Up@@ -381,6 +381,12 @@ class ReactNativeFeatureFlagsJavaProvider
 return method(javaProvider_);
 }

 bool perfIssuesEnabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
 return method(javaProvider_);
 }

 bool perfMonitorV2Enabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfMonitorV2Enabled");
Expand DownExpand Up@@ -814,6 +820,11 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
 return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
}

bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfIssuesEnabled();
}

bool JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfMonitorV2Enabled();
Expand DownExpand Up@@ -1136,6 +1147,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
 makeNativeMethod(
 "overrideBySynchronousMountPropsAtMountingAndroid",
 JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
 makeNativeMethod(
 "perfIssuesEnabled",
 JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),
 makeNativeMethod(
 "perfMonitorV2Enabled",
 JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled),
Expand Down

5 changes: 4 additions & 1 deletion
...-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<7679a91daba1f8941b78a4be4baea6ef>>
 * @generated SignedSource<<91f5bbbab5f34321687c6f6d31ca49d8>>
 */

/**
Expand DownExpand Up@@ -201,6 +201,9 @@ class JReactNativeFeatureFlagsCxxInterop
 static bool overrideBySynchronousMountPropsAtMountingAndroid(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

Expand Down

6 changes: 5 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<303e8208cbdf0b9b9041942822c5597d>>
 * @generated SignedSource<<91ecd61e5e2ed1a15248db4e40993018>>
 */

/**
Expand DownExpand Up@@ -254,6 +254,10 @@ bool ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid()
 return getAccessor().overrideBySynchronousMountPropsAtMountingAndroid();
}

bool ReactNativeFeatureFlags::perfIssuesEnabled() {
 return getAccessor().perfIssuesEnabled();
}

bool ReactNativeFeatureFlags::perfMonitorV2Enabled() {
 return getAccessor().perfMonitorV2Enabled();
}
Expand Down

7 changes: 6 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<07b665ad842faafaf7520051f636d805>>
 * @generated SignedSource<<e996f8acef4c9feeda40ea920a2e5353>>
 */

/**
Expand DownExpand Up@@ -324,6 +324,11 @@ class ReactNativeFeatureFlags {
 */
 RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 RN_EXPORT static bool perfIssuesEnabled();

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add Performance Issues to Perf Monitor (1/2)#54265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add Performance Issues to Perf Monitor (1/2)
#54265
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<3ea1ee77358d99334a7c40bed44f2d90>>
 * @generated SignedSource<<bac9e360daa589cba476d208f75ef2ca>>
 */

/**
Expand DownExpand Up@@ -372,6 +372,12 @@ public object ReactNativeFeatureFlags {
 @JvmStatic
 public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 @JvmStatic
 public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down

12 changes: 11 additions & 1 deletion
.../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<007a5a1235a999716b382ffd4ca23158>>
 * @generated SignedSource<<2003ae7fc2c782b997d21938cc7b2380>>
 */

/**
Expand DownExpand Up@@ -77,6 +77,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -615,6 +616,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = ReactNativeFeatureFlagsCxxInterop.perfIssuesEnabled()
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<8a775646d455cdb6d017fd08aee3e807>>
 * @generated SignedSource<<986b35ba4f323ab1a65dd70a559889e9>>
 */

/**
Expand DownExpand Up@@ -142,6 +142,8 @@ public object ReactNativeFeatureFlagsCxxInterop {

 @DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean

 @DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip @JvmStatic public external fun preparedTextCacheSize(): Double
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<afccaed3066598724041c48bfb524234>>
 * @generated SignedSource<<43f629e3be734826b241d7e596daf6f4>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

 override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false

 override fun perfIssuesEnabled(): Boolean = false

 override fun perfMonitorV2Enabled(): Boolean = false

 override fun preparedTextCacheSize(): Double = 200.0
Expand Down

13 changes: 12 additions & 1 deletion
...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<ebeb9b37b8d3d0e31f4d4966cbf42b3f>>
 * @generated SignedSource<<806741418f4ff7e3b6dcac3d78fa27dd>>
 */

/**
Expand DownExpand Up@@ -81,6 +81,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -676,6 +677,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = currentProvider.perfIssuesEnabled()
 accessedFeatureFlags.add("perfIssuesEnabled")
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<1c4ea60d119996f37742542976fedcc8>>
 * @generated SignedSource<<1a08578b36cb91a183a435b881ca272f>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public interface ReactNativeFeatureFlagsProvider {

 @DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip public fun perfIssuesEnabled(): Boolean

 @DoNotStrip public fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip public fun preparedTextCacheSize(): Double
Expand Down

16 changes: 15 additions & 1 deletion
...ative/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<d04720bbbd42eaf338be612a0f3e36a6>>
 * @generated SignedSource<<4c22217e5a773fd97f4041ef6e052ebc>>
 */

/**
Expand DownExpand Up@@ -381,6 +381,12 @@ class ReactNativeFeatureFlagsJavaProvider
 return method(javaProvider_);
 }

 bool perfIssuesEnabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
 return method(javaProvider_);
 }

 bool perfMonitorV2Enabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfMonitorV2Enabled");
Expand DownExpand Up@@ -814,6 +820,11 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
 return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
}

bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfIssuesEnabled();
}

bool JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfMonitorV2Enabled();
Expand DownExpand Up@@ -1136,6 +1147,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
 makeNativeMethod(
 "overrideBySynchronousMountPropsAtMountingAndroid",
 JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
 makeNativeMethod(
 "perfIssuesEnabled",
 JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),
 makeNativeMethod(
 "perfMonitorV2Enabled",
 JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled),
Expand Down

5 changes: 4 additions & 1 deletion
...-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<7679a91daba1f8941b78a4be4baea6ef>>
 * @generated SignedSource<<91f5bbbab5f34321687c6f6d31ca49d8>>
 */

/**
Expand DownExpand Up@@ -201,6 +201,9 @@ class JReactNativeFeatureFlagsCxxInterop
 static bool overrideBySynchronousMountPropsAtMountingAndroid(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

Expand Down

6 changes: 5 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<303e8208cbdf0b9b9041942822c5597d>>
 * @generated SignedSource<<91ecd61e5e2ed1a15248db4e40993018>>
 */

/**
Expand DownExpand Up@@ -254,6 +254,10 @@ bool ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid()
 return getAccessor().overrideBySynchronousMountPropsAtMountingAndroid();
}

bool ReactNativeFeatureFlags::perfIssuesEnabled() {
 return getAccessor().perfIssuesEnabled();
}

bool ReactNativeFeatureFlags::perfMonitorV2Enabled() {
 return getAccessor().perfMonitorV2Enabled();
}
Expand Down

7 changes: 6 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<07b665ad842faafaf7520051f636d805>>
 * @generated SignedSource<<e996f8acef4c9feeda40ea920a2e5353>>
 */

/**
Expand DownExpand Up@@ -324,6 +324,11 @@ class ReactNativeFeatureFlags {
 */
 RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 RN_EXPORT static bool perfIssuesEnabled();

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Performance Issues to Perf Monitor (1/2)#54265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add Performance Issues to Perf Monitor (1/2)
#54265
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<3ea1ee77358d99334a7c40bed44f2d90>>
 * @generated SignedSource<<bac9e360daa589cba476d208f75ef2ca>>
 */

/**
Expand DownExpand Up@@ -372,6 +372,12 @@ public object ReactNativeFeatureFlags {
 @JvmStatic
 public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 @JvmStatic
 public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down

12 changes: 11 additions & 1 deletion
.../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<007a5a1235a999716b382ffd4ca23158>>
 * @generated SignedSource<<2003ae7fc2c782b997d21938cc7b2380>>
 */

/**
Expand DownExpand Up@@ -77,6 +77,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -615,6 +616,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = ReactNativeFeatureFlagsCxxInterop.perfIssuesEnabled()
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<8a775646d455cdb6d017fd08aee3e807>>
 * @generated SignedSource<<986b35ba4f323ab1a65dd70a559889e9>>
 */

/**
Expand DownExpand Up@@ -142,6 +142,8 @@ public object ReactNativeFeatureFlagsCxxInterop {

 @DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean

 @DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip @JvmStatic public external fun preparedTextCacheSize(): Double
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<afccaed3066598724041c48bfb524234>>
 * @generated SignedSource<<43f629e3be734826b241d7e596daf6f4>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

 override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false

 override fun perfIssuesEnabled(): Boolean = false

 override fun perfMonitorV2Enabled(): Boolean = false

 override fun preparedTextCacheSize(): Double = 200.0
Expand Down

13 changes: 12 additions & 1 deletion
...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<ebeb9b37b8d3d0e31f4d4966cbf42b3f>>
 * @generated SignedSource<<806741418f4ff7e3b6dcac3d78fa27dd>>
 */

/**
Expand DownExpand Up@@ -81,6 +81,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -676,6 +677,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = currentProvider.perfIssuesEnabled()
 accessedFeatureFlags.add("perfIssuesEnabled")
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<1c4ea60d119996f37742542976fedcc8>>
 * @generated SignedSource<<1a08578b36cb91a183a435b881ca272f>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public interface ReactNativeFeatureFlagsProvider {

 @DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip public fun perfIssuesEnabled(): Boolean

 @DoNotStrip public fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip public fun preparedTextCacheSize(): Double
Expand Down

16 changes: 15 additions & 1 deletion
...ative/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<d04720bbbd42eaf338be612a0f3e36a6>>
 * @generated SignedSource<<4c22217e5a773fd97f4041ef6e052ebc>>
 */

/**
Expand DownExpand Up@@ -381,6 +381,12 @@ class ReactNativeFeatureFlagsJavaProvider
 return method(javaProvider_);
 }

 bool perfIssuesEnabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
 return method(javaProvider_);
 }

 bool perfMonitorV2Enabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfMonitorV2Enabled");
Expand DownExpand Up@@ -814,6 +820,11 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
 return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
}

bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfIssuesEnabled();
}

bool JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfMonitorV2Enabled();
Expand DownExpand Up@@ -1136,6 +1147,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
 makeNativeMethod(
 "overrideBySynchronousMountPropsAtMountingAndroid",
 JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
 makeNativeMethod(
 "perfIssuesEnabled",
 JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),
 makeNativeMethod(
 "perfMonitorV2Enabled",
 JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled),
Expand Down

5 changes: 4 additions & 1 deletion
...-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<7679a91daba1f8941b78a4be4baea6ef>>
 * @generated SignedSource<<91f5bbbab5f34321687c6f6d31ca49d8>>
 */

/**
Expand DownExpand Up@@ -201,6 +201,9 @@ class JReactNativeFeatureFlagsCxxInterop
 static bool overrideBySynchronousMountPropsAtMountingAndroid(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

Expand Down

6 changes: 5 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<303e8208cbdf0b9b9041942822c5597d>>
 * @generated SignedSource<<91ecd61e5e2ed1a15248db4e40993018>>
 */

/**
Expand DownExpand Up@@ -254,6 +254,10 @@ bool ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid()
 return getAccessor().overrideBySynchronousMountPropsAtMountingAndroid();
}

bool ReactNativeFeatureFlags::perfIssuesEnabled() {
 return getAccessor().perfIssuesEnabled();
}

bool ReactNativeFeatureFlags::perfMonitorV2Enabled() {
 return getAccessor().perfMonitorV2Enabled();
}
Expand Down

7 changes: 6 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<07b665ad842faafaf7520051f636d805>>
 * @generated SignedSource<<e996f8acef4c9feeda40ea920a2e5353>>
 */

/**
Expand DownExpand Up@@ -324,6 +324,11 @@ class ReactNativeFeatureFlags {
 */
 RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 RN_EXPORT static bool perfIssuesEnabled();

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Performance Issues to Perf Monitor (1/2)#54265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add Performance Issues to Perf Monitor (1/2)
#54265
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<3ea1ee77358d99334a7c40bed44f2d90>>
 * @generated SignedSource<<bac9e360daa589cba476d208f75ef2ca>>
 */

/**
Expand DownExpand Up@@ -372,6 +372,12 @@ public object ReactNativeFeatureFlags {
 @JvmStatic
 public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 @JvmStatic
 public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down

12 changes: 11 additions & 1 deletion
.../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<007a5a1235a999716b382ffd4ca23158>>
 * @generated SignedSource<<2003ae7fc2c782b997d21938cc7b2380>>
 */

/**
Expand DownExpand Up@@ -77,6 +77,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -615,6 +616,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = ReactNativeFeatureFlagsCxxInterop.perfIssuesEnabled()
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<8a775646d455cdb6d017fd08aee3e807>>
 * @generated SignedSource<<986b35ba4f323ab1a65dd70a559889e9>>
 */

/**
Expand DownExpand Up@@ -142,6 +142,8 @@ public object ReactNativeFeatureFlagsCxxInterop {

 @DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean

 @DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip @JvmStatic public external fun preparedTextCacheSize(): Double
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<afccaed3066598724041c48bfb524234>>
 * @generated SignedSource<<43f629e3be734826b241d7e596daf6f4>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

 override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false

 override fun perfIssuesEnabled(): Boolean = false

 override fun perfMonitorV2Enabled(): Boolean = false

 override fun preparedTextCacheSize(): Double = 200.0
Expand Down

13 changes: 12 additions & 1 deletion
...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<ebeb9b37b8d3d0e31f4d4966cbf42b3f>>
 * @generated SignedSource<<806741418f4ff7e3b6dcac3d78fa27dd>>
 */

/**
Expand DownExpand Up@@ -81,6 +81,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -676,6 +677,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = currentProvider.perfIssuesEnabled()
 accessedFeatureFlags.add("perfIssuesEnabled")
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<1c4ea60d119996f37742542976fedcc8>>
 * @generated SignedSource<<1a08578b36cb91a183a435b881ca272f>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public interface ReactNativeFeatureFlagsProvider {

 @DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip public fun perfIssuesEnabled(): Boolean

 @DoNotStrip public fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip public fun preparedTextCacheSize(): Double
Expand Down

16 changes: 15 additions & 1 deletion
...ative/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<d04720bbbd42eaf338be612a0f3e36a6>>
 * @generated SignedSource<<4c22217e5a773fd97f4041ef6e052ebc>>
 */

/**
Expand DownExpand Up@@ -381,6 +381,12 @@ class ReactNativeFeatureFlagsJavaProvider
 return method(javaProvider_);
 }

 bool perfIssuesEnabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
 return method(javaProvider_);
 }

 bool perfMonitorV2Enabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfMonitorV2Enabled");
Expand DownExpand Up@@ -814,6 +820,11 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
 return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
}

bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfIssuesEnabled();
}

bool JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfMonitorV2Enabled();
Expand DownExpand Up@@ -1136,6 +1147,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
 makeNativeMethod(
 "overrideBySynchronousMountPropsAtMountingAndroid",
 JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
 makeNativeMethod(
 "perfIssuesEnabled",
 JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),
 makeNativeMethod(
 "perfMonitorV2Enabled",
 JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled),
Expand Down

5 changes: 4 additions & 1 deletion
...-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<7679a91daba1f8941b78a4be4baea6ef>>
 * @generated SignedSource<<91f5bbbab5f34321687c6f6d31ca49d8>>
 */

/**
Expand DownExpand Up@@ -201,6 +201,9 @@ class JReactNativeFeatureFlagsCxxInterop
 static bool overrideBySynchronousMountPropsAtMountingAndroid(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

Expand Down

6 changes: 5 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<303e8208cbdf0b9b9041942822c5597d>>
 * @generated SignedSource<<91ecd61e5e2ed1a15248db4e40993018>>
 */

/**
Expand DownExpand Up@@ -254,6 +254,10 @@ bool ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid()
 return getAccessor().overrideBySynchronousMountPropsAtMountingAndroid();
}

bool ReactNativeFeatureFlags::perfIssuesEnabled() {
 return getAccessor().perfIssuesEnabled();
}

bool ReactNativeFeatureFlags::perfMonitorV2Enabled() {
 return getAccessor().perfMonitorV2Enabled();
}
Expand Down

7 changes: 6 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<07b665ad842faafaf7520051f636d805>>
 * @generated SignedSource<<e996f8acef4c9feeda40ea920a2e5353>>
 */

/**
Expand DownExpand Up@@ -324,6 +324,11 @@ class ReactNativeFeatureFlags {
 */
 RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 RN_EXPORT static bool perfIssuesEnabled();

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add Performance Issues to Perf Monitor (1/2)#54265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add Performance Issues to Perf Monitor (1/2)
#54265
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<3ea1ee77358d99334a7c40bed44f2d90>>
 * @generated SignedSource<<bac9e360daa589cba476d208f75ef2ca>>
 */

/**
Expand DownExpand Up@@ -372,6 +372,12 @@ public object ReactNativeFeatureFlags {
 @JvmStatic
 public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 @JvmStatic
 public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down

12 changes: 11 additions & 1 deletion
.../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<007a5a1235a999716b382ffd4ca23158>>
 * @generated SignedSource<<2003ae7fc2c782b997d21938cc7b2380>>
 */

/**
Expand DownExpand Up@@ -77,6 +77,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -615,6 +616,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = ReactNativeFeatureFlagsCxxInterop.perfIssuesEnabled()
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<8a775646d455cdb6d017fd08aee3e807>>
 * @generated SignedSource<<986b35ba4f323ab1a65dd70a559889e9>>
 */

/**
Expand DownExpand Up@@ -142,6 +142,8 @@ public object ReactNativeFeatureFlagsCxxInterop {

 @DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean

 @DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip @JvmStatic public external fun preparedTextCacheSize(): Double
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<afccaed3066598724041c48bfb524234>>
 * @generated SignedSource<<43f629e3be734826b241d7e596daf6f4>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

 override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false

 override fun perfIssuesEnabled(): Boolean = false

 override fun perfMonitorV2Enabled(): Boolean = false

 override fun preparedTextCacheSize(): Double = 200.0
Expand Down

13 changes: 12 additions & 1 deletion
...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<ebeb9b37b8d3d0e31f4d4966cbf42b3f>>
 * @generated SignedSource<<806741418f4ff7e3b6dcac3d78fa27dd>>
 */

/**
Expand DownExpand Up@@ -81,6 +81,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
 private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
 private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
 private var perfIssuesEnabledCache: Boolean? = null
 private var perfMonitorV2EnabledCache: Boolean? = null
 private var preparedTextCacheSizeCache: Double? = null
 private var preventShadowTreeCommitExhaustionCache: Boolean? = null
Expand DownExpand Up@@ -676,6 +677,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
 return cached
 }

 override fun perfIssuesEnabled(): Boolean {
 var cached = perfIssuesEnabledCache
 if (cached == null) {
 cached = currentProvider.perfIssuesEnabled()
 accessedFeatureFlags.add("perfIssuesEnabled")
 perfIssuesEnabledCache = cached
 }
 return cached
 }

 override fun perfMonitorV2Enabled(): Boolean {
 var cached = perfMonitorV2EnabledCache
 if (cached == null) {
Expand Down

4 changes: 3 additions & 1 deletion
...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<1c4ea60d119996f37742542976fedcc8>>
 * @generated SignedSource<<1a08578b36cb91a183a435b881ca272f>>
 */

/**
Expand DownExpand Up@@ -137,6 +137,8 @@ public interface ReactNativeFeatureFlagsProvider {

 @DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean

 @DoNotStrip public fun perfIssuesEnabled(): Boolean

 @DoNotStrip public fun perfMonitorV2Enabled(): Boolean

 @DoNotStrip public fun preparedTextCacheSize(): Double
Expand Down

16 changes: 15 additions & 1 deletion
...ative/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<d04720bbbd42eaf338be612a0f3e36a6>>
 * @generated SignedSource<<4c22217e5a773fd97f4041ef6e052ebc>>
 */

/**
Expand DownExpand Up@@ -381,6 +381,12 @@ class ReactNativeFeatureFlagsJavaProvider
 return method(javaProvider_);
 }

 bool perfIssuesEnabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
 return method(javaProvider_);
 }

 bool perfMonitorV2Enabled() override {
 static const auto method =
 getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfMonitorV2Enabled");
Expand DownExpand Up@@ -814,6 +820,11 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
 return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
}

bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfIssuesEnabled();
}

bool JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
 return ReactNativeFeatureFlags::perfMonitorV2Enabled();
Expand DownExpand Up@@ -1136,6 +1147,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
 makeNativeMethod(
 "overrideBySynchronousMountPropsAtMountingAndroid",
 JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
 makeNativeMethod(
 "perfIssuesEnabled",
 JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),
 makeNativeMethod(
 "perfMonitorV2Enabled",
 JReactNativeFeatureFlagsCxxInterop::perfMonitorV2Enabled),
Expand Down

5 changes: 4 additions & 1 deletion
...-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<7679a91daba1f8941b78a4be4baea6ef>>
 * @generated SignedSource<<91f5bbbab5f34321687c6f6d31ca49d8>>
 */

/**
Expand DownExpand Up@@ -201,6 +201,9 @@ class JReactNativeFeatureFlagsCxxInterop
 static bool overrideBySynchronousMountPropsAtMountingAndroid(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfIssuesEnabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

 static bool perfMonitorV2Enabled(
 facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

Expand Down

6 changes: 5 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<303e8208cbdf0b9b9041942822c5597d>>
 * @generated SignedSource<<91ecd61e5e2ed1a15248db4e40993018>>
 */

/**
Expand DownExpand Up@@ -254,6 +254,10 @@ bool ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid()
 return getAccessor().overrideBySynchronousMountPropsAtMountingAndroid();
}

bool ReactNativeFeatureFlags::perfIssuesEnabled() {
 return getAccessor().perfIssuesEnabled();
}

bool ReactNativeFeatureFlags::perfMonitorV2Enabled() {
 return getAccessor().perfMonitorV2Enabled();
}
Expand Down

7 changes: 6 additions & 1 deletion
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @generated SignedSource<<07b665ad842faafaf7520051f636d805>>
 * @generated SignedSource<<e996f8acef4c9feeda40ea920a2e5353>>
 */

/**
Expand DownExpand Up@@ -324,6 +324,11 @@ class ReactNativeFeatureFlags {
 */
 RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();

 /**
 * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
 */
 RN_EXPORT static bool perfIssuesEnabled();

 /**
 * Enable the V2 in-app Performance Monitor. This flag is global and should not be changed across React Host lifetimes.
 */
Expand Down
Loading
Loading