Uh oh!
There was an error while loading. Please reload this page.
Enable hermesV1Enabled=true by default on Android - #55040
Closed
cortinico wants to merge 3 commits into
Closed
Conversation
huntie
approved these changes
Jan 5, 2026
Job Summary for GradleTest All :: run_fantom_tests
|
cipolleschi
commented
Jan 5, 2026
Contributor
is this automatically download the right version of Hermes? because I think you also need the changes I have on #54989 where we update the version.properties file |
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D90129971. |
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
cortinico
commented
Jan 7, 2026
ContributorAuthor
Closing as this has been picked inside: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enables the
hermesV1Enabledflag by default for Android.Users will still be able to turn off the flag if they wish to revert to legacy Hermes.
Changelog:
[ANDROID] [CHANGED] - Enable
hermesV1Enabledby default on Android, which turns on Hermes V1 (Static Hermes) by defaultTest Plan:
CI