Uh oh!
There was an error while loading. Please reload this page.
Improve react-native-xcode.sh integration - #5518
Closed
frantic wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Jan 24, 2016
Contributor
By analyzing the blame information on this pull request, we identified @frantic, @hkjorgensen and @foghina to be potential reviewers. |
franticforce-pushed
the
fix-react-native-xcode
branch
from
January 24, 2016 21:16
045b574 to
08886b4Comparefacebook-github-bot
commented
Jan 24, 2016
Contributor
@frantic updated the pull request. |
This was referenced Jan 24, 2016
frantic
commented
Jan 25, 2016
ContributorAuthor
franticforce-pushed
the
fix-react-native-xcode
branch
from
January 25, 2016 01:08
08886b4 to
2d24dacComparefacebook-github-bot
commented
Jan 25, 2016
Contributor
@frantic updated the pull request. |
10 tasks
mkonicek
commented
Jan 25, 2016
Contributor
Thanks so much! Don't have all the context but lgtm. Could this issue be related somehow? #5523 |
mkonicek
commented
Jan 25, 2016
Contributor
The error message is awesome! Great the path is configurable now, too! |
mkonicek
commented
Jan 25, 2016
Contributor
Feel free to shipit :) |
bestander
commented
Jan 25, 2016
Contributor
|
hkjorgensen
commented
Jan 25, 2016
Contributor
LGTM 👍 |
frantic
commented
Jan 25, 2016
ContributorAuthor
@facebook-github-bot shipit |
facebook-github-bot
commented
Jan 25, 2016
Contributor
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/430209143850810/int_phab to review. |
mkonicek pushed a commit
that referenced
this pull request
Jan 29, 2016
Summary: Inspired by conversation in #5374, this PR improves `react-native-xcode.sh`: * No longer depends on global `react-native` binary * Gracefully handles missing `node` dependency and adds a new way to configure the path to `node` in non-standard installation environments This is how the error looks like:  Closes#5518 Reviewed By: svcscm Differential Revision: D2861116 Pulled By: frantic fb-gh-sync-id: 9a80eda6c844d066e34369b1cda503955171485b
cpojer pushed a commit
to react/metro
that referenced
this pull request
Jan 26, 2017
Summary: Inspired by conversation in react/react-native#5374, this PR improves `react-native-xcode.sh`: * No longer depends on global `react-native` binary * Gracefully handles missing `node` dependency and adds a new way to configure the path to `node` in non-standard installation environments This is how the error looks like:  Closesreact/react-native#5518 Reviewed By: svcscm Differential Revision: D2861116 Pulled By: frantic fb-gh-sync-id: 9a80eda6c844d066e34369b1cda503955171485b
grabbou pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Inspired by conversation in react/react-native#5374, this PR improves `react-native-xcode.sh`: * No longer depends on global `react-native` binary * Gracefully handles missing `node` dependency and adds a new way to configure the path to `node` in non-standard installation environments This is how the error looks like:  Closesreact/react-native#5518 Reviewed By: svcscm Differential Revision: D2861116 Pulled By: frantic fb-gh-sync-id: 9a80eda6c844d066e34369b1cda503955171485b
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by conversation in #5374, this PR improves
react-native-xcode.sh:react-nativebinarynodedependency and adds a new way to configure the path tonodein non-standard installation environmentsThis is how the error looks like:
