Add UIManagerViewTransitionDelegate interface and View Transition APIs#55742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeyap wants to merge 1 commit into from
Closed

Add UIManagerViewTransitionDelegate interface and View Transition APIs #55742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -488,6 +488,10 @@ void UIManager::sendAccessibilityEvent(
}
}

UIManagerViewTransitionDelegate* UIManager::getViewTransitionDelegate() const {
return viewTransitionDelegate_;
}

void UIManager::configureNextLayoutAnimation(
jsi::Runtime& runtime,
const RawValue& config,
Expand DownExpand Up@@ -708,6 +712,13 @@ void UIManager::setNativeAnimatedDelegate(
nativeAnimatedDelegate_ = delegate;
}

void UIManager::setViewTransitionDelegate(
UIManagerViewTransitionDelegate* delegate) {
if (ReactNativeFeatureFlags::viewTransitionEnabled()) {
viewTransitionDelegate_ = delegate;
}
}

void UIManager::unstable_setAnimationBackend(
std::shared_ptr<UIManagerAnimationBackend> animationBackend) {
animationBackend_ = animationBackend;
Expand Down
8 changes: 8 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@
#include <react/renderer/uimanager/UIManagerAnimationDelegate.h>
#include <react/renderer/uimanager/UIManagerDelegate.h>
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
#include <react/renderer/uimanager/UIManagerViewTransitionDelegate.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/uimanager/consistency/ShadowTreeRevisionProvider.h>
#include <react/renderer/uimanager/primitives.h>
Expand DownExpand Up@@ -74,6 +75,12 @@ class UIManager final : public ShadowTreeDelegate {

void setNativeAnimatedDelegate(std::weak_ptr<UIManagerNativeAnimatedDelegate> delegate);

/**
* Sets and gets UIManager's ViewTransition API delegate.
*/
void setViewTransitionDelegate(UIManagerViewTransitionDelegate *delegate);
UIManagerViewTransitionDelegate *getViewTransitionDelegate() const;

void animationTick() const;

void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);
Expand DownExpand Up@@ -242,6 +249,7 @@ class UIManager final : public ShadowTreeDelegate {
UIManagerDelegate *delegate_{};
UIManagerAnimationDelegate *animationDelegate_{nullptr};
std::weak_ptr<UIManagerNativeAnimatedDelegate> nativeAnimatedDelegate_;
UIManagerViewTransitionDelegate *viewTransitionDelegate_{nullptr};

const RuntimeExecutor runtimeExecutor_{};
ShadowTreeRegistry shadowTreeRegistry_{};
Expand Down
259 changes: 259 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -876,6 +876,265 @@ jsi::Value UIManagerBinding::get(
});
}

if (methodName == "measureInstance") {
auto paramCount = 1;
return jsi::Function::createFromHostFunction(
runtime,
name,
paramCount,
[uiManager, methodName, paramCount](
jsi::Runtime& runtime,
const jsi::Value& /*thisValue*/,
const jsi::Value* arguments,
size_t count) -> jsi::Value {
validateArgumentCount(runtime, methodName, paramCount, count);

if (!arguments[0].isObject()) {
auto result = jsi::Object(runtime);
result.setProperty(runtime, "x", 0);
result.setProperty(runtime, "y", 0);
result.setProperty(runtime, "width", 0);
result.setProperty(runtime, "height", 0);
return result;
}

auto shadowNode = Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
runtime, arguments[0]);

auto currentRevision =
uiManager->getShadowTreeRevisionProvider()->getCurrentRevision(
shadowNode->getSurfaceId());

if (currentRevision == nullptr) {
auto result = jsi::Object(runtime);
result.setProperty(runtime, "x", 0);
result.setProperty(runtime, "y", 0);
result.setProperty(runtime, "width", 0);
result.setProperty(runtime, "height", 0);
return result;
}

auto domRect = dom::getBoundingClientRect(
currentRevision, *shadowNode, true /* includeTransform */);

auto result = jsi::Object(runtime);
result.setProperty(runtime, "x", domRect.x);
result.setProperty(runtime, "y", domRect.y);
result.setProperty(runtime, "width", domRect.width);
result.setProperty(runtime, "height", domRect.height);

auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
if (viewTransitionDelegate != nullptr) {
viewTransitionDelegate->captureLayoutMetricsFromRoot(shadowNode);
}

return result;
});
}

if (methodName == "applyViewTransitionName") {
auto paramCount = 3;
return jsi::Function::createFromHostFunction(
runtime,
name,
paramCount,
[uiManager, methodName, paramCount](
jsi::Runtime& runtime,
const jsi::Value& /*thisValue*/,
const jsi::Value* arguments,
size_t count) -> jsi::Value {
validateArgumentCount(runtime, methodName, paramCount, count);

if (arguments[0].isObject()) {
auto shadowNode =
Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
runtime, arguments[0]);
auto transitionName = arguments[1].isString()
? stringFromValue(runtime, arguments[1])
: "";
auto className = arguments[2].isString()
? stringFromValue(runtime, arguments[2])
: "";
if (!transitionName.empty()) {
auto* viewTransitionDelegate =
uiManager->getViewTransitionDelegate();
if (viewTransitionDelegate != nullptr) {
viewTransitionDelegate->applyViewTransitionName(
shadowNode, transitionName, className);
}
}
}

return jsi::Value::undefined();
});
}

if (methodName == "cancelViewTransitionName") {
auto paramCount = 2;
return jsi::Function::createFromHostFunction(
runtime,
name,
paramCount,
[uiManager, methodName, paramCount](
jsi::Runtime& runtime,
const jsi::Value& /*thisValue*/,
const jsi::Value* arguments,
size_t count) -> jsi::Value {
validateArgumentCount(runtime, methodName, paramCount, count);

if (arguments[0].isObject()) {
auto shadowNode =
Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
runtime, arguments[0]);
auto transitionName = arguments[1].isString()
? stringFromValue(runtime, arguments[1])
: "";
if (!transitionName.empty()) {
auto* viewTransitionDelegate =
uiManager->getViewTransitionDelegate();
if (viewTransitionDelegate != nullptr) {
viewTransitionDelegate->cancelViewTransitionName(
shadowNode, transitionName);
}
}
}

return jsi::Value::undefined();
});
}

if (methodName == "restoreViewTransitionName") {
auto paramCount = 1;
return jsi::Function::createFromHostFunction(
runtime,
name,
paramCount,
[uiManager, methodName, paramCount](
jsi::Runtime& runtime,
const jsi::Value& /*thisValue*/,
const jsi::Value* arguments,
size_t count) -> jsi::Value {
validateArgumentCount(runtime, methodName, paramCount, count);

if (arguments[0].isObject()) {
auto shadowNode =
Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
runtime, arguments[0]);
auto* viewTransitionDelegate =
uiManager->getViewTransitionDelegate();
if (viewTransitionDelegate != nullptr) {
viewTransitionDelegate->restoreViewTransitionName(shadowNode);
}
}

return jsi::Value::undefined();
});
}

if (methodName == "startViewTransition") {
auto paramCount = 1;
return jsi::Function::createFromHostFunction(
runtime,
name,
paramCount,
[uiManager, methodName, paramCount](
jsi::Runtime& runtime,
const jsi::Value& /*thisValue*/,
const jsi::Value* arguments,
size_t count) -> jsi::Value {
validateArgumentCount(runtime, methodName, paramCount, count);

auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
if (viewTransitionDelegate == nullptr) {
return jsi::Value::undefined();
}

auto promiseConstructor =
runtime.global().getPropertyAsFunction(runtime, "Promise");

auto readyResolveFunc =
std::make_shared<std::shared_ptr<jsi::Function>>();
auto finishedResolveFunc =
std::make_shared<std::shared_ptr<jsi::Function>>();

auto mutationFunc = std::make_shared<jsi::Function>(
arguments[0].asObject(runtime).asFunction(runtime));

auto readyPromise = promiseConstructor.callAsConstructor(
runtime,
jsi::Function::createFromHostFunction(
runtime,
jsi::PropNameID::forAscii(runtime, "readyExecutor"),
2,
[readyResolveFunc](
jsi::Runtime& runtime,
const jsi::Value& /*thisValue*/,
const jsi::Value* args,
size_t /*count*/) -> jsi::Value {
auto onReadyFunc = std::make_shared<jsi::Function>(
args[0].asObject(runtime).asFunction(runtime));
*readyResolveFunc = onReadyFunc;
return jsi::Value::undefined();
}));

auto finishedPromise = promiseConstructor.callAsConstructor(
runtime,
jsi::Function::createFromHostFunction(
runtime,
jsi::PropNameID::forAscii(runtime, "finishedExecutor"),
2,
[finishedResolveFunc, viewTransitionDelegate](
jsi::Runtime& rt,
const jsi::Value& /*thisValue*/,
const jsi::Value* args,
size_t /*count*/) -> jsi::Value {
auto onCompleteFunc = std::make_shared<jsi::Function>(
args[0].asObject(rt).asFunction(rt));
*finishedResolveFunc = std::make_shared<jsi::Function>(
jsi::Function::createFromHostFunction(
rt,
jsi::PropNameID::forAscii(rt, "finishedResolve"),
0,
[onCompleteFunc, viewTransitionDelegate](
jsi::Runtime& runtime,
const jsi::Value& /*thisValue*/,
const jsi::Value* /*args*/,
size_t /*count*/) -> jsi::Value {
onCompleteFunc->call(runtime);
viewTransitionDelegate->startViewTransitionEnd();
return jsi::Value::undefined();
}));
return jsi::Value::undefined();
}));

auto result = jsi::Object(runtime);
result.setProperty(runtime, "ready", std::move(readyPromise));
result.setProperty(runtime, "finished", std::move(finishedPromise));

viewTransitionDelegate->startViewTransition(
[&runtime, mutationFunc = std::move(mutationFunc)]() {
mutationFunc->call(runtime);
},
[readyResolveFunc = std::move(readyResolveFunc), &runtime]() {
if (*readyResolveFunc) {
(*readyResolveFunc)->call(runtime);
}
},
[finishedResolveFunc = std::move(finishedResolveFunc),
uiManager]() {
uiManager->runtimeExecutor_(
[finishedResolveFunc = std::move(finishedResolveFunc)](
jsi::Runtime& rt) mutable {
if (*finishedResolveFunc) {
(*finishedResolveFunc)->call(rt);
}
});
});

return jsi::Value(runtime, result);
});
}

return jsi::Value::undefined();
}

Expand Down
42 changes: 42 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

#pragma once

#include <react/renderer/core/ShadowNode.h>
#include <functional>

namespace facebook::react {

class UIManagerViewTransitionDelegate {
public:
virtual ~UIManagerViewTransitionDelegate() = default;

virtual void applyViewTransitionName(
const std::shared_ptr<const ShadowNode> &shadowNode,
const std::string &name,
const std::string &className)
{
}

virtual void cancelViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode, const std::string &name) {}

virtual void restoreViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode) {}

virtual void captureLayoutMetricsFromRoot(const std::shared_ptr<const ShadowNode> &shadowNode) {}

virtual void startViewTransition(
std::function<void()> mutationCallback,
std::function<void()> onReadyCallback,
std::function<void()> onCompleteCallback)
{
}

virtual void startViewTransitionEnd() {}
};

} // namespace facebook::react
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add UIManagerViewTransitionDelegate interface and View Transition APIs#55742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

zeyap
wants to merge
1
commit into

from

 Closed


Add UIManagerViewTransitionDelegate interface and View Transition APIs
#55742
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 11 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -488,6 +488,10 @@ void UIManager::sendAccessibilityEvent(
 }
}

UIManagerViewTransitionDelegate* UIManager::getViewTransitionDelegate() const {
 return viewTransitionDelegate_;
}

void UIManager::configureNextLayoutAnimation(
 jsi::Runtime& runtime,
 const RawValue& config,
Expand DownExpand Up@@ -708,6 +712,13 @@ void UIManager::setNativeAnimatedDelegate(
 nativeAnimatedDelegate_ = delegate;
}

void UIManager::setViewTransitionDelegate(
 UIManagerViewTransitionDelegate* delegate) {
 if (ReactNativeFeatureFlags::viewTransitionEnabled()) {
 viewTransitionDelegate_ = delegate;
 }
}

void UIManager::unstable_setAnimationBackend(
 std::shared_ptr<UIManagerAnimationBackend> animationBackend) {
 animationBackend_ = animationBackend;
Expand Down

8 changes: 8 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@
#include <react/renderer/uimanager/UIManagerAnimationDelegate.h>
#include <react/renderer/uimanager/UIManagerDelegate.h>
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
#include <react/renderer/uimanager/UIManagerViewTransitionDelegate.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/uimanager/consistency/ShadowTreeRevisionProvider.h>
#include <react/renderer/uimanager/primitives.h>
Expand DownExpand Up@@ -74,6 +75,12 @@ class UIManager final : public ShadowTreeDelegate {

 void setNativeAnimatedDelegate(std::weak_ptr<UIManagerNativeAnimatedDelegate> delegate);

 /**
 * Sets and gets UIManager's ViewTransition API delegate.
 */
 void setViewTransitionDelegate(UIManagerViewTransitionDelegate *delegate);
 UIManagerViewTransitionDelegate *getViewTransitionDelegate() const;

 void animationTick() const;

 void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);
Expand DownExpand Up@@ -242,6 +249,7 @@ class UIManager final : public ShadowTreeDelegate {
 UIManagerDelegate *delegate_{};
 UIManagerAnimationDelegate *animationDelegate_{nullptr};
 std::weak_ptr<UIManagerNativeAnimatedDelegate> nativeAnimatedDelegate_;
 UIManagerViewTransitionDelegate *viewTransitionDelegate_{nullptr};

 const RuntimeExecutor runtimeExecutor_{};
 ShadowTreeRegistry shadowTreeRegistry_{};
Expand Down

259 changes: 259 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -876,6 +876,265 @@ jsi::Value UIManagerBinding::get(
 });
 }

 if (methodName == "measureInstance") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (!arguments[0].isObject()) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto shadowNode = Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);

 auto currentRevision =
 uiManager->getShadowTreeRevisionProvider()->getCurrentRevision(
 shadowNode->getSurfaceId());

 if (currentRevision == nullptr) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto domRect = dom::getBoundingClientRect(
 currentRevision, *shadowNode, true /* includeTransform */);

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", domRect.x);
 result.setProperty(runtime, "y", domRect.y);
 result.setProperty(runtime, "width", domRect.width);
 result.setProperty(runtime, "height", domRect.height);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->captureLayoutMetricsFromRoot(shadowNode);
 }

 return result;
 });
 }

 if (methodName == "applyViewTransitionName") {
 auto paramCount = 3;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 auto className = arguments[2].isString()
 ? stringFromValue(runtime, arguments[2])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->applyViewTransitionName(
 shadowNode, transitionName, className);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "cancelViewTransitionName") {
 auto paramCount = 2;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->cancelViewTransitionName(
 shadowNode, transitionName);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "restoreViewTransitionName") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->restoreViewTransitionName(shadowNode);
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "startViewTransition") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate == nullptr) {
 return jsi::Value::undefined();
 }

 auto promiseConstructor =
 runtime.global().getPropertyAsFunction(runtime, "Promise");

 auto readyResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();
 auto finishedResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();

 auto mutationFunc = std::make_shared<jsi::Function>(
 arguments[0].asObject(runtime).asFunction(runtime));

 auto readyPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "readyExecutor"),
 2,
 [readyResolveFunc](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onReadyFunc = std::make_shared<jsi::Function>(
 args[0].asObject(runtime).asFunction(runtime));
 *readyResolveFunc = onReadyFunc;
 return jsi::Value::undefined();
 }));

 auto finishedPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "finishedExecutor"),
 2,
 [finishedResolveFunc, viewTransitionDelegate](
 jsi::Runtime& rt,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onCompleteFunc = std::make_shared<jsi::Function>(
 args[0].asObject(rt).asFunction(rt));
 *finishedResolveFunc = std::make_shared<jsi::Function>(
 jsi::Function::createFromHostFunction(
 rt,
 jsi::PropNameID::forAscii(rt, "finishedResolve"),
 0,
 [onCompleteFunc, viewTransitionDelegate](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* /*args*/,
 size_t /*count*/) -> jsi::Value {
 onCompleteFunc->call(runtime);
 viewTransitionDelegate->startViewTransitionEnd();
 return jsi::Value::undefined();
 }));
 return jsi::Value::undefined();
 }));

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "ready", std::move(readyPromise));
 result.setProperty(runtime, "finished", std::move(finishedPromise));

 viewTransitionDelegate->startViewTransition(
 [&runtime, mutationFunc = std::move(mutationFunc)]() {
 mutationFunc->call(runtime);
 },
 [readyResolveFunc = std::move(readyResolveFunc), &runtime]() {
 if (*readyResolveFunc) {
 (*readyResolveFunc)->call(runtime);
 }
 },
 [finishedResolveFunc = std::move(finishedResolveFunc),
 uiManager]() {
 uiManager->runtimeExecutor_(
 [finishedResolveFunc = std::move(finishedResolveFunc)](
 jsi::Runtime& rt) mutable {
 if (*finishedResolveFunc) {
 (*finishedResolveFunc)->call(rt);
 }
 });
 });

 return jsi::Value(runtime, result);
 });
 }

 return jsi::Value::undefined();
}

Expand Down

42 changes: 42 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
/*
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

#pragma once

#include <react/renderer/core/ShadowNode.h>
#include <functional>

namespace facebook::react {

class UIManagerViewTransitionDelegate {
 public:
 virtual ~UIManagerViewTransitionDelegate() = default;

 virtual void applyViewTransitionName(
 const std::shared_ptr<const ShadowNode> &shadowNode,
 const std::string &name,
 const std::string &className)
 {
 }

 virtual void cancelViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode, const std::string &name) {}

 virtual void restoreViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void captureLayoutMetricsFromRoot(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void startViewTransition(
 std::function<void()> mutationCallback,
 std::function<void()> onReadyCallback,
 std::function<void()> onCompleteCallback)
 {
 }

 virtual void startViewTransitionEnd() {}
};

} // namespace facebook::react
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add UIManagerViewTransitionDelegate interface and View Transition APIs#55742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

zeyap
wants to merge
1
commit into

from

 Closed


Add UIManagerViewTransitionDelegate interface and View Transition APIs
#55742
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 11 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -488,6 +488,10 @@ void UIManager::sendAccessibilityEvent(
 }
}

UIManagerViewTransitionDelegate* UIManager::getViewTransitionDelegate() const {
 return viewTransitionDelegate_;
}

void UIManager::configureNextLayoutAnimation(
 jsi::Runtime& runtime,
 const RawValue& config,
Expand DownExpand Up@@ -708,6 +712,13 @@ void UIManager::setNativeAnimatedDelegate(
 nativeAnimatedDelegate_ = delegate;
}

void UIManager::setViewTransitionDelegate(
 UIManagerViewTransitionDelegate* delegate) {
 if (ReactNativeFeatureFlags::viewTransitionEnabled()) {
 viewTransitionDelegate_ = delegate;
 }
}

void UIManager::unstable_setAnimationBackend(
 std::shared_ptr<UIManagerAnimationBackend> animationBackend) {
 animationBackend_ = animationBackend;
Expand Down

8 changes: 8 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@
#include <react/renderer/uimanager/UIManagerAnimationDelegate.h>
#include <react/renderer/uimanager/UIManagerDelegate.h>
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
#include <react/renderer/uimanager/UIManagerViewTransitionDelegate.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/uimanager/consistency/ShadowTreeRevisionProvider.h>
#include <react/renderer/uimanager/primitives.h>
Expand DownExpand Up@@ -74,6 +75,12 @@ class UIManager final : public ShadowTreeDelegate {

 void setNativeAnimatedDelegate(std::weak_ptr<UIManagerNativeAnimatedDelegate> delegate);

 /**
 * Sets and gets UIManager's ViewTransition API delegate.
 */
 void setViewTransitionDelegate(UIManagerViewTransitionDelegate *delegate);
 UIManagerViewTransitionDelegate *getViewTransitionDelegate() const;

 void animationTick() const;

 void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);
Expand DownExpand Up@@ -242,6 +249,7 @@ class UIManager final : public ShadowTreeDelegate {
 UIManagerDelegate *delegate_{};
 UIManagerAnimationDelegate *animationDelegate_{nullptr};
 std::weak_ptr<UIManagerNativeAnimatedDelegate> nativeAnimatedDelegate_;
 UIManagerViewTransitionDelegate *viewTransitionDelegate_{nullptr};

 const RuntimeExecutor runtimeExecutor_{};
 ShadowTreeRegistry shadowTreeRegistry_{};
Expand Down

259 changes: 259 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -876,6 +876,265 @@ jsi::Value UIManagerBinding::get(
 });
 }

 if (methodName == "measureInstance") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (!arguments[0].isObject()) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto shadowNode = Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);

 auto currentRevision =
 uiManager->getShadowTreeRevisionProvider()->getCurrentRevision(
 shadowNode->getSurfaceId());

 if (currentRevision == nullptr) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto domRect = dom::getBoundingClientRect(
 currentRevision, *shadowNode, true /* includeTransform */);

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", domRect.x);
 result.setProperty(runtime, "y", domRect.y);
 result.setProperty(runtime, "width", domRect.width);
 result.setProperty(runtime, "height", domRect.height);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->captureLayoutMetricsFromRoot(shadowNode);
 }

 return result;
 });
 }

 if (methodName == "applyViewTransitionName") {
 auto paramCount = 3;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 auto className = arguments[2].isString()
 ? stringFromValue(runtime, arguments[2])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->applyViewTransitionName(
 shadowNode, transitionName, className);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "cancelViewTransitionName") {
 auto paramCount = 2;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->cancelViewTransitionName(
 shadowNode, transitionName);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "restoreViewTransitionName") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->restoreViewTransitionName(shadowNode);
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "startViewTransition") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate == nullptr) {
 return jsi::Value::undefined();
 }

 auto promiseConstructor =
 runtime.global().getPropertyAsFunction(runtime, "Promise");

 auto readyResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();
 auto finishedResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();

 auto mutationFunc = std::make_shared<jsi::Function>(
 arguments[0].asObject(runtime).asFunction(runtime));

 auto readyPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "readyExecutor"),
 2,
 [readyResolveFunc](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onReadyFunc = std::make_shared<jsi::Function>(
 args[0].asObject(runtime).asFunction(runtime));
 *readyResolveFunc = onReadyFunc;
 return jsi::Value::undefined();
 }));

 auto finishedPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "finishedExecutor"),
 2,
 [finishedResolveFunc, viewTransitionDelegate](
 jsi::Runtime& rt,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onCompleteFunc = std::make_shared<jsi::Function>(
 args[0].asObject(rt).asFunction(rt));
 *finishedResolveFunc = std::make_shared<jsi::Function>(
 jsi::Function::createFromHostFunction(
 rt,
 jsi::PropNameID::forAscii(rt, "finishedResolve"),
 0,
 [onCompleteFunc, viewTransitionDelegate](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* /*args*/,
 size_t /*count*/) -> jsi::Value {
 onCompleteFunc->call(runtime);
 viewTransitionDelegate->startViewTransitionEnd();
 return jsi::Value::undefined();
 }));
 return jsi::Value::undefined();
 }));

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "ready", std::move(readyPromise));
 result.setProperty(runtime, "finished", std::move(finishedPromise));

 viewTransitionDelegate->startViewTransition(
 [&runtime, mutationFunc = std::move(mutationFunc)]() {
 mutationFunc->call(runtime);
 },
 [readyResolveFunc = std::move(readyResolveFunc), &runtime]() {
 if (*readyResolveFunc) {
 (*readyResolveFunc)->call(runtime);
 }
 },
 [finishedResolveFunc = std::move(finishedResolveFunc),
 uiManager]() {
 uiManager->runtimeExecutor_(
 [finishedResolveFunc = std::move(finishedResolveFunc)](
 jsi::Runtime& rt) mutable {
 if (*finishedResolveFunc) {
 (*finishedResolveFunc)->call(rt);
 }
 });
 });

 return jsi::Value(runtime, result);
 });
 }

 return jsi::Value::undefined();
}

Expand Down

42 changes: 42 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
/*
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

#pragma once

#include <react/renderer/core/ShadowNode.h>
#include <functional>

namespace facebook::react {

class UIManagerViewTransitionDelegate {
 public:
 virtual ~UIManagerViewTransitionDelegate() = default;

 virtual void applyViewTransitionName(
 const std::shared_ptr<const ShadowNode> &shadowNode,
 const std::string &name,
 const std::string &className)
 {
 }

 virtual void cancelViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode, const std::string &name) {}

 virtual void restoreViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void captureLayoutMetricsFromRoot(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void startViewTransition(
 std::function<void()> mutationCallback,
 std::function<void()> onReadyCallback,
 std::function<void()> onCompleteCallback)
 {
 }

 virtual void startViewTransitionEnd() {}
};

} // namespace facebook::react
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add UIManagerViewTransitionDelegate interface and View Transition APIs#55742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

zeyap
wants to merge
1
commit into

from

 Closed


Add UIManagerViewTransitionDelegate interface and View Transition APIs
#55742
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 11 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -488,6 +488,10 @@ void UIManager::sendAccessibilityEvent(
 }
}

UIManagerViewTransitionDelegate* UIManager::getViewTransitionDelegate() const {
 return viewTransitionDelegate_;
}

void UIManager::configureNextLayoutAnimation(
 jsi::Runtime& runtime,
 const RawValue& config,
Expand DownExpand Up@@ -708,6 +712,13 @@ void UIManager::setNativeAnimatedDelegate(
 nativeAnimatedDelegate_ = delegate;
}

void UIManager::setViewTransitionDelegate(
 UIManagerViewTransitionDelegate* delegate) {
 if (ReactNativeFeatureFlags::viewTransitionEnabled()) {
 viewTransitionDelegate_ = delegate;
 }
}

void UIManager::unstable_setAnimationBackend(
 std::shared_ptr<UIManagerAnimationBackend> animationBackend) {
 animationBackend_ = animationBackend;
Expand Down

8 changes: 8 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@
#include <react/renderer/uimanager/UIManagerAnimationDelegate.h>
#include <react/renderer/uimanager/UIManagerDelegate.h>
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
#include <react/renderer/uimanager/UIManagerViewTransitionDelegate.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/uimanager/consistency/ShadowTreeRevisionProvider.h>
#include <react/renderer/uimanager/primitives.h>
Expand DownExpand Up@@ -74,6 +75,12 @@ class UIManager final : public ShadowTreeDelegate {

 void setNativeAnimatedDelegate(std::weak_ptr<UIManagerNativeAnimatedDelegate> delegate);

 /**
 * Sets and gets UIManager's ViewTransition API delegate.
 */
 void setViewTransitionDelegate(UIManagerViewTransitionDelegate *delegate);
 UIManagerViewTransitionDelegate *getViewTransitionDelegate() const;

 void animationTick() const;

 void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);
Expand DownExpand Up@@ -242,6 +249,7 @@ class UIManager final : public ShadowTreeDelegate {
 UIManagerDelegate *delegate_{};
 UIManagerAnimationDelegate *animationDelegate_{nullptr};
 std::weak_ptr<UIManagerNativeAnimatedDelegate> nativeAnimatedDelegate_;
 UIManagerViewTransitionDelegate *viewTransitionDelegate_{nullptr};

 const RuntimeExecutor runtimeExecutor_{};
 ShadowTreeRegistry shadowTreeRegistry_{};
Expand Down

259 changes: 259 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -876,6 +876,265 @@ jsi::Value UIManagerBinding::get(
 });
 }

 if (methodName == "measureInstance") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (!arguments[0].isObject()) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto shadowNode = Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);

 auto currentRevision =
 uiManager->getShadowTreeRevisionProvider()->getCurrentRevision(
 shadowNode->getSurfaceId());

 if (currentRevision == nullptr) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto domRect = dom::getBoundingClientRect(
 currentRevision, *shadowNode, true /* includeTransform */);

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", domRect.x);
 result.setProperty(runtime, "y", domRect.y);
 result.setProperty(runtime, "width", domRect.width);
 result.setProperty(runtime, "height", domRect.height);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->captureLayoutMetricsFromRoot(shadowNode);
 }

 return result;
 });
 }

 if (methodName == "applyViewTransitionName") {
 auto paramCount = 3;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 auto className = arguments[2].isString()
 ? stringFromValue(runtime, arguments[2])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->applyViewTransitionName(
 shadowNode, transitionName, className);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "cancelViewTransitionName") {
 auto paramCount = 2;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->cancelViewTransitionName(
 shadowNode, transitionName);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "restoreViewTransitionName") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->restoreViewTransitionName(shadowNode);
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "startViewTransition") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate == nullptr) {
 return jsi::Value::undefined();
 }

 auto promiseConstructor =
 runtime.global().getPropertyAsFunction(runtime, "Promise");

 auto readyResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();
 auto finishedResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();

 auto mutationFunc = std::make_shared<jsi::Function>(
 arguments[0].asObject(runtime).asFunction(runtime));

 auto readyPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "readyExecutor"),
 2,
 [readyResolveFunc](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onReadyFunc = std::make_shared<jsi::Function>(
 args[0].asObject(runtime).asFunction(runtime));
 *readyResolveFunc = onReadyFunc;
 return jsi::Value::undefined();
 }));

 auto finishedPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "finishedExecutor"),
 2,
 [finishedResolveFunc, viewTransitionDelegate](
 jsi::Runtime& rt,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onCompleteFunc = std::make_shared<jsi::Function>(
 args[0].asObject(rt).asFunction(rt));
 *finishedResolveFunc = std::make_shared<jsi::Function>(
 jsi::Function::createFromHostFunction(
 rt,
 jsi::PropNameID::forAscii(rt, "finishedResolve"),
 0,
 [onCompleteFunc, viewTransitionDelegate](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* /*args*/,
 size_t /*count*/) -> jsi::Value {
 onCompleteFunc->call(runtime);
 viewTransitionDelegate->startViewTransitionEnd();
 return jsi::Value::undefined();
 }));
 return jsi::Value::undefined();
 }));

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "ready", std::move(readyPromise));
 result.setProperty(runtime, "finished", std::move(finishedPromise));

 viewTransitionDelegate->startViewTransition(
 [&runtime, mutationFunc = std::move(mutationFunc)]() {
 mutationFunc->call(runtime);
 },
 [readyResolveFunc = std::move(readyResolveFunc), &runtime]() {
 if (*readyResolveFunc) {
 (*readyResolveFunc)->call(runtime);
 }
 },
 [finishedResolveFunc = std::move(finishedResolveFunc),
 uiManager]() {
 uiManager->runtimeExecutor_(
 [finishedResolveFunc = std::move(finishedResolveFunc)](
 jsi::Runtime& rt) mutable {
 if (*finishedResolveFunc) {
 (*finishedResolveFunc)->call(rt);
 }
 });
 });

 return jsi::Value(runtime, result);
 });
 }

 return jsi::Value::undefined();
}

Expand Down

42 changes: 42 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
/*
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

#pragma once

#include <react/renderer/core/ShadowNode.h>
#include <functional>

namespace facebook::react {

class UIManagerViewTransitionDelegate {
 public:
 virtual ~UIManagerViewTransitionDelegate() = default;

 virtual void applyViewTransitionName(
 const std::shared_ptr<const ShadowNode> &shadowNode,
 const std::string &name,
 const std::string &className)
 {
 }

 virtual void cancelViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode, const std::string &name) {}

 virtual void restoreViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void captureLayoutMetricsFromRoot(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void startViewTransition(
 std::function<void()> mutationCallback,
 std::function<void()> onReadyCallback,
 std::function<void()> onCompleteCallback)
 {
 }

 virtual void startViewTransitionEnd() {}
};

} // namespace facebook::react
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add UIManagerViewTransitionDelegate interface and View Transition APIs#55742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

zeyap
wants to merge
1
commit into

from

 Closed


Add UIManagerViewTransitionDelegate interface and View Transition APIs
#55742
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 11 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -488,6 +488,10 @@ void UIManager::sendAccessibilityEvent(
 }
}

UIManagerViewTransitionDelegate* UIManager::getViewTransitionDelegate() const {
 return viewTransitionDelegate_;
}

void UIManager::configureNextLayoutAnimation(
 jsi::Runtime& runtime,
 const RawValue& config,
Expand DownExpand Up@@ -708,6 +712,13 @@ void UIManager::setNativeAnimatedDelegate(
 nativeAnimatedDelegate_ = delegate;
}

void UIManager::setViewTransitionDelegate(
 UIManagerViewTransitionDelegate* delegate) {
 if (ReactNativeFeatureFlags::viewTransitionEnabled()) {
 viewTransitionDelegate_ = delegate;
 }
}

void UIManager::unstable_setAnimationBackend(
 std::shared_ptr<UIManagerAnimationBackend> animationBackend) {
 animationBackend_ = animationBackend;
Expand Down

8 changes: 8 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@
#include <react/renderer/uimanager/UIManagerAnimationDelegate.h>
#include <react/renderer/uimanager/UIManagerDelegate.h>
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
#include <react/renderer/uimanager/UIManagerViewTransitionDelegate.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/uimanager/consistency/ShadowTreeRevisionProvider.h>
#include <react/renderer/uimanager/primitives.h>
Expand DownExpand Up@@ -74,6 +75,12 @@ class UIManager final : public ShadowTreeDelegate {

 void setNativeAnimatedDelegate(std::weak_ptr<UIManagerNativeAnimatedDelegate> delegate);

 /**
 * Sets and gets UIManager's ViewTransition API delegate.
 */
 void setViewTransitionDelegate(UIManagerViewTransitionDelegate *delegate);
 UIManagerViewTransitionDelegate *getViewTransitionDelegate() const;

 void animationTick() const;

 void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);
Expand DownExpand Up@@ -242,6 +249,7 @@ class UIManager final : public ShadowTreeDelegate {
 UIManagerDelegate *delegate_{};
 UIManagerAnimationDelegate *animationDelegate_{nullptr};
 std::weak_ptr<UIManagerNativeAnimatedDelegate> nativeAnimatedDelegate_;
 UIManagerViewTransitionDelegate *viewTransitionDelegate_{nullptr};

 const RuntimeExecutor runtimeExecutor_{};
 ShadowTreeRegistry shadowTreeRegistry_{};
Expand Down

259 changes: 259 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -876,6 +876,265 @@ jsi::Value UIManagerBinding::get(
 });
 }

 if (methodName == "measureInstance") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (!arguments[0].isObject()) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto shadowNode = Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);

 auto currentRevision =
 uiManager->getShadowTreeRevisionProvider()->getCurrentRevision(
 shadowNode->getSurfaceId());

 if (currentRevision == nullptr) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto domRect = dom::getBoundingClientRect(
 currentRevision, *shadowNode, true /* includeTransform */);

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", domRect.x);
 result.setProperty(runtime, "y", domRect.y);
 result.setProperty(runtime, "width", domRect.width);
 result.setProperty(runtime, "height", domRect.height);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->captureLayoutMetricsFromRoot(shadowNode);
 }

 return result;
 });
 }

 if (methodName == "applyViewTransitionName") {
 auto paramCount = 3;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 auto className = arguments[2].isString()
 ? stringFromValue(runtime, arguments[2])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->applyViewTransitionName(
 shadowNode, transitionName, className);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "cancelViewTransitionName") {
 auto paramCount = 2;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->cancelViewTransitionName(
 shadowNode, transitionName);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "restoreViewTransitionName") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->restoreViewTransitionName(shadowNode);
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "startViewTransition") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate == nullptr) {
 return jsi::Value::undefined();
 }

 auto promiseConstructor =
 runtime.global().getPropertyAsFunction(runtime, "Promise");

 auto readyResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();
 auto finishedResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();

 auto mutationFunc = std::make_shared<jsi::Function>(
 arguments[0].asObject(runtime).asFunction(runtime));

 auto readyPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "readyExecutor"),
 2,
 [readyResolveFunc](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onReadyFunc = std::make_shared<jsi::Function>(
 args[0].asObject(runtime).asFunction(runtime));
 *readyResolveFunc = onReadyFunc;
 return jsi::Value::undefined();
 }));

 auto finishedPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "finishedExecutor"),
 2,
 [finishedResolveFunc, viewTransitionDelegate](
 jsi::Runtime& rt,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onCompleteFunc = std::make_shared<jsi::Function>(
 args[0].asObject(rt).asFunction(rt));
 *finishedResolveFunc = std::make_shared<jsi::Function>(
 jsi::Function::createFromHostFunction(
 rt,
 jsi::PropNameID::forAscii(rt, "finishedResolve"),
 0,
 [onCompleteFunc, viewTransitionDelegate](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* /*args*/,
 size_t /*count*/) -> jsi::Value {
 onCompleteFunc->call(runtime);
 viewTransitionDelegate->startViewTransitionEnd();
 return jsi::Value::undefined();
 }));
 return jsi::Value::undefined();
 }));

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "ready", std::move(readyPromise));
 result.setProperty(runtime, "finished", std::move(finishedPromise));

 viewTransitionDelegate->startViewTransition(
 [&runtime, mutationFunc = std::move(mutationFunc)]() {
 mutationFunc->call(runtime);
 },
 [readyResolveFunc = std::move(readyResolveFunc), &runtime]() {
 if (*readyResolveFunc) {
 (*readyResolveFunc)->call(runtime);
 }
 },
 [finishedResolveFunc = std::move(finishedResolveFunc),
 uiManager]() {
 uiManager->runtimeExecutor_(
 [finishedResolveFunc = std::move(finishedResolveFunc)](
 jsi::Runtime& rt) mutable {
 if (*finishedResolveFunc) {
 (*finishedResolveFunc)->call(rt);
 }
 });
 });

 return jsi::Value(runtime, result);
 });
 }

 return jsi::Value::undefined();
}

Expand Down

42 changes: 42 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
/*
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

#pragma once

#include <react/renderer/core/ShadowNode.h>
#include <functional>

namespace facebook::react {

class UIManagerViewTransitionDelegate {
 public:
 virtual ~UIManagerViewTransitionDelegate() = default;

 virtual void applyViewTransitionName(
 const std::shared_ptr<const ShadowNode> &shadowNode,
 const std::string &name,
 const std::string &className)
 {
 }

 virtual void cancelViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode, const std::string &name) {}

 virtual void restoreViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void captureLayoutMetricsFromRoot(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void startViewTransition(
 std::function<void()> mutationCallback,
 std::function<void()> onReadyCallback,
 std::function<void()> onCompleteCallback)
 {
 }

 virtual void startViewTransitionEnd() {}
};

} // namespace facebook::react
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add UIManagerViewTransitionDelegate interface and View Transition APIs#55742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

zeyap
wants to merge
1
commit into

from

 Closed


Add UIManagerViewTransitionDelegate interface and View Transition APIs
#55742
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 11 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -488,6 +488,10 @@ void UIManager::sendAccessibilityEvent(
 }
}

UIManagerViewTransitionDelegate* UIManager::getViewTransitionDelegate() const {
 return viewTransitionDelegate_;
}

void UIManager::configureNextLayoutAnimation(
 jsi::Runtime& runtime,
 const RawValue& config,
Expand DownExpand Up@@ -708,6 +712,13 @@ void UIManager::setNativeAnimatedDelegate(
 nativeAnimatedDelegate_ = delegate;
}

void UIManager::setViewTransitionDelegate(
 UIManagerViewTransitionDelegate* delegate) {
 if (ReactNativeFeatureFlags::viewTransitionEnabled()) {
 viewTransitionDelegate_ = delegate;
 }
}

void UIManager::unstable_setAnimationBackend(
 std::shared_ptr<UIManagerAnimationBackend> animationBackend) {
 animationBackend_ = animationBackend;
Expand Down

8 changes: 8 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@
#include <react/renderer/uimanager/UIManagerAnimationDelegate.h>
#include <react/renderer/uimanager/UIManagerDelegate.h>
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
#include <react/renderer/uimanager/UIManagerViewTransitionDelegate.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/uimanager/consistency/ShadowTreeRevisionProvider.h>
#include <react/renderer/uimanager/primitives.h>
Expand DownExpand Up@@ -74,6 +75,12 @@ class UIManager final : public ShadowTreeDelegate {

 void setNativeAnimatedDelegate(std::weak_ptr<UIManagerNativeAnimatedDelegate> delegate);

 /**
 * Sets and gets UIManager's ViewTransition API delegate.
 */
 void setViewTransitionDelegate(UIManagerViewTransitionDelegate *delegate);
 UIManagerViewTransitionDelegate *getViewTransitionDelegate() const;

 void animationTick() const;

 void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);
Expand DownExpand Up@@ -242,6 +249,7 @@ class UIManager final : public ShadowTreeDelegate {
 UIManagerDelegate *delegate_{};
 UIManagerAnimationDelegate *animationDelegate_{nullptr};
 std::weak_ptr<UIManagerNativeAnimatedDelegate> nativeAnimatedDelegate_;
 UIManagerViewTransitionDelegate *viewTransitionDelegate_{nullptr};

 const RuntimeExecutor runtimeExecutor_{};
 ShadowTreeRegistry shadowTreeRegistry_{};
Expand Down

259 changes: 259 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -876,6 +876,265 @@ jsi::Value UIManagerBinding::get(
 });
 }

 if (methodName == "measureInstance") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (!arguments[0].isObject()) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto shadowNode = Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);

 auto currentRevision =
 uiManager->getShadowTreeRevisionProvider()->getCurrentRevision(
 shadowNode->getSurfaceId());

 if (currentRevision == nullptr) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto domRect = dom::getBoundingClientRect(
 currentRevision, *shadowNode, true /* includeTransform */);

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", domRect.x);
 result.setProperty(runtime, "y", domRect.y);
 result.setProperty(runtime, "width", domRect.width);
 result.setProperty(runtime, "height", domRect.height);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->captureLayoutMetricsFromRoot(shadowNode);
 }

 return result;
 });
 }

 if (methodName == "applyViewTransitionName") {
 auto paramCount = 3;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 auto className = arguments[2].isString()
 ? stringFromValue(runtime, arguments[2])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->applyViewTransitionName(
 shadowNode, transitionName, className);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "cancelViewTransitionName") {
 auto paramCount = 2;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->cancelViewTransitionName(
 shadowNode, transitionName);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "restoreViewTransitionName") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->restoreViewTransitionName(shadowNode);
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "startViewTransition") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate == nullptr) {
 return jsi::Value::undefined();
 }

 auto promiseConstructor =
 runtime.global().getPropertyAsFunction(runtime, "Promise");

 auto readyResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();
 auto finishedResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();

 auto mutationFunc = std::make_shared<jsi::Function>(
 arguments[0].asObject(runtime).asFunction(runtime));

 auto readyPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "readyExecutor"),
 2,
 [readyResolveFunc](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onReadyFunc = std::make_shared<jsi::Function>(
 args[0].asObject(runtime).asFunction(runtime));
 *readyResolveFunc = onReadyFunc;
 return jsi::Value::undefined();
 }));

 auto finishedPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "finishedExecutor"),
 2,
 [finishedResolveFunc, viewTransitionDelegate](
 jsi::Runtime& rt,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onCompleteFunc = std::make_shared<jsi::Function>(
 args[0].asObject(rt).asFunction(rt));
 *finishedResolveFunc = std::make_shared<jsi::Function>(
 jsi::Function::createFromHostFunction(
 rt,
 jsi::PropNameID::forAscii(rt, "finishedResolve"),
 0,
 [onCompleteFunc, viewTransitionDelegate](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* /*args*/,
 size_t /*count*/) -> jsi::Value {
 onCompleteFunc->call(runtime);
 viewTransitionDelegate->startViewTransitionEnd();
 return jsi::Value::undefined();
 }));
 return jsi::Value::undefined();
 }));

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "ready", std::move(readyPromise));
 result.setProperty(runtime, "finished", std::move(finishedPromise));

 viewTransitionDelegate->startViewTransition(
 [&runtime, mutationFunc = std::move(mutationFunc)]() {
 mutationFunc->call(runtime);
 },
 [readyResolveFunc = std::move(readyResolveFunc), &runtime]() {
 if (*readyResolveFunc) {
 (*readyResolveFunc)->call(runtime);
 }
 },
 [finishedResolveFunc = std::move(finishedResolveFunc),
 uiManager]() {
 uiManager->runtimeExecutor_(
 [finishedResolveFunc = std::move(finishedResolveFunc)](
 jsi::Runtime& rt) mutable {
 if (*finishedResolveFunc) {
 (*finishedResolveFunc)->call(rt);
 }
 });
 });

 return jsi::Value(runtime, result);
 });
 }

 return jsi::Value::undefined();
}

Expand Down

42 changes: 42 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
/*
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

#pragma once

#include <react/renderer/core/ShadowNode.h>
#include <functional>

namespace facebook::react {

class UIManagerViewTransitionDelegate {
 public:
 virtual ~UIManagerViewTransitionDelegate() = default;

 virtual void applyViewTransitionName(
 const std::shared_ptr<const ShadowNode> &shadowNode,
 const std::string &name,
 const std::string &className)
 {
 }

 virtual void cancelViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode, const std::string &name) {}

 virtual void restoreViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void captureLayoutMetricsFromRoot(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void startViewTransition(
 std::function<void()> mutationCallback,
 std::function<void()> onReadyCallback,
 std::function<void()> onCompleteCallback)
 {
 }

 virtual void startViewTransitionEnd() {}
};

} // namespace facebook::react
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add UIManagerViewTransitionDelegate interface and View Transition APIs#55742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

zeyap
wants to merge
1
commit into

from

 Closed


Add UIManagerViewTransitionDelegate interface and View Transition APIs
#55742
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 11 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -488,6 +488,10 @@ void UIManager::sendAccessibilityEvent(
 }
}

UIManagerViewTransitionDelegate* UIManager::getViewTransitionDelegate() const {
 return viewTransitionDelegate_;
}

void UIManager::configureNextLayoutAnimation(
 jsi::Runtime& runtime,
 const RawValue& config,
Expand DownExpand Up@@ -708,6 +712,13 @@ void UIManager::setNativeAnimatedDelegate(
 nativeAnimatedDelegate_ = delegate;
}

void UIManager::setViewTransitionDelegate(
 UIManagerViewTransitionDelegate* delegate) {
 if (ReactNativeFeatureFlags::viewTransitionEnabled()) {
 viewTransitionDelegate_ = delegate;
 }
}

void UIManager::unstable_setAnimationBackend(
 std::shared_ptr<UIManagerAnimationBackend> animationBackend) {
 animationBackend_ = animationBackend;
Expand Down

8 changes: 8 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@
#include <react/renderer/uimanager/UIManagerAnimationDelegate.h>
#include <react/renderer/uimanager/UIManagerDelegate.h>
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
#include <react/renderer/uimanager/UIManagerViewTransitionDelegate.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/uimanager/consistency/ShadowTreeRevisionProvider.h>
#include <react/renderer/uimanager/primitives.h>
Expand DownExpand Up@@ -74,6 +75,12 @@ class UIManager final : public ShadowTreeDelegate {

 void setNativeAnimatedDelegate(std::weak_ptr<UIManagerNativeAnimatedDelegate> delegate);

 /**
 * Sets and gets UIManager's ViewTransition API delegate.
 */
 void setViewTransitionDelegate(UIManagerViewTransitionDelegate *delegate);
 UIManagerViewTransitionDelegate *getViewTransitionDelegate() const;

 void animationTick() const;

 void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);
Expand DownExpand Up@@ -242,6 +249,7 @@ class UIManager final : public ShadowTreeDelegate {
 UIManagerDelegate *delegate_{};
 UIManagerAnimationDelegate *animationDelegate_{nullptr};
 std::weak_ptr<UIManagerNativeAnimatedDelegate> nativeAnimatedDelegate_;
 UIManagerViewTransitionDelegate *viewTransitionDelegate_{nullptr};

 const RuntimeExecutor runtimeExecutor_{};
 ShadowTreeRegistry shadowTreeRegistry_{};
Expand Down

259 changes: 259 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -876,6 +876,265 @@ jsi::Value UIManagerBinding::get(
 });
 }

 if (methodName == "measureInstance") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (!arguments[0].isObject()) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto shadowNode = Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);

 auto currentRevision =
 uiManager->getShadowTreeRevisionProvider()->getCurrentRevision(
 shadowNode->getSurfaceId());

 if (currentRevision == nullptr) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto domRect = dom::getBoundingClientRect(
 currentRevision, *shadowNode, true /* includeTransform */);

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", domRect.x);
 result.setProperty(runtime, "y", domRect.y);
 result.setProperty(runtime, "width", domRect.width);
 result.setProperty(runtime, "height", domRect.height);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->captureLayoutMetricsFromRoot(shadowNode);
 }

 return result;
 });
 }

 if (methodName == "applyViewTransitionName") {
 auto paramCount = 3;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 auto className = arguments[2].isString()
 ? stringFromValue(runtime, arguments[2])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->applyViewTransitionName(
 shadowNode, transitionName, className);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "cancelViewTransitionName") {
 auto paramCount = 2;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->cancelViewTransitionName(
 shadowNode, transitionName);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "restoreViewTransitionName") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->restoreViewTransitionName(shadowNode);
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "startViewTransition") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate == nullptr) {
 return jsi::Value::undefined();
 }

 auto promiseConstructor =
 runtime.global().getPropertyAsFunction(runtime, "Promise");

 auto readyResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();
 auto finishedResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();

 auto mutationFunc = std::make_shared<jsi::Function>(
 arguments[0].asObject(runtime).asFunction(runtime));

 auto readyPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "readyExecutor"),
 2,
 [readyResolveFunc](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onReadyFunc = std::make_shared<jsi::Function>(
 args[0].asObject(runtime).asFunction(runtime));
 *readyResolveFunc = onReadyFunc;
 return jsi::Value::undefined();
 }));

 auto finishedPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "finishedExecutor"),
 2,
 [finishedResolveFunc, viewTransitionDelegate](
 jsi::Runtime& rt,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onCompleteFunc = std::make_shared<jsi::Function>(
 args[0].asObject(rt).asFunction(rt));
 *finishedResolveFunc = std::make_shared<jsi::Function>(
 jsi::Function::createFromHostFunction(
 rt,
 jsi::PropNameID::forAscii(rt, "finishedResolve"),
 0,
 [onCompleteFunc, viewTransitionDelegate](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* /*args*/,
 size_t /*count*/) -> jsi::Value {
 onCompleteFunc->call(runtime);
 viewTransitionDelegate->startViewTransitionEnd();
 return jsi::Value::undefined();
 }));
 return jsi::Value::undefined();
 }));

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "ready", std::move(readyPromise));
 result.setProperty(runtime, "finished", std::move(finishedPromise));

 viewTransitionDelegate->startViewTransition(
 [&runtime, mutationFunc = std::move(mutationFunc)]() {
 mutationFunc->call(runtime);
 },
 [readyResolveFunc = std::move(readyResolveFunc), &runtime]() {
 if (*readyResolveFunc) {
 (*readyResolveFunc)->call(runtime);
 }
 },
 [finishedResolveFunc = std::move(finishedResolveFunc),
 uiManager]() {
 uiManager->runtimeExecutor_(
 [finishedResolveFunc = std::move(finishedResolveFunc)](
 jsi::Runtime& rt) mutable {
 if (*finishedResolveFunc) {
 (*finishedResolveFunc)->call(rt);
 }
 });
 });

 return jsi::Value(runtime, result);
 });
 }

 return jsi::Value::undefined();
}

Expand Down

42 changes: 42 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
/*
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

#pragma once

#include <react/renderer/core/ShadowNode.h>
#include <functional>

namespace facebook::react {

class UIManagerViewTransitionDelegate {
 public:
 virtual ~UIManagerViewTransitionDelegate() = default;

 virtual void applyViewTransitionName(
 const std::shared_ptr<const ShadowNode> &shadowNode,
 const std::string &name,
 const std::string &className)
 {
 }

 virtual void cancelViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode, const std::string &name) {}

 virtual void restoreViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void captureLayoutMetricsFromRoot(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void startViewTransition(
 std::function<void()> mutationCallback,
 std::function<void()> onReadyCallback,
 std::function<void()> onCompleteCallback)
 {
 }

 virtual void startViewTransitionEnd() {}
};

} // namespace facebook::react
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add UIManagerViewTransitionDelegate interface and View Transition APIs#55742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

zeyap
wants to merge
1
commit into

from

 Closed


Add UIManagerViewTransitionDelegate interface and View Transition APIs
#55742
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 11 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -488,6 +488,10 @@ void UIManager::sendAccessibilityEvent(
 }
}

UIManagerViewTransitionDelegate* UIManager::getViewTransitionDelegate() const {
 return viewTransitionDelegate_;
}

void UIManager::configureNextLayoutAnimation(
 jsi::Runtime& runtime,
 const RawValue& config,
Expand DownExpand Up@@ -708,6 +712,13 @@ void UIManager::setNativeAnimatedDelegate(
 nativeAnimatedDelegate_ = delegate;
}

void UIManager::setViewTransitionDelegate(
 UIManagerViewTransitionDelegate* delegate) {
 if (ReactNativeFeatureFlags::viewTransitionEnabled()) {
 viewTransitionDelegate_ = delegate;
 }
}

void UIManager::unstable_setAnimationBackend(
 std::shared_ptr<UIManagerAnimationBackend> animationBackend) {
 animationBackend_ = animationBackend;
Expand Down

8 changes: 8 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@
#include <react/renderer/uimanager/UIManagerAnimationDelegate.h>
#include <react/renderer/uimanager/UIManagerDelegate.h>
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
#include <react/renderer/uimanager/UIManagerViewTransitionDelegate.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/uimanager/consistency/ShadowTreeRevisionProvider.h>
#include <react/renderer/uimanager/primitives.h>
Expand DownExpand Up@@ -74,6 +75,12 @@ class UIManager final : public ShadowTreeDelegate {

 void setNativeAnimatedDelegate(std::weak_ptr<UIManagerNativeAnimatedDelegate> delegate);

 /**
 * Sets and gets UIManager's ViewTransition API delegate.
 */
 void setViewTransitionDelegate(UIManagerViewTransitionDelegate *delegate);
 UIManagerViewTransitionDelegate *getViewTransitionDelegate() const;

 void animationTick() const;

 void synchronouslyUpdateViewOnUIThread(Tag tag, const folly::dynamic &props);
Expand DownExpand Up@@ -242,6 +249,7 @@ class UIManager final : public ShadowTreeDelegate {
 UIManagerDelegate *delegate_{};
 UIManagerAnimationDelegate *animationDelegate_{nullptr};
 std::weak_ptr<UIManagerNativeAnimatedDelegate> nativeAnimatedDelegate_;
 UIManagerViewTransitionDelegate *viewTransitionDelegate_{nullptr};

 const RuntimeExecutor runtimeExecutor_{};
 ShadowTreeRegistry shadowTreeRegistry_{};
Expand Down

259 changes: 259 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -876,6 +876,265 @@ jsi::Value UIManagerBinding::get(
 });
 }

 if (methodName == "measureInstance") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (!arguments[0].isObject()) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto shadowNode = Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);

 auto currentRevision =
 uiManager->getShadowTreeRevisionProvider()->getCurrentRevision(
 shadowNode->getSurfaceId());

 if (currentRevision == nullptr) {
 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", 0);
 result.setProperty(runtime, "y", 0);
 result.setProperty(runtime, "width", 0);
 result.setProperty(runtime, "height", 0);
 return result;
 }

 auto domRect = dom::getBoundingClientRect(
 currentRevision, *shadowNode, true /* includeTransform */);

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "x", domRect.x);
 result.setProperty(runtime, "y", domRect.y);
 result.setProperty(runtime, "width", domRect.width);
 result.setProperty(runtime, "height", domRect.height);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->captureLayoutMetricsFromRoot(shadowNode);
 }

 return result;
 });
 }

 if (methodName == "applyViewTransitionName") {
 auto paramCount = 3;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 auto className = arguments[2].isString()
 ? stringFromValue(runtime, arguments[2])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->applyViewTransitionName(
 shadowNode, transitionName, className);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "cancelViewTransitionName") {
 auto paramCount = 2;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto transitionName = arguments[1].isString()
 ? stringFromValue(runtime, arguments[1])
 : "";
 if (!transitionName.empty()) {
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->cancelViewTransitionName(
 shadowNode, transitionName);
 }
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "restoreViewTransitionName") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 if (arguments[0].isObject()) {
 auto shadowNode =
 Bridging<std::shared_ptr<const ShadowNode>>::fromJs(
 runtime, arguments[0]);
 auto* viewTransitionDelegate =
 uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate != nullptr) {
 viewTransitionDelegate->restoreViewTransitionName(shadowNode);
 }
 }

 return jsi::Value::undefined();
 });
 }

 if (methodName == "startViewTransition") {
 auto paramCount = 1;
 return jsi::Function::createFromHostFunction(
 runtime,
 name,
 paramCount,
 [uiManager, methodName, paramCount](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* arguments,
 size_t count) -> jsi::Value {
 validateArgumentCount(runtime, methodName, paramCount, count);

 auto* viewTransitionDelegate = uiManager->getViewTransitionDelegate();
 if (viewTransitionDelegate == nullptr) {
 return jsi::Value::undefined();
 }

 auto promiseConstructor =
 runtime.global().getPropertyAsFunction(runtime, "Promise");

 auto readyResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();
 auto finishedResolveFunc =
 std::make_shared<std::shared_ptr<jsi::Function>>();

 auto mutationFunc = std::make_shared<jsi::Function>(
 arguments[0].asObject(runtime).asFunction(runtime));

 auto readyPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "readyExecutor"),
 2,
 [readyResolveFunc](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onReadyFunc = std::make_shared<jsi::Function>(
 args[0].asObject(runtime).asFunction(runtime));
 *readyResolveFunc = onReadyFunc;
 return jsi::Value::undefined();
 }));

 auto finishedPromise = promiseConstructor.callAsConstructor(
 runtime,
 jsi::Function::createFromHostFunction(
 runtime,
 jsi::PropNameID::forAscii(runtime, "finishedExecutor"),
 2,
 [finishedResolveFunc, viewTransitionDelegate](
 jsi::Runtime& rt,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* args,
 size_t /*count*/) -> jsi::Value {
 auto onCompleteFunc = std::make_shared<jsi::Function>(
 args[0].asObject(rt).asFunction(rt));
 *finishedResolveFunc = std::make_shared<jsi::Function>(
 jsi::Function::createFromHostFunction(
 rt,
 jsi::PropNameID::forAscii(rt, "finishedResolve"),
 0,
 [onCompleteFunc, viewTransitionDelegate](
 jsi::Runtime& runtime,
 const jsi::Value& /*thisValue*/,
 const jsi::Value* /*args*/,
 size_t /*count*/) -> jsi::Value {
 onCompleteFunc->call(runtime);
 viewTransitionDelegate->startViewTransitionEnd();
 return jsi::Value::undefined();
 }));
 return jsi::Value::undefined();
 }));

 auto result = jsi::Object(runtime);
 result.setProperty(runtime, "ready", std::move(readyPromise));
 result.setProperty(runtime, "finished", std::move(finishedPromise));

 viewTransitionDelegate->startViewTransition(
 [&runtime, mutationFunc = std::move(mutationFunc)]() {
 mutationFunc->call(runtime);
 },
 [readyResolveFunc = std::move(readyResolveFunc), &runtime]() {
 if (*readyResolveFunc) {
 (*readyResolveFunc)->call(runtime);
 }
 },
 [finishedResolveFunc = std::move(finishedResolveFunc),
 uiManager]() {
 uiManager->runtimeExecutor_(
 [finishedResolveFunc = std::move(finishedResolveFunc)](
 jsi::Runtime& rt) mutable {
 if (*finishedResolveFunc) {
 (*finishedResolveFunc)->call(rt);
 }
 });
 });

 return jsi::Value(runtime, result);
 });
 }

 return jsi::Value::undefined();
}

Expand Down

42 changes: 42 additions & 0 deletions
packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
/*
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

#pragma once

#include <react/renderer/core/ShadowNode.h>
#include <functional>

namespace facebook::react {

class UIManagerViewTransitionDelegate {
 public:
 virtual ~UIManagerViewTransitionDelegate() = default;

 virtual void applyViewTransitionName(
 const std::shared_ptr<const ShadowNode> &shadowNode,
 const std::string &name,
 const std::string &className)
 {
 }

 virtual void cancelViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode, const std::string &name) {}

 virtual void restoreViewTransitionName(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void captureLayoutMetricsFromRoot(const std::shared_ptr<const ShadowNode> &shadowNode) {}

 virtual void startViewTransition(
 std::function<void()> mutationCallback,
 std::function<void()> onReadyCallback,
 std::function<void()> onCompleteCallback)
 {
 }

 virtual void startViewTransitionEnd() {}
};

} // namespace facebook::react
Loading