Uh oh!
There was an error while loading. Please reload this page.
Remove legacy RCTTimingModule (#57037) - #57037
Open
christophpurrer wants to merge 1 commit into
Open
Conversation
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107201906. |
cortinico
approved these changes
Jun 2, 2026
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
christophpurrerforce-pushed
the
export-D107201906
branch
from
June 2, 2026 18:20
b258084 to
184a83dComparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 2, 2026
Summary: Wires `RCTTiming` (iOS CoreModule for `setTimeout`/`setInterval`/idle callbacks) to the existing TurboModule spec at `packages/react-native/src/private/specs_DEPRECATED/modules/NativeTiming.js`. `RCTTiming` was the only remaining `legacy = True` entry in `React/CoreModules/BUCK`. The existing `RCT_EXPORT_METHOD` signatures already match the spec exactly, so this is a registration/wiring change only. Changes: - `RCTTiming.mm`: declare `<NativeTimingSpec>` conformance in a private interface and add `getTurboModule:` returning `NativeTimingSpecJSI`, mirroring the pattern used by `RCTAppState`. - `React/CoreModules/BUCK`: drop `legacy = True` from the `Timing` entry of `react_module_plugin_providers`. No public header changes — the bridgeless path (`ObjCTimerRegistry`) continues to instantiate `RCTTiming` via `initWithDelegate:` and the `RCTTimingDelegate` protocol. No CocoaPods / Swift Package changes are needed: `React-CoreModules.podspec` globs all `CoreModules/*.mm` and `FBReactNativeSpec` codegens `NativeTimingSpecJSI` from the existing JS spec. ## Changelog: [IOS][Fixed]Convert RCTTiming to TurboModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
2 times, most recently
from
June 3, 2026 17:18
f849c2f to
c625fe7Comparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
June 3, 2026 19:28
c625fe7 to
3fc1d3cComparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
June 3, 2026 21:15
3fc1d3c to
dac9bf7Comparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 4, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
June 4, 2026 04:18
dac9bf7 to
803b48aComparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 4, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 4, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
June 4, 2026 18:25
803b48a to
1c797beComparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 4, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 4, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
June 4, 2026 21:17
1c797be to
2f0250cComparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 4, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 4, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 4, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
June 4, 2026 23:37
2f0250c to
d105188Comparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 5, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
June 5, 2026 17:18
d105188 to
03476ccComparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 5, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
July 14, 2026 21:59
03476cc to
978af7bComparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 14, 2026
Summary: X-link: react#57037 ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 14, 2026
Summary: X-link: react#57037 ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
July 17, 2026 03:05
978af7b to
2b59456Comparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 17, 2026
Summary: X-link: react#57037 ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 17, 2026
Summary: X-link: react#57037 ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
July 17, 2026 03:07
2b59456 to
f58bbd0Comparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 17, 2026
Summary: X-link: react#57037 ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 17, 2026
Summary: X-link: react#57037 ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 17, 2026
Summary: X-link: react#57037 ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
July 17, 2026 18:40
f58bbd0 to
c1e0b38Comparechristophpurrerforce-pushed
the
export-D107201906
branch
from
July 17, 2026 18:43
c1e0b38 to
4a7ae25Comparecortinico
requested changes
Jul 20, 2026
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
christophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 24, 2026
Summary: Changelog: [INTERNAL] RCTTiming is NOT used in the RN new architecture: react#57081 And will be deleted in: react#57037 This change removes it from the binary Differential Revision: D113474826
meta-codesyncBot
pushed a commit
that referenced
this pull request
Jul 24, 2026
Summary: Pull Request resolved: #57657 Changelog: [INTERNAL] RCTTiming is NOT used in the RN new architecture: #57081 And will be deleted in: #57037 This change removes it from the binary Reviewed By: javache Differential Revision: D113474826 fbshipit-source-id: fb57d797ba299f48d5affac2b540388018c85291
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
christophpurrerforce-pushed
the
export-D107201906
branch
from
August 12, 2026 01:01
4a7ae25 to
0d9ce7cComparechristophpurrer added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 12, 2026
Summary: ## Changelog: [IOS][Fixed] Remove legacy RCTTimingModule Differential Revision: D107201906
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[IOS][Fixed] Remove legacy RCTTimingModule
Differential Revision: D107201906