Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,8 +107,8 @@
"nullthrows": "^1.1.1",
"prettier": "3.6.2",
"prettier-plugin-hermes-parser": "0.36.0",
"react": "19.2.3",
"react-test-renderer": "19.2.3",
"react": "19.2.7",
"react-test-renderer": "19.2.7",
"rimraf": "^3.0.2",
"shelljs": "^0.8.5",
"signedsource": "^2.0.0",
Expand All@@ -120,7 +120,7 @@
"ws": "^7.5.10"
},
"resolutions": {
"react-is": "19.2.3",
"react-is": "19.2.7",
"on-headers": "1.1.0",
"compression": "1.8.1",
"@microsoft/api-extractor/minimatch": "3.1.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-preset/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,6 @@
"regenerator-runtime": "^0.13.2"
},
"peerDependencies": {
"react": "^19.2.3"
"react": "^19.2.7"
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e7f6759bcc8955193867c6ab42bd07ad>>
* @generated SignedSource<<49a1a924bb8b9fa0ef032e4799b38449>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -18901,10 +18901,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<8d29d23a1c540d7502dd188e691eb725>>
* @generated SignedSource<<c53d3671e43bcb8c10913c2c982bcd24>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -10495,10 +10495,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1245 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1245.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c4dae0f7dbb88147f400089cab897268>>
* @generated SignedSource<<bd45566ab72011b8c888cf2e166af3bb>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -12298,10 +12298,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1537 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1537.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow
* @generated SignedSource<<cf323fc5ca893bab5669c7d321660412>>
* @generated SignedSource<<16b364e89f43b8a47832b0dfb98af11e>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<908f5fb85384725318e261f40e49d9a6>>
* @generated SignedSource<<1dd9e9c3f20e37ae14e485fc6ee3d9e9>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict
* @generated SignedSource<<4ab83fd2606d6a4d374ef914f231d9c1>>
* @generated SignedSource<<989e6e2e860dc2af7ba983849111bda8>>
*
* This file was sync'd from the facebook/react repository.
*/

import type {
Expand DownExpand Up@@ -138,6 +140,36 @@ export type RenderRootOptions = {
onDefaultTransitionIndicator?: () => void | (() => void),
};

/**
* Flat ReactNative renderer bundles are too big for Flow to parse efficiently.
* Provide minimal Flow typing for the high-level RN API and call it a day.
*/
export type ReactNativeType = {
findHostInstance_DEPRECATED<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?PublicInstance,
findNodeHandle<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?number,
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
dispatchCommand(
handle: PublicInstance,
command: string,
args: Array<mixed>,
): void,
sendAccessibilityEvent(handle: PublicInstance, eventType: string): void,
render(
element: React.MixedElement,
containerTag: number,
callback: ?() => void,
options: ?RenderRootOptions,
): ?React.ElementRef<React.ElementType>,
unmountComponentAtNode(containerTag: number): void,
unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
+unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
...
};

export opaque type Node = mixed;
export opaque type InternalInstanceHandle = mixed;

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<1f7876c0dc0b05685a730513dc410236>>
* @generated SignedSource<<67d18226984338ab9301147ce0a7d414>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<52163887de05f1cff05388145cf85b3b>>
* @generated SignedSource<<556d1487de0b9e4a09cbc67dd130a884>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@
"peerDependencies": {
"@react-native/jest-preset": "0.87.0-main",
"@types/react": "^19.1.1",
"react": "^19.2.3"
"react": "^19.2.7"
},
"peerDependenciesMeta": {
"@types/react": {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -1036,6 +1036,16 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableImperativeEvents: {
defaultValue: false,
metadata: {
description:
'When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: false,
metadata: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<77b178e216aa86a309f46cbf661d9122>>
* @generated SignedSource<<9ea39238fb9e7a4fd17f5c6a4f557e8c>>
* @flow strict
* @noformat
*/
Expand DownExpand Up@@ -33,6 +33,7 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
animatedShouldSyncValueBeforeStartCallback: Getter<boolean>,
animatedShouldUseSingleOp: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
enableImperativeEvents: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixVirtualizeListCollapseWindowSize: Getter<boolean>,
Expand DownExpand Up@@ -162,6 +163,11 @@ export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGe
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.
*/
export const enableImperativeEvents: Getter<boolean> = createJavaScriptFlagGetter('enableImperativeEvents', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*
* @fantom_flags enableNativeEventTargetEventDispatching:*
* @fantom_flags enableImperativeEvents:*
* @flow strict-local
* @format
*/
Expand DownExpand Up@@ -465,10 +466,13 @@ const {isOSS} = Fantom.getConstants();
});

// --- addEventListener / removeEventListener on refs ---
// These tests require EventTarget-based dispatching to be enabled,
// since addEventListener is only available when the flag is on.
// These tests require both `enableNativeEventTargetEventDispatching` and
// `enableImperativeEvents` to be enabled, since the public `addEventListener`
// API on element refs is only available when both flags are on. They are
// skipped for the other flag combinations.

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('addEventListener / removeEventListener', () => {
it('addEventListener on a ref receives dispatched events', () => {
Expand DownExpand Up@@ -915,7 +919,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? it
: it.skip)(
'direct (non-bubbling) events do not propagate via addEventListener',
Expand DownExpand Up@@ -964,7 +969,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('bubbling to document element and document', () => {
it('event bubbles from child up to the document element', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -354,3 +354,24 @@ export const ReactNativeElement_public: typeof ReactNativeElement =

// $FlowExpectedError[prop-missing]
ReactNativeElement_public.prototype = ReactNativeElement.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReactNativeElement.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@

// flowlint unsafe-getters-setters:off

import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags';
import ReadOnlyCharacterData from './ReadOnlyCharacterData';
import ReadOnlyNode from './ReadOnlyNode';

Expand DownExpand Up@@ -39,3 +40,24 @@ export const ReadOnlyText_public: typeof ReadOnlyText =

// $FlowExpectedError[prop-missing]
ReadOnlyText_public.prototype = ReadOnlyText.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReadOnlyText.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Upgrade React and renderers from 19.2.3 to 19.2.7 by rubennorte · Pull Request #57089 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,8 +107,8 @@
"nullthrows": "^1.1.1",
"prettier": "3.6.2",
"prettier-plugin-hermes-parser": "0.36.0",
"react": "19.2.3",
"react-test-renderer": "19.2.3",
"react": "19.2.7",
"react-test-renderer": "19.2.7",
"rimraf": "^3.0.2",
"shelljs": "^0.8.5",
"signedsource": "^2.0.0",
Expand All@@ -120,7 +120,7 @@
"ws": "^7.5.10"
},
"resolutions": {
"react-is": "19.2.3",
"react-is": "19.2.7",
"on-headers": "1.1.0",
"compression": "1.8.1",
"@microsoft/api-extractor/minimatch": "3.1.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-preset/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,6 @@
"regenerator-runtime": "^0.13.2"
},
"peerDependencies": {
"react": "^19.2.3"
"react": "^19.2.7"
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e7f6759bcc8955193867c6ab42bd07ad>>
* @generated SignedSource<<49a1a924bb8b9fa0ef032e4799b38449>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -18901,10 +18901,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<8d29d23a1c540d7502dd188e691eb725>>
* @generated SignedSource<<c53d3671e43bcb8c10913c2c982bcd24>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -10495,10 +10495,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1245 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1245.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c4dae0f7dbb88147f400089cab897268>>
* @generated SignedSource<<bd45566ab72011b8c888cf2e166af3bb>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -12298,10 +12298,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1537 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1537.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow
* @generated SignedSource<<cf323fc5ca893bab5669c7d321660412>>
* @generated SignedSource<<16b364e89f43b8a47832b0dfb98af11e>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<908f5fb85384725318e261f40e49d9a6>>
* @generated SignedSource<<1dd9e9c3f20e37ae14e485fc6ee3d9e9>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict
* @generated SignedSource<<4ab83fd2606d6a4d374ef914f231d9c1>>
* @generated SignedSource<<989e6e2e860dc2af7ba983849111bda8>>
*
* This file was sync'd from the facebook/react repository.
*/

import type {
Expand DownExpand Up@@ -138,6 +140,36 @@ export type RenderRootOptions = {
onDefaultTransitionIndicator?: () => void | (() => void),
};

/**
* Flat ReactNative renderer bundles are too big for Flow to parse efficiently.
* Provide minimal Flow typing for the high-level RN API and call it a day.
*/
export type ReactNativeType = {
findHostInstance_DEPRECATED<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?PublicInstance,
findNodeHandle<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?number,
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
dispatchCommand(
handle: PublicInstance,
command: string,
args: Array<mixed>,
): void,
sendAccessibilityEvent(handle: PublicInstance, eventType: string): void,
render(
element: React.MixedElement,
containerTag: number,
callback: ?() => void,
options: ?RenderRootOptions,
): ?React.ElementRef<React.ElementType>,
unmountComponentAtNode(containerTag: number): void,
unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
+unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
...
};

export opaque type Node = mixed;
export opaque type InternalInstanceHandle = mixed;

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<1f7876c0dc0b05685a730513dc410236>>
* @generated SignedSource<<67d18226984338ab9301147ce0a7d414>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<52163887de05f1cff05388145cf85b3b>>
* @generated SignedSource<<556d1487de0b9e4a09cbc67dd130a884>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@
"peerDependencies": {
"@react-native/jest-preset": "0.87.0-main",
"@types/react": "^19.1.1",
"react": "^19.2.3"
"react": "^19.2.7"
},
"peerDependenciesMeta": {
"@types/react": {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -1036,6 +1036,16 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableImperativeEvents: {
defaultValue: false,
metadata: {
description:
'When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: false,
metadata: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<77b178e216aa86a309f46cbf661d9122>>
* @generated SignedSource<<9ea39238fb9e7a4fd17f5c6a4f557e8c>>
* @flow strict
* @noformat
*/
Expand DownExpand Up@@ -33,6 +33,7 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
animatedShouldSyncValueBeforeStartCallback: Getter<boolean>,
animatedShouldUseSingleOp: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
enableImperativeEvents: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixVirtualizeListCollapseWindowSize: Getter<boolean>,
Expand DownExpand Up@@ -162,6 +163,11 @@ export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGe
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.
*/
export const enableImperativeEvents: Getter<boolean> = createJavaScriptFlagGetter('enableImperativeEvents', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*
* @fantom_flags enableNativeEventTargetEventDispatching:*
* @fantom_flags enableImperativeEvents:*
* @flow strict-local
* @format
*/
Expand DownExpand Up@@ -465,10 +466,13 @@ const {isOSS} = Fantom.getConstants();
});

// --- addEventListener / removeEventListener on refs ---
// These tests require EventTarget-based dispatching to be enabled,
// since addEventListener is only available when the flag is on.
// These tests require both `enableNativeEventTargetEventDispatching` and
// `enableImperativeEvents` to be enabled, since the public `addEventListener`
// API on element refs is only available when both flags are on. They are
// skipped for the other flag combinations.

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('addEventListener / removeEventListener', () => {
it('addEventListener on a ref receives dispatched events', () => {
Expand DownExpand Up@@ -915,7 +919,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? it
: it.skip)(
'direct (non-bubbling) events do not propagate via addEventListener',
Expand DownExpand Up@@ -964,7 +969,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('bubbling to document element and document', () => {
it('event bubbles from child up to the document element', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -354,3 +354,24 @@ export const ReactNativeElement_public: typeof ReactNativeElement =

// $FlowExpectedError[prop-missing]
ReactNativeElement_public.prototype = ReactNativeElement.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReactNativeElement.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@

// flowlint unsafe-getters-setters:off

import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags';
import ReadOnlyCharacterData from './ReadOnlyCharacterData';
import ReadOnlyNode from './ReadOnlyNode';

Expand DownExpand Up@@ -39,3 +40,24 @@ export const ReadOnlyText_public: typeof ReadOnlyText =

// $FlowExpectedError[prop-missing]
ReadOnlyText_public.prototype = ReadOnlyText.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReadOnlyText.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Upgrade React and renderers from 19.2.3 to 19.2.7 by rubennorte · Pull Request #57089 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,8 +107,8 @@
"nullthrows": "^1.1.1",
"prettier": "3.6.2",
"prettier-plugin-hermes-parser": "0.36.0",
"react": "19.2.3",
"react-test-renderer": "19.2.3",
"react": "19.2.7",
"react-test-renderer": "19.2.7",
"rimraf": "^3.0.2",
"shelljs": "^0.8.5",
"signedsource": "^2.0.0",
Expand All@@ -120,7 +120,7 @@
"ws": "^7.5.10"
},
"resolutions": {
"react-is": "19.2.3",
"react-is": "19.2.7",
"on-headers": "1.1.0",
"compression": "1.8.1",
"@microsoft/api-extractor/minimatch": "3.1.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-preset/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,6 @@
"regenerator-runtime": "^0.13.2"
},
"peerDependencies": {
"react": "^19.2.3"
"react": "^19.2.7"
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e7f6759bcc8955193867c6ab42bd07ad>>
* @generated SignedSource<<49a1a924bb8b9fa0ef032e4799b38449>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -18901,10 +18901,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<8d29d23a1c540d7502dd188e691eb725>>
* @generated SignedSource<<c53d3671e43bcb8c10913c2c982bcd24>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -10495,10 +10495,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1245 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1245.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c4dae0f7dbb88147f400089cab897268>>
* @generated SignedSource<<bd45566ab72011b8c888cf2e166af3bb>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -12298,10 +12298,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1537 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1537.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow
* @generated SignedSource<<cf323fc5ca893bab5669c7d321660412>>
* @generated SignedSource<<16b364e89f43b8a47832b0dfb98af11e>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<908f5fb85384725318e261f40e49d9a6>>
* @generated SignedSource<<1dd9e9c3f20e37ae14e485fc6ee3d9e9>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict
* @generated SignedSource<<4ab83fd2606d6a4d374ef914f231d9c1>>
* @generated SignedSource<<989e6e2e860dc2af7ba983849111bda8>>
*
* This file was sync'd from the facebook/react repository.
*/

import type {
Expand DownExpand Up@@ -138,6 +140,36 @@ export type RenderRootOptions = {
onDefaultTransitionIndicator?: () => void | (() => void),
};

/**
* Flat ReactNative renderer bundles are too big for Flow to parse efficiently.
* Provide minimal Flow typing for the high-level RN API and call it a day.
*/
export type ReactNativeType = {
findHostInstance_DEPRECATED<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?PublicInstance,
findNodeHandle<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?number,
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
dispatchCommand(
handle: PublicInstance,
command: string,
args: Array<mixed>,
): void,
sendAccessibilityEvent(handle: PublicInstance, eventType: string): void,
render(
element: React.MixedElement,
containerTag: number,
callback: ?() => void,
options: ?RenderRootOptions,
): ?React.ElementRef<React.ElementType>,
unmountComponentAtNode(containerTag: number): void,
unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
+unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
...
};

export opaque type Node = mixed;
export opaque type InternalInstanceHandle = mixed;

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<1f7876c0dc0b05685a730513dc410236>>
* @generated SignedSource<<67d18226984338ab9301147ce0a7d414>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<52163887de05f1cff05388145cf85b3b>>
* @generated SignedSource<<556d1487de0b9e4a09cbc67dd130a884>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@
"peerDependencies": {
"@react-native/jest-preset": "0.87.0-main",
"@types/react": "^19.1.1",
"react": "^19.2.3"
"react": "^19.2.7"
},
"peerDependenciesMeta": {
"@types/react": {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -1036,6 +1036,16 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableImperativeEvents: {
defaultValue: false,
metadata: {
description:
'When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: false,
metadata: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<77b178e216aa86a309f46cbf661d9122>>
* @generated SignedSource<<9ea39238fb9e7a4fd17f5c6a4f557e8c>>
* @flow strict
* @noformat
*/
Expand DownExpand Up@@ -33,6 +33,7 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
animatedShouldSyncValueBeforeStartCallback: Getter<boolean>,
animatedShouldUseSingleOp: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
enableImperativeEvents: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixVirtualizeListCollapseWindowSize: Getter<boolean>,
Expand DownExpand Up@@ -162,6 +163,11 @@ export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGe
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.
*/
export const enableImperativeEvents: Getter<boolean> = createJavaScriptFlagGetter('enableImperativeEvents', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*
* @fantom_flags enableNativeEventTargetEventDispatching:*
* @fantom_flags enableImperativeEvents:*
* @flow strict-local
* @format
*/
Expand DownExpand Up@@ -465,10 +466,13 @@ const {isOSS} = Fantom.getConstants();
});

// --- addEventListener / removeEventListener on refs ---
// These tests require EventTarget-based dispatching to be enabled,
// since addEventListener is only available when the flag is on.
// These tests require both `enableNativeEventTargetEventDispatching` and
// `enableImperativeEvents` to be enabled, since the public `addEventListener`
// API on element refs is only available when both flags are on. They are
// skipped for the other flag combinations.

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('addEventListener / removeEventListener', () => {
it('addEventListener on a ref receives dispatched events', () => {
Expand DownExpand Up@@ -915,7 +919,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? it
: it.skip)(
'direct (non-bubbling) events do not propagate via addEventListener',
Expand DownExpand Up@@ -964,7 +969,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('bubbling to document element and document', () => {
it('event bubbles from child up to the document element', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -354,3 +354,24 @@ export const ReactNativeElement_public: typeof ReactNativeElement =

// $FlowExpectedError[prop-missing]
ReactNativeElement_public.prototype = ReactNativeElement.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReactNativeElement.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@

// flowlint unsafe-getters-setters:off

import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags';
import ReadOnlyCharacterData from './ReadOnlyCharacterData';
import ReadOnlyNode from './ReadOnlyNode';

Expand DownExpand Up@@ -39,3 +40,24 @@ export const ReadOnlyText_public: typeof ReadOnlyText =

// $FlowExpectedError[prop-missing]
ReadOnlyText_public.prototype = ReadOnlyText.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReadOnlyText.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Upgrade React and renderers from 19.2.3 to 19.2.7 by rubennorte · Pull Request #57089 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,8 +107,8 @@
"nullthrows": "^1.1.1",
"prettier": "3.6.2",
"prettier-plugin-hermes-parser": "0.36.0",
"react": "19.2.3",
"react-test-renderer": "19.2.3",
"react": "19.2.7",
"react-test-renderer": "19.2.7",
"rimraf": "^3.0.2",
"shelljs": "^0.8.5",
"signedsource": "^2.0.0",
Expand All@@ -120,7 +120,7 @@
"ws": "^7.5.10"
},
"resolutions": {
"react-is": "19.2.3",
"react-is": "19.2.7",
"on-headers": "1.1.0",
"compression": "1.8.1",
"@microsoft/api-extractor/minimatch": "3.1.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-preset/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,6 @@
"regenerator-runtime": "^0.13.2"
},
"peerDependencies": {
"react": "^19.2.3"
"react": "^19.2.7"
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e7f6759bcc8955193867c6ab42bd07ad>>
* @generated SignedSource<<49a1a924bb8b9fa0ef032e4799b38449>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -18901,10 +18901,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<8d29d23a1c540d7502dd188e691eb725>>
* @generated SignedSource<<c53d3671e43bcb8c10913c2c982bcd24>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -10495,10 +10495,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1245 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1245.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c4dae0f7dbb88147f400089cab897268>>
* @generated SignedSource<<bd45566ab72011b8c888cf2e166af3bb>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -12298,10 +12298,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1537 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1537.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow
* @generated SignedSource<<cf323fc5ca893bab5669c7d321660412>>
* @generated SignedSource<<16b364e89f43b8a47832b0dfb98af11e>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<908f5fb85384725318e261f40e49d9a6>>
* @generated SignedSource<<1dd9e9c3f20e37ae14e485fc6ee3d9e9>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict
* @generated SignedSource<<4ab83fd2606d6a4d374ef914f231d9c1>>
* @generated SignedSource<<989e6e2e860dc2af7ba983849111bda8>>
*
* This file was sync'd from the facebook/react repository.
*/

import type {
Expand DownExpand Up@@ -138,6 +140,36 @@ export type RenderRootOptions = {
onDefaultTransitionIndicator?: () => void | (() => void),
};

/**
* Flat ReactNative renderer bundles are too big for Flow to parse efficiently.
* Provide minimal Flow typing for the high-level RN API and call it a day.
*/
export type ReactNativeType = {
findHostInstance_DEPRECATED<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?PublicInstance,
findNodeHandle<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?number,
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
dispatchCommand(
handle: PublicInstance,
command: string,
args: Array<mixed>,
): void,
sendAccessibilityEvent(handle: PublicInstance, eventType: string): void,
render(
element: React.MixedElement,
containerTag: number,
callback: ?() => void,
options: ?RenderRootOptions,
): ?React.ElementRef<React.ElementType>,
unmountComponentAtNode(containerTag: number): void,
unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
+unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
...
};

export opaque type Node = mixed;
export opaque type InternalInstanceHandle = mixed;

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<1f7876c0dc0b05685a730513dc410236>>
* @generated SignedSource<<67d18226984338ab9301147ce0a7d414>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<52163887de05f1cff05388145cf85b3b>>
* @generated SignedSource<<556d1487de0b9e4a09cbc67dd130a884>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@
"peerDependencies": {
"@react-native/jest-preset": "0.87.0-main",
"@types/react": "^19.1.1",
"react": "^19.2.3"
"react": "^19.2.7"
},
"peerDependenciesMeta": {
"@types/react": {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -1036,6 +1036,16 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableImperativeEvents: {
defaultValue: false,
metadata: {
description:
'When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: false,
metadata: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<77b178e216aa86a309f46cbf661d9122>>
* @generated SignedSource<<9ea39238fb9e7a4fd17f5c6a4f557e8c>>
* @flow strict
* @noformat
*/
Expand DownExpand Up@@ -33,6 +33,7 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
animatedShouldSyncValueBeforeStartCallback: Getter<boolean>,
animatedShouldUseSingleOp: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
enableImperativeEvents: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixVirtualizeListCollapseWindowSize: Getter<boolean>,
Expand DownExpand Up@@ -162,6 +163,11 @@ export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGe
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.
*/
export const enableImperativeEvents: Getter<boolean> = createJavaScriptFlagGetter('enableImperativeEvents', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*
* @fantom_flags enableNativeEventTargetEventDispatching:*
* @fantom_flags enableImperativeEvents:*
* @flow strict-local
* @format
*/
Expand DownExpand Up@@ -465,10 +466,13 @@ const {isOSS} = Fantom.getConstants();
});

// --- addEventListener / removeEventListener on refs ---
// These tests require EventTarget-based dispatching to be enabled,
// since addEventListener is only available when the flag is on.
// These tests require both `enableNativeEventTargetEventDispatching` and
// `enableImperativeEvents` to be enabled, since the public `addEventListener`
// API on element refs is only available when both flags are on. They are
// skipped for the other flag combinations.

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('addEventListener / removeEventListener', () => {
it('addEventListener on a ref receives dispatched events', () => {
Expand DownExpand Up@@ -915,7 +919,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? it
: it.skip)(
'direct (non-bubbling) events do not propagate via addEventListener',
Expand DownExpand Up@@ -964,7 +969,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('bubbling to document element and document', () => {
it('event bubbles from child up to the document element', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -354,3 +354,24 @@ export const ReactNativeElement_public: typeof ReactNativeElement =

// $FlowExpectedError[prop-missing]
ReactNativeElement_public.prototype = ReactNativeElement.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReactNativeElement.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@

// flowlint unsafe-getters-setters:off

import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags';
import ReadOnlyCharacterData from './ReadOnlyCharacterData';
import ReadOnlyNode from './ReadOnlyNode';

Expand DownExpand Up@@ -39,3 +40,24 @@ export const ReadOnlyText_public: typeof ReadOnlyText =

// $FlowExpectedError[prop-missing]
ReadOnlyText_public.prototype = ReadOnlyText.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReadOnlyText.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Upgrade React and renderers from 19.2.3 to 19.2.7 by rubennorte · Pull Request #57089 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,8 +107,8 @@
"nullthrows": "^1.1.1",
"prettier": "3.6.2",
"prettier-plugin-hermes-parser": "0.36.0",
"react": "19.2.3",
"react-test-renderer": "19.2.3",
"react": "19.2.7",
"react-test-renderer": "19.2.7",
"rimraf": "^3.0.2",
"shelljs": "^0.8.5",
"signedsource": "^2.0.0",
Expand All@@ -120,7 +120,7 @@
"ws": "^7.5.10"
},
"resolutions": {
"react-is": "19.2.3",
"react-is": "19.2.7",
"on-headers": "1.1.0",
"compression": "1.8.1",
"@microsoft/api-extractor/minimatch": "3.1.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-preset/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,6 @@
"regenerator-runtime": "^0.13.2"
},
"peerDependencies": {
"react": "^19.2.3"
"react": "^19.2.7"
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e7f6759bcc8955193867c6ab42bd07ad>>
* @generated SignedSource<<49a1a924bb8b9fa0ef032e4799b38449>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -18901,10 +18901,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<8d29d23a1c540d7502dd188e691eb725>>
* @generated SignedSource<<c53d3671e43bcb8c10913c2c982bcd24>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -10495,10 +10495,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1245 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1245.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c4dae0f7dbb88147f400089cab897268>>
* @generated SignedSource<<bd45566ab72011b8c888cf2e166af3bb>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -12298,10 +12298,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1537 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1537.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow
* @generated SignedSource<<cf323fc5ca893bab5669c7d321660412>>
* @generated SignedSource<<16b364e89f43b8a47832b0dfb98af11e>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<908f5fb85384725318e261f40e49d9a6>>
* @generated SignedSource<<1dd9e9c3f20e37ae14e485fc6ee3d9e9>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict
* @generated SignedSource<<4ab83fd2606d6a4d374ef914f231d9c1>>
* @generated SignedSource<<989e6e2e860dc2af7ba983849111bda8>>
*
* This file was sync'd from the facebook/react repository.
*/

import type {
Expand DownExpand Up@@ -138,6 +140,36 @@ export type RenderRootOptions = {
onDefaultTransitionIndicator?: () => void | (() => void),
};

/**
* Flat ReactNative renderer bundles are too big for Flow to parse efficiently.
* Provide minimal Flow typing for the high-level RN API and call it a day.
*/
export type ReactNativeType = {
findHostInstance_DEPRECATED<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?PublicInstance,
findNodeHandle<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?number,
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
dispatchCommand(
handle: PublicInstance,
command: string,
args: Array<mixed>,
): void,
sendAccessibilityEvent(handle: PublicInstance, eventType: string): void,
render(
element: React.MixedElement,
containerTag: number,
callback: ?() => void,
options: ?RenderRootOptions,
): ?React.ElementRef<React.ElementType>,
unmountComponentAtNode(containerTag: number): void,
unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
+unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
...
};

export opaque type Node = mixed;
export opaque type InternalInstanceHandle = mixed;

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<1f7876c0dc0b05685a730513dc410236>>
* @generated SignedSource<<67d18226984338ab9301147ce0a7d414>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<52163887de05f1cff05388145cf85b3b>>
* @generated SignedSource<<556d1487de0b9e4a09cbc67dd130a884>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@
"peerDependencies": {
"@react-native/jest-preset": "0.87.0-main",
"@types/react": "^19.1.1",
"react": "^19.2.3"
"react": "^19.2.7"
},
"peerDependenciesMeta": {
"@types/react": {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -1036,6 +1036,16 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableImperativeEvents: {
defaultValue: false,
metadata: {
description:
'When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: false,
metadata: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<77b178e216aa86a309f46cbf661d9122>>
* @generated SignedSource<<9ea39238fb9e7a4fd17f5c6a4f557e8c>>
* @flow strict
* @noformat
*/
Expand DownExpand Up@@ -33,6 +33,7 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
animatedShouldSyncValueBeforeStartCallback: Getter<boolean>,
animatedShouldUseSingleOp: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
enableImperativeEvents: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixVirtualizeListCollapseWindowSize: Getter<boolean>,
Expand DownExpand Up@@ -162,6 +163,11 @@ export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGe
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.
*/
export const enableImperativeEvents: Getter<boolean> = createJavaScriptFlagGetter('enableImperativeEvents', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*
* @fantom_flags enableNativeEventTargetEventDispatching:*
* @fantom_flags enableImperativeEvents:*
* @flow strict-local
* @format
*/
Expand DownExpand Up@@ -465,10 +466,13 @@ const {isOSS} = Fantom.getConstants();
});

// --- addEventListener / removeEventListener on refs ---
// These tests require EventTarget-based dispatching to be enabled,
// since addEventListener is only available when the flag is on.
// These tests require both `enableNativeEventTargetEventDispatching` and
// `enableImperativeEvents` to be enabled, since the public `addEventListener`
// API on element refs is only available when both flags are on. They are
// skipped for the other flag combinations.

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('addEventListener / removeEventListener', () => {
it('addEventListener on a ref receives dispatched events', () => {
Expand DownExpand Up@@ -915,7 +919,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? it
: it.skip)(
'direct (non-bubbling) events do not propagate via addEventListener',
Expand DownExpand Up@@ -964,7 +969,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('bubbling to document element and document', () => {
it('event bubbles from child up to the document element', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -354,3 +354,24 @@ export const ReactNativeElement_public: typeof ReactNativeElement =

// $FlowExpectedError[prop-missing]
ReactNativeElement_public.prototype = ReactNativeElement.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReactNativeElement.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@

// flowlint unsafe-getters-setters:off

import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags';
import ReadOnlyCharacterData from './ReadOnlyCharacterData';
import ReadOnlyNode from './ReadOnlyNode';

Expand DownExpand Up@@ -39,3 +40,24 @@ export const ReadOnlyText_public: typeof ReadOnlyText =

// $FlowExpectedError[prop-missing]
ReadOnlyText_public.prototype = ReadOnlyText.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReadOnlyText.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Upgrade React and renderers from 19.2.3 to 19.2.7 by rubennorte · Pull Request #57089 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,8 +107,8 @@
"nullthrows": "^1.1.1",
"prettier": "3.6.2",
"prettier-plugin-hermes-parser": "0.36.0",
"react": "19.2.3",
"react-test-renderer": "19.2.3",
"react": "19.2.7",
"react-test-renderer": "19.2.7",
"rimraf": "^3.0.2",
"shelljs": "^0.8.5",
"signedsource": "^2.0.0",
Expand All@@ -120,7 +120,7 @@
"ws": "^7.5.10"
},
"resolutions": {
"react-is": "19.2.3",
"react-is": "19.2.7",
"on-headers": "1.1.0",
"compression": "1.8.1",
"@microsoft/api-extractor/minimatch": "3.1.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-preset/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,6 @@
"regenerator-runtime": "^0.13.2"
},
"peerDependencies": {
"react": "^19.2.3"
"react": "^19.2.7"
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e7f6759bcc8955193867c6ab42bd07ad>>
* @generated SignedSource<<49a1a924bb8b9fa0ef032e4799b38449>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -18901,10 +18901,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<8d29d23a1c540d7502dd188e691eb725>>
* @generated SignedSource<<c53d3671e43bcb8c10913c2c982bcd24>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -10495,10 +10495,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1245 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1245.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c4dae0f7dbb88147f400089cab897268>>
* @generated SignedSource<<bd45566ab72011b8c888cf2e166af3bb>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -12298,10 +12298,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1537 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1537.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow
* @generated SignedSource<<cf323fc5ca893bab5669c7d321660412>>
* @generated SignedSource<<16b364e89f43b8a47832b0dfb98af11e>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<908f5fb85384725318e261f40e49d9a6>>
* @generated SignedSource<<1dd9e9c3f20e37ae14e485fc6ee3d9e9>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict
* @generated SignedSource<<4ab83fd2606d6a4d374ef914f231d9c1>>
* @generated SignedSource<<989e6e2e860dc2af7ba983849111bda8>>
*
* This file was sync'd from the facebook/react repository.
*/

import type {
Expand DownExpand Up@@ -138,6 +140,36 @@ export type RenderRootOptions = {
onDefaultTransitionIndicator?: () => void | (() => void),
};

/**
* Flat ReactNative renderer bundles are too big for Flow to parse efficiently.
* Provide minimal Flow typing for the high-level RN API and call it a day.
*/
export type ReactNativeType = {
findHostInstance_DEPRECATED<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?PublicInstance,
findNodeHandle<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?number,
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
dispatchCommand(
handle: PublicInstance,
command: string,
args: Array<mixed>,
): void,
sendAccessibilityEvent(handle: PublicInstance, eventType: string): void,
render(
element: React.MixedElement,
containerTag: number,
callback: ?() => void,
options: ?RenderRootOptions,
): ?React.ElementRef<React.ElementType>,
unmountComponentAtNode(containerTag: number): void,
unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
+unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
...
};

export opaque type Node = mixed;
export opaque type InternalInstanceHandle = mixed;

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<1f7876c0dc0b05685a730513dc410236>>
* @generated SignedSource<<67d18226984338ab9301147ce0a7d414>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<52163887de05f1cff05388145cf85b3b>>
* @generated SignedSource<<556d1487de0b9e4a09cbc67dd130a884>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@
"peerDependencies": {
"@react-native/jest-preset": "0.87.0-main",
"@types/react": "^19.1.1",
"react": "^19.2.3"
"react": "^19.2.7"
},
"peerDependenciesMeta": {
"@types/react": {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -1036,6 +1036,16 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableImperativeEvents: {
defaultValue: false,
metadata: {
description:
'When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: false,
metadata: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<77b178e216aa86a309f46cbf661d9122>>
* @generated SignedSource<<9ea39238fb9e7a4fd17f5c6a4f557e8c>>
* @flow strict
* @noformat
*/
Expand DownExpand Up@@ -33,6 +33,7 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
animatedShouldSyncValueBeforeStartCallback: Getter<boolean>,
animatedShouldUseSingleOp: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
enableImperativeEvents: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixVirtualizeListCollapseWindowSize: Getter<boolean>,
Expand DownExpand Up@@ -162,6 +163,11 @@ export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGe
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.
*/
export const enableImperativeEvents: Getter<boolean> = createJavaScriptFlagGetter('enableImperativeEvents', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*
* @fantom_flags enableNativeEventTargetEventDispatching:*
* @fantom_flags enableImperativeEvents:*
* @flow strict-local
* @format
*/
Expand DownExpand Up@@ -465,10 +466,13 @@ const {isOSS} = Fantom.getConstants();
});

// --- addEventListener / removeEventListener on refs ---
// These tests require EventTarget-based dispatching to be enabled,
// since addEventListener is only available when the flag is on.
// These tests require both `enableNativeEventTargetEventDispatching` and
// `enableImperativeEvents` to be enabled, since the public `addEventListener`
// API on element refs is only available when both flags are on. They are
// skipped for the other flag combinations.

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('addEventListener / removeEventListener', () => {
it('addEventListener on a ref receives dispatched events', () => {
Expand DownExpand Up@@ -915,7 +919,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? it
: it.skip)(
'direct (non-bubbling) events do not propagate via addEventListener',
Expand DownExpand Up@@ -964,7 +969,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('bubbling to document element and document', () => {
it('event bubbles from child up to the document element', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -354,3 +354,24 @@ export const ReactNativeElement_public: typeof ReactNativeElement =

// $FlowExpectedError[prop-missing]
ReactNativeElement_public.prototype = ReactNativeElement.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReactNativeElement.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@

// flowlint unsafe-getters-setters:off

import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags';
import ReadOnlyCharacterData from './ReadOnlyCharacterData';
import ReadOnlyNode from './ReadOnlyNode';

Expand DownExpand Up@@ -39,3 +40,24 @@ export const ReadOnlyText_public: typeof ReadOnlyText =

// $FlowExpectedError[prop-missing]
ReadOnlyText_public.prototype = ReadOnlyText.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReadOnlyText.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Upgrade React and renderers from 19.2.3 to 19.2.7 by rubennorte · Pull Request #57089 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,8 +107,8 @@
"nullthrows": "^1.1.1",
"prettier": "3.6.2",
"prettier-plugin-hermes-parser": "0.36.0",
"react": "19.2.3",
"react-test-renderer": "19.2.3",
"react": "19.2.7",
"react-test-renderer": "19.2.7",
"rimraf": "^3.0.2",
"shelljs": "^0.8.5",
"signedsource": "^2.0.0",
Expand All@@ -120,7 +120,7 @@
"ws": "^7.5.10"
},
"resolutions": {
"react-is": "19.2.3",
"react-is": "19.2.7",
"on-headers": "1.1.0",
"compression": "1.8.1",
"@microsoft/api-extractor/minimatch": "3.1.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-preset/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,6 @@
"regenerator-runtime": "^0.13.2"
},
"peerDependencies": {
"react": "^19.2.3"
"react": "^19.2.7"
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e7f6759bcc8955193867c6ab42bd07ad>>
* @generated SignedSource<<49a1a924bb8b9fa0ef032e4799b38449>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -18901,10 +18901,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<8d29d23a1c540d7502dd188e691eb725>>
* @generated SignedSource<<c53d3671e43bcb8c10913c2c982bcd24>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -10495,10 +10495,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1245 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1245.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c4dae0f7dbb88147f400089cab897268>>
* @generated SignedSource<<bd45566ab72011b8c888cf2e166af3bb>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -12298,10 +12298,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1537 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1537.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow
* @generated SignedSource<<cf323fc5ca893bab5669c7d321660412>>
* @generated SignedSource<<16b364e89f43b8a47832b0dfb98af11e>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<908f5fb85384725318e261f40e49d9a6>>
* @generated SignedSource<<1dd9e9c3f20e37ae14e485fc6ee3d9e9>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict
* @generated SignedSource<<4ab83fd2606d6a4d374ef914f231d9c1>>
* @generated SignedSource<<989e6e2e860dc2af7ba983849111bda8>>
*
* This file was sync'd from the facebook/react repository.
*/

import type {
Expand DownExpand Up@@ -138,6 +140,36 @@ export type RenderRootOptions = {
onDefaultTransitionIndicator?: () => void | (() => void),
};

/**
* Flat ReactNative renderer bundles are too big for Flow to parse efficiently.
* Provide minimal Flow typing for the high-level RN API and call it a day.
*/
export type ReactNativeType = {
findHostInstance_DEPRECATED<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?PublicInstance,
findNodeHandle<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?number,
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
dispatchCommand(
handle: PublicInstance,
command: string,
args: Array<mixed>,
): void,
sendAccessibilityEvent(handle: PublicInstance, eventType: string): void,
render(
element: React.MixedElement,
containerTag: number,
callback: ?() => void,
options: ?RenderRootOptions,
): ?React.ElementRef<React.ElementType>,
unmountComponentAtNode(containerTag: number): void,
unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
+unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
...
};

export opaque type Node = mixed;
export opaque type InternalInstanceHandle = mixed;

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<1f7876c0dc0b05685a730513dc410236>>
* @generated SignedSource<<67d18226984338ab9301147ce0a7d414>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<52163887de05f1cff05388145cf85b3b>>
* @generated SignedSource<<556d1487de0b9e4a09cbc67dd130a884>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@
"peerDependencies": {
"@react-native/jest-preset": "0.87.0-main",
"@types/react": "^19.1.1",
"react": "^19.2.3"
"react": "^19.2.7"
},
"peerDependenciesMeta": {
"@types/react": {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -1036,6 +1036,16 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableImperativeEvents: {
defaultValue: false,
metadata: {
description:
'When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: false,
metadata: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<77b178e216aa86a309f46cbf661d9122>>
* @generated SignedSource<<9ea39238fb9e7a4fd17f5c6a4f557e8c>>
* @flow strict
* @noformat
*/
Expand DownExpand Up@@ -33,6 +33,7 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
animatedShouldSyncValueBeforeStartCallback: Getter<boolean>,
animatedShouldUseSingleOp: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
enableImperativeEvents: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixVirtualizeListCollapseWindowSize: Getter<boolean>,
Expand DownExpand Up@@ -162,6 +163,11 @@ export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGe
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.
*/
export const enableImperativeEvents: Getter<boolean> = createJavaScriptFlagGetter('enableImperativeEvents', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*
* @fantom_flags enableNativeEventTargetEventDispatching:*
* @fantom_flags enableImperativeEvents:*
* @flow strict-local
* @format
*/
Expand DownExpand Up@@ -465,10 +466,13 @@ const {isOSS} = Fantom.getConstants();
});

// --- addEventListener / removeEventListener on refs ---
// These tests require EventTarget-based dispatching to be enabled,
// since addEventListener is only available when the flag is on.
// These tests require both `enableNativeEventTargetEventDispatching` and
// `enableImperativeEvents` to be enabled, since the public `addEventListener`
// API on element refs is only available when both flags are on. They are
// skipped for the other flag combinations.

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('addEventListener / removeEventListener', () => {
it('addEventListener on a ref receives dispatched events', () => {
Expand DownExpand Up@@ -915,7 +919,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? it
: it.skip)(
'direct (non-bubbling) events do not propagate via addEventListener',
Expand DownExpand Up@@ -964,7 +969,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('bubbling to document element and document', () => {
it('event bubbles from child up to the document element', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -354,3 +354,24 @@ export const ReactNativeElement_public: typeof ReactNativeElement =

// $FlowExpectedError[prop-missing]
ReactNativeElement_public.prototype = ReactNativeElement.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReactNativeElement.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@

// flowlint unsafe-getters-setters:off

import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags';
import ReadOnlyCharacterData from './ReadOnlyCharacterData';
import ReadOnlyNode from './ReadOnlyNode';

Expand DownExpand Up@@ -39,3 +40,24 @@ export const ReadOnlyText_public: typeof ReadOnlyText =

// $FlowExpectedError[prop-missing]
ReadOnlyText_public.prototype = ReadOnlyText.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReadOnlyText.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Upgrade React and renderers from 19.2.3 to 19.2.7 by rubennorte · Pull Request #57089 · react/react-native · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,8 +107,8 @@
"nullthrows": "^1.1.1",
"prettier": "3.6.2",
"prettier-plugin-hermes-parser": "0.36.0",
"react": "19.2.3",
"react-test-renderer": "19.2.3",
"react": "19.2.7",
"react-test-renderer": "19.2.7",
"rimraf": "^3.0.2",
"shelljs": "^0.8.5",
"signedsource": "^2.0.0",
Expand All@@ -120,7 +120,7 @@
"ws": "^7.5.10"
},
"resolutions": {
"react-is": "19.2.3",
"react-is": "19.2.7",
"on-headers": "1.1.0",
"compression": "1.8.1",
"@microsoft/api-extractor/minimatch": "3.1.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-preset/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,6 @@
"regenerator-runtime": "^0.13.2"
},
"peerDependencies": {
"react": "^19.2.3"
"react": "^19.2.7"
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e7f6759bcc8955193867c6ab42bd07ad>>
* @generated SignedSource<<49a1a924bb8b9fa0ef032e4799b38449>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -18901,10 +18901,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<8d29d23a1c540d7502dd188e691eb725>>
* @generated SignedSource<<c53d3671e43bcb8c10913c2c982bcd24>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -10495,10 +10495,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1245 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1245.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c4dae0f7dbb88147f400089cab897268>>
* @generated SignedSource<<bd45566ab72011b8c888cf2e166af3bb>>
*
* This file was sync'd from the facebook/react repository.
*/
Expand DownExpand Up@@ -12298,10 +12298,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1537 = {
bundleType: 0,
version: "19.2.3",
version: "19.2.7",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.3"
reconcilerVersion: "19.2.7"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1537.rendererConfig = extraDevToolsConfig);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow
* @generated SignedSource<<cf323fc5ca893bab5669c7d321660412>>
* @generated SignedSource<<16b364e89f43b8a47832b0dfb98af11e>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<908f5fb85384725318e261f40e49d9a6>>
* @generated SignedSource<<1dd9e9c3f20e37ae14e485fc6ee3d9e9>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict
* @generated SignedSource<<4ab83fd2606d6a4d374ef914f231d9c1>>
* @generated SignedSource<<989e6e2e860dc2af7ba983849111bda8>>
*
* This file was sync'd from the facebook/react repository.
*/

import type {
Expand DownExpand Up@@ -138,6 +140,36 @@ export type RenderRootOptions = {
onDefaultTransitionIndicator?: () => void | (() => void),
};

/**
* Flat ReactNative renderer bundles are too big for Flow to parse efficiently.
* Provide minimal Flow typing for the high-level RN API and call it a day.
*/
export type ReactNativeType = {
findHostInstance_DEPRECATED<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?PublicInstance,
findNodeHandle<TElementType: React.ElementType>(
componentOrHandle: ?(React.ElementRef<TElementType> | number),
): ?number,
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
dispatchCommand(
handle: PublicInstance,
command: string,
args: Array<mixed>,
): void,
sendAccessibilityEvent(handle: PublicInstance, eventType: string): void,
render(
element: React.MixedElement,
containerTag: number,
callback: ?() => void,
options: ?RenderRootOptions,
): ?React.ElementRef<React.ElementType>,
unmountComponentAtNode(containerTag: number): void,
unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
+unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
...
};

export opaque type Node = mixed;
export opaque type InternalInstanceHandle = mixed;

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<1f7876c0dc0b05685a730513dc410236>>
* @generated SignedSource<<67d18226984338ab9301147ce0a7d414>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,9 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<52163887de05f1cff05388145cf85b3b>>
* @generated SignedSource<<556d1487de0b9e4a09cbc67dd130a884>>
*
* This file was sync'd from the facebook/react repository.
*/

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@
"peerDependencies": {
"@react-native/jest-preset": "0.87.0-main",
"@types/react": "^19.1.1",
"react": "^19.2.3"
"react": "^19.2.7"
},
"peerDependenciesMeta": {
"@types/react": {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -1036,6 +1036,16 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableImperativeEvents: {
defaultValue: false,
metadata: {
description:
'When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: false,
metadata: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<77b178e216aa86a309f46cbf661d9122>>
* @generated SignedSource<<9ea39238fb9e7a4fd17f5c6a4f557e8c>>
* @flow strict
* @noformat
*/
Expand DownExpand Up@@ -33,6 +33,7 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
animatedShouldSyncValueBeforeStartCallback: Getter<boolean>,
animatedShouldUseSingleOp: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
enableImperativeEvents: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixVirtualizeListCollapseWindowSize: Getter<boolean>,
Expand DownExpand Up@@ -162,6 +163,11 @@ export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGe
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* When enabled, ReactNativeElement and ReadOnlyText expose the public EventTarget API (addEventListener, removeEventListener, dispatchEvent). When disabled, those methods are removed from those final classes.
*/
export const enableImperativeEvents: Getter<boolean> = createJavaScriptFlagGetter('enableImperativeEvents', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*
* @fantom_flags enableNativeEventTargetEventDispatching:*
* @fantom_flags enableImperativeEvents:*
* @flow strict-local
* @format
*/
Expand DownExpand Up@@ -465,10 +466,13 @@ const {isOSS} = Fantom.getConstants();
});

// --- addEventListener / removeEventListener on refs ---
// These tests require EventTarget-based dispatching to be enabled,
// since addEventListener is only available when the flag is on.
// These tests require both `enableNativeEventTargetEventDispatching` and
// `enableImperativeEvents` to be enabled, since the public `addEventListener`
// API on element refs is only available when both flags are on. They are
// skipped for the other flag combinations.

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('addEventListener / removeEventListener', () => {
it('addEventListener on a ref receives dispatched events', () => {
Expand DownExpand Up@@ -915,7 +919,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? it
: it.skip)(
'direct (non-bubbling) events do not propagate via addEventListener',
Expand DownExpand Up@@ -964,7 +969,8 @@ const {isOSS} = Fantom.getConstants();
},
);

(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching()
(ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
ReactNativeFeatureFlags.enableImperativeEvents()
? describe
: describe.skip)('bubbling to document element and document', () => {
it('event bubbles from child up to the document element', () => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -354,3 +354,24 @@ export const ReactNativeElement_public: typeof ReactNativeElement =

// $FlowExpectedError[prop-missing]
ReactNativeElement_public.prototype = ReactNativeElement.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReactNativeElement.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@

// flowlint unsafe-getters-setters:off

import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags';
import ReadOnlyCharacterData from './ReadOnlyCharacterData';
import ReadOnlyNode from './ReadOnlyNode';

Expand DownExpand Up@@ -39,3 +40,24 @@ export const ReadOnlyText_public: typeof ReadOnlyText =

// $FlowExpectedError[prop-missing]
ReadOnlyText_public.prototype = ReadOnlyText.prototype;

// The public imperative EventTarget API (`addEventListener`,
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents`: when that flag is off we remove
// those methods from this final class. Native/internal event dispatch does not
// rely on these public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
removeEventListener?: unknown,
dispatchEvent?: unknown,
} = ReadOnlyText.prototype;
prototype.addEventListener = undefined;
prototype.removeEventListener = undefined;
prototype.dispatchEvent = undefined;
}
Loading
Loading