Uh oh!
There was an error while loading. Please reload this page.
Remove react-native/jest-preset subpath - #57481
Closed
huntie wants to merge 1 commit into
Closed
Conversation
Summary: It's been two releases since we separated `react-native/jest-preset` in 0.85 and this has been updated in the template. Clean up by removing internal redirect module, public export, and peer dependency. Changelog: [General][Breaking] - `react-native/jest-preset` is removed — all projects must now migrate to `react-native/jest-preset` (package) Reviewed By: rubennorte Differential Revision: D111035221
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111035221. |
huntie added a commit
to huntie/react-native
that referenced
this pull request
Jul 8, 2026
Summary: It's been two releases since we separated `react-native/jest-preset` in 0.85 and this has been updated in the template. Clean up by removing internal redirect module, public export, and peer dependency. Changelog: [General][Breaking] - `react-native/jest-preset` is removed — all projects must now migrate to `react-native/jest-preset` (package) Reviewed By: rubennorte Differential Revision: D111035221
This pull request has been merged in 9ee21dd. |
meta-codesyncBot
pushed a commit
that referenced
this pull request
Jul 9, 2026
…7491) Summary: #57481 removed the `react-native/jest-preset.js` redirect module (and the `react-native/jest-preset` public export), but the in-repo `private/helloworld` app still referenced `preset: 'react-native'` in its Jest config. This breaks `yarn test` in the `test_ios_helloworld` CI job (which cascade-cancels the rest of the iOS matrix and turns the e2e retry `report` jobs red): ``` ● Validation Error: Module react-native should have "jest-preset.js" or "jest-preset.json" file at the root. ``` This migrates HelloWorld to the standalone `react-native/jest-preset` package — the documented migration path (see `packages/jest-preset/README.md`). ## Changes - `private/helloworld/jest.config.js`: `preset: 'react-native'` → `preset: 'react-native/jest-preset'` - `private/helloworld/package.json`: add `react-native/jest-preset` devDependency (`0.87.0-main`, matching the sibling `react-native/*` packages) ## Changelog: [Internal] [Fixed] - Fix HelloWorld Jest preset after `react-native/jest-preset` removal Pull Request resolved: #57491 Test Plan: - `cd private/helloworld && yarn test` resolves the preset and runs (previously failed with the validation error above). - CI `test_ios_helloworld` job. Reviewed By: cortinico Differential Revision: D111215532 Pulled By: cipolleschi fbshipit-source-id: 2d60de619060e384b4a5b662a6f588ea3e368433
zeyap pushed a commit
that referenced
this pull request
Jul 13, 2026
Summary: Pull Request resolved: #57481 It's been two releases since we separated `react-native/jest-preset` in 0.85 and this has been updated in the template. Clean up by removing internal redirect module, public export, and peer dependency. Changelog: [General][Breaking] - `react-native/jest-preset` is removed — all projects must now migrate to `react-native/jest-preset` (package) Reviewed By: rubennorte Differential Revision: D111035221 fbshipit-source-id: d66fed9218c801201c1e965f8163f048934d4200
zeyap added a commit
that referenced
this pull request
Jul 14, 2026
…oval (#57539) Summary: #57481 removed the `react-native/jest-preset` subpath redirect, but the in-repo `private/helloworld` template still referenced `preset: 'react-native'`, which Jest resolves to the now-deleted `react-native/jest-preset.js`. This broke all `test_ios_helloworld*` CI jobs on 0.87-stable at the `yarn test` step: Validation Error: Module react-native should have "jest-preset.js" or "jest-preset.json" file at the root. Since `private/helloworld` is excluded from the yarn workspace and installed standalone, it also needs `@react-native/jest-preset` as an explicit devDependency for the preset to resolve. - Point jest.config.js preset at `@react-native/jest-preset`. - Add `@react-native/jest-preset` to devDependencies. Changelog: [Internal] Test Plan: CI: `test_ios_helloworld*` jobs pass (previously failing at `yarn test`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It's been two releases since we separated
@react-native/jest-presetin 0.85 and this has been updated in the template.Clean up by removing internal redirect module, public export, and peer dependency.
Changelog:
[General][Breaking] -
react-native/jest-presetis removed — all projects must now migrate to@react-native/jest-preset(package)Reviewed By: rubennorte
Differential Revision: D111035221