Uh oh!
There was an error while loading. Please reload this page.
Relocate CLI plugin server modules (#57654) - #57654
Closed
huntie wants to merge 2 commits into
Closed
Conversation
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113412985. |
huntie added a commit
to huntie/react-native
that referenced
this pull request
Jul 23, 2026
Summary: Pull Request resolved: react#57654 Reorganise these modules under a `src/dev-server/` directory (out of `src/(commands|utils)/`, more clearly identifying this unit of the codebase. No public API change: the package still exports `startCommand` unchanged. Renames inside this directory: - `middleware.js` → `loadCommunityMiddleware.js` - `runServer.js` → `runDevServer.js` Changelog: [Internal] Differential Revision: D113412985
huntie added a commit
to huntie/react-native
that referenced
this pull request
Jul 23, 2026
Summary: Pull Request resolved: react#57654 Reorganise these modules under a `src/dev-server/` directory (out of `src/(commands|utils)/`, more clearly identifying this unit of the codebase. No public API change: the package still exports `startCommand` unchanged. Renames inside this directory: - `middleware.js` → `loadCommunityMiddleware.js` - `runServer.js` → `runDevServer.js` Changelog: [Internal] Differential Revision: D113412985
cortinico
approved these changes
Jul 24, 2026
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Migrate the `codegen` and `spm` command implementations out of `react-native.config.js` and into the `react-native/community-cli-plugin` package, alongside the existing `bundleCommand` and `startCommand`. This continues moving command definitions into the plugin so `react-native.config.js` becomes a thin routing layer, as the file's own comment already calls for. **Changes** - Add `src/commands/spm/index.js` and `src/commands/codegen/index.js`, each defining and default-exporting its command (unchanged `name`, `description`, and `options`) plus an exported args type — mirroring the `bundle`/`start` command structure. - Export `spmCommand` and `codegenCommand` from `src/index.flow.js`. - Drop the inline `spmCommand` and `codegenCommand` definitions from `react-native.config.js`. Changelog: [Internal] Differential Revision: D113412987
Summary: Pull Request resolved: react#57654 Reorganise these modules under a `src/dev-server/` directory (out of `src/(commands|utils)/`, more clearly identifying this unit of the codebase. No public API change: the package still exports `startCommand` unchanged. Renames inside this directory: - `middleware.js` → `loadCommunityMiddleware.js` - `runServer.js` → `runDevServer.js` Changelog: [Internal] Reviewed By: cortinico Differential Revision: D113412985
This pull request has been merged in aee0ec3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reorganise these modules under a
src/dev-server/directory (out ofsrc/(commands|utils)/, more clearly identifying this unit of the codebase.No public API change: the package still exports
startCommandunchanged.Renames inside this directory:
middleware.js→loadCommunityMiddleware.jsrunServer.js→runDevServer.jsChangelog: [Internal]
Reviewed By: cortinico
Differential Revision: D113412985