Uh oh!
There was an error while loading. Please reload this page.
Flush created animated nodes before handling events (#57656) - #57656
Closed
sbuggay wants to merge 1 commit into
Closed
Flush created animated nodes before handling events (#57656)#57656sbuggay wants to merge 1 commit into
sbuggay wants to merge 1 commit into
Conversation
@sbuggay has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111257551. |
sbuggay added a commit
to sbuggay/react-native
that referenced
this pull request
Jul 23, 2026
Summary: Pull Request resolved: react#57656 Changelog: [Internal] View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event. There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event. Differential Revision: D111257551
sbuggay added a commit
to sbuggay/react-native
that referenced
this pull request
Jul 23, 2026
Summary: Changelog: [Internal] View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event. There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event. Differential Revision: D111257551
sbuggay added a commit
to sbuggay/react-native
that referenced
this pull request
Jul 23, 2026
Summary: Changelog: [Internal] View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event. There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event. Differential Revision: D111257551
Summary: Changelog: [Internal] View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event. There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event. Differential Revision: D111257551
This pull request has been merged in 2b992a0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event.
There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event.
Differential Revision: D111257551