Uh oh!
There was an error while loading. Please reload this page.
fix(rn-tester): use framework-style import for RCTFabricComponentsPlugins.h - #57697
Closed
chrfalch wants to merge 1 commit into
Closed
fix(rn-tester): use framework-style import for RCTFabricComponentsPlugins.h#57697chrfalch wants to merge 1 commit into
chrfalch wants to merge 1 commit into
Conversation
…gins.h The quoted form resolves only under CocoaPods (header maps re-vend the bare filename via FACADE_REEXPOSED_HEADERS in rncore_facades.rb). SwiftPM exposes React headers as an include directory, so the header is only reachable as <React/RCTFabricComponentsPlugins.h> — the quoted import makes MyNativeView fail to compile when rn-tester is converted to SwiftPM. The angle form resolves under both distributions. Cherry-picked from the SPM stack (ecdd1771019). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D113771766. |
cortinico
approved these changes
Jul 27, 2026
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
@fabriziocucci merged this pull request in 6d0612c. |
chrfalch added a commit
that referenced
this pull request
Jul 27, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chrfalch added a commit
that referenced
this pull request
Jul 28, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fabriziocucci pushed a commit
that referenced
this pull request
Aug 3, 2026
…gins.h (#57697) Summary: rn-tester's `MyNativeView` example imports `RCTFabricComponentsPlugins.h`. The quoted form resolves under CocoaPods (the bare filename is re-vended via `FACADE_REEXPOSED_HEADERS` in `rncore_facades.rb`) and under the internal Meta build (the per-target header generated by buck's `plugins_header`), but not under SwiftPM. Under SwiftPM the header is exposed as an include directory, so only `<React/RCTFabricComponentsPlugins.h>` resolves. The quoted import makes `MyNativeView` fail to compile when rn-tester is converted to SwiftPM (surfaced by the new SPM CI lane in #57659), and switching to the angle form alone would instead break the internal build. The fix uses a `__has_include` conditional: the angle form when it is available (SwiftPM and CocoaPods) with the quoted form as a fallback (the internal build). This matches the existing pattern in rn-tester's own `NativeCxxModuleExample.h` and keeps all three build stacks compiling. ## Changelog: [INTERNAL] [FIXED] - Make rn-tester's NativeComponentExample header import resolve under SwiftPM, CocoaPods and the internal build Pull Request resolved: #57697 Test Plan: - Repro on clean `main`: converting rn-tester to SwiftPM (`spm add --deintegrate`) and building fails at `RNTMyNativeViewComponentView.mm` with `fatal error: 'RCTFabricComponentsPlugins.h' file not found`. - With this change: the same SwiftPM conversion plus `xcodebuild -configuration Debug -sdk iphonesimulator` gives `BUILD SUCCEEDED`. - Internal build: `buck2 build fbsource//xplat/js/react-native-github/packages/rn-tester:NativeComponentExampleApple` succeeds (it takes the quoted fallback). - Existing CocoaPods CI (`test_ios_rntester`) covers the CocoaPods path. Reviewed By: cipolleschi Differential Revision: D113771766 Pulled By: fabriziocucci fbshipit-source-id: e4549508f8e56942b45fa128b2391a290499d4a8 (cherry picked from commit 6d0612c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
rn-tester's
MyNativeViewexample importsRCTFabricComponentsPlugins.hwith the quoted form, which only resolves under CocoaPods (header maps re-vend the bare filename viaFACADE_REEXPOSED_HEADERSinrncore_facades.rb— see alsoscripts/ios-prebuild/__docs__/headers-rules.md, which documents the quoted form as CocoaPods-only). Under SwiftPM the header is exposed as an include directory, so only<React/RCTFabricComponentsPlugins.h>resolves — the quoted import makesMyNativeViewfail to compile when rn-tester is converted to SwiftPM (surfaced by the new SPM CI lane in #57659).The angle form resolves under both distributions. One line, no behavior change under CocoaPods.
Changelog:
[INTERNAL] [FIXED] - Fix rn-tester's NativeComponentExample header import so it compiles under SwiftPM
Test Plan:
main: converting rn-tester to SwiftPM (spm add --deintegrate) and building fails atRNTMyNativeViewComponentView.mm:16(fatal error: 'RCTFabricComponentsPlugins.h' file not found) — both against CI-composed prebuilt artifacts and locally-built ones (identical failure; clang search paths verified via the compile response file: the header is reachable only asReact/RCTFabricComponentsPlugins.h).xcodebuild -configuration Debug -sdk iphonesimulator→BUILD SUCCEEDED, embeddedReact.frameworkverified Debug-flavored.test_ios_rntester) covers the unchanged CocoaPods path.