Allow bundling in Simulator

[ffxsam]

Feel free to reject this PR, though I'm removing this because it causes a total failing state without any clue to the developer as to what's going on. It just yields a cryptic error message:

2016-02-04 18:59:17.582 [error][tid:com.facebook.React.JavaScript] Unable to execute JS call: __fbBatchedBridge is undefined
2016-02-04 18:59:17.585 SydTechEco[76215:10166934] *** Terminating app due to uncaught exception 'RCTFatalException: Unable to execute JS call: __fbBatchedBridge is undefined', reason: 'Unable to execute JS call: __fbBatchedBridge is undefined'

I ran into this when I set my project to Release instead of Debug, and tried to test in Simulator. This held me up and prevented me from meeting a launch goal, which was really frustrating. As developers, we should have the choice of running a release copy on Simulator or a device, as a final check before publishing to the AppStore.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @frantic, @ide and @lpil to be potential reviewers.

[frantic]

Hi @ffxsam, sorry about your bad experience, we are still figuring out what's the best thing to do here. We made it so the bundling process doesn't happen for simulator to save time when running the app for the first time, because packager runs with the simulator anyways.

I see two ways to adjust this PR to fit both our assumption and your use case:

1. Add check for "$CONFIGURATION" = "Debug" to line 15
2. Change the URL in AppDelegate.m to point to dev=false (however, in this case JS and images will be loaded from packager, which is not 100% same as Release build shipped to AppStore)

[ffxsam]

@frantic Thanks for the response! You guys have way more experience with the code base, so I'll defer to your judgment on this one. I'm just glad I found the issue.

The other thing that tripped me up was having to add libReact.a to the MyAppTests target. Without that step, I couldn't build a release version for my device. If I remember, I'll add this to the documentation somewhere.

[frantic]

If I remember, I'll add this to the documentation somewhere.

It would be better to fix the original cause :)

[ffxsam]

Is it just a matter of editing this file and adding a reference to libReact.a somewhere?

To be clear, I had to add this in order for the release version to build and run properly:

[frantic]

Is it just a matter of editing this file and adding a reference to libReact.a somewhere?

Yes, that's the right place

[facebook-github-bot]

@ffxsam updated the pull request.

[javache]

Pulling #6119 instead of this one.