Uh oh!
There was an error while loading. Please reload this page.
Cover jsinspector-modern/network:jsinspector_network with Stable API guards (#57962) - #57962
Closed
j-piasecki wants to merge 1 commit into
Closed
Cover jsinspector-modern/network:jsinspector_network with Stable API guards (#57962)#57962j-piasecki wants to merge 1 commit into
jsinspector-modern/network:jsinspector_network with Stable API guards (#57962)#57962j-piasecki wants to merge 1 commit into
Conversation
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116026740. |
j-piaseckiforce-pushed
the
export-D116026740
branch
from
August 18, 2026 09:36
73c7c77 to
df0263dComparejsinspector-modern/network:jsinspector_network with Stable API guardsjsinspector-modern/network:jsinspector_network with Stable API guards (#57962)j-piasecki added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 18, 2026
…I guards (react#57962) Summary: Pull Request resolved: react#57962 Marks `jsinspector-modern/network` as a private module under the C++ Stable API by adding `#include <react/cxxstableapi/PrivateGuard.h>` to its four exported headers (`BoundedRequestBuffer.h`, `CdpNetwork.h`, `HttpUtils.h`, `NetworkHandler.h`), and wiring the `React-cxxstableapi` dependency into BUCK and the podspec. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116026740
…I guards (react#57962) Summary: Marks `jsinspector-modern/network` as a private module under the C++ Stable API by adding `#include <react/cxxstableapi/PrivateGuard.h>` to its four exported headers (`BoundedRequestBuffer.h`, `CdpNetwork.h`, `HttpUtils.h`, `NetworkHandler.h`), and wiring the `React-cxxstableapi` dependency into BUCK and the podspec. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: huntie, cipolleschi Differential Revision: D116026740
j-piaseckiforce-pushed
the
export-D116026740
branch
from
August 20, 2026 07:50
df0263d to
d22361eCompareThis pull request has been merged in 2d427ba. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Marks
jsinspector-modern/networkas a private module under the C++ Stable API by adding#include <react/cxxstableapi/PrivateGuard.h>to its four exported headers (BoundedRequestBuffer.h,CdpNetwork.h,HttpUtils.h,NetworkHandler.h), and wiring theReact-cxxstableapidependency into BUCK and the podspec.The guards are inert unless a consumer defines
RN_STRICT_API, so there is no behavior change.Changelog: [Internal]
Reviewed By: huntie, cipolleschi
Differential Revision: D116026740