Uh oh!
There was an error while loading. Please reload this page.
Add DEBUG guard and production error logging to UnimplementedView - #57980
Closed
alanleedev wants to merge 1 commit into
Closed
Add DEBUG guard and production error logging to UnimplementedView#57980alanleedev wants to merge 1 commit into
alanleedev wants to merge 1 commit into
Conversation
Summary: Two changes to UnimplementedView on both iOS and Android: 1. **iOS: Add `#if DEBUG` guard** — the red overlay and error text in `RCTUnimplementedViewComponentView` and `RCTUnimplementedNativeComponentView` were shown in release builds (unlike Android which already had `ReactBuildConfig.DEBUG` guards). Users saw a red semi-transparent overlay with the component name. Now matches Android behavior — release users see nothing. 2. **Both platforms: Add production error logging** — `RCTLogError` on iOS and `ReactSoftExceptionLogger` on Android, outside the DEBUG guard. These fire in all builds including production, so missing native component registrations are reported to error dashboards instead of being completely silent. Files changed: - `RCTUnimplementedViewComponentView.mm` — primary Fabric fallback view (iOS) - `RCTUnimplementedNativeComponentView.mm` — UnimplementedNativeView component (iOS) - `ReactUnimplementedView.kt` — Android equivalent --- Reviewed By: javache Differential Revision: D101001824
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101001824. |
This pull request has been merged in ef28a2c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Two changes to UnimplementedView on both iOS and Android:
iOS: Add
#if DEBUGguard — the red overlay and error text inRCTUnimplementedViewComponentViewandRCTUnimplementedNativeComponentViewwere shown in release builds (unlike Android which already hadReactBuildConfig.DEBUGguards). Users saw a red semi-transparent overlay with the component name. Now matches Android behavior — release users see nothing.Both platforms: Add production error logging —
RCTLogErroron iOS andReactSoftExceptionLoggeron Android, outside the DEBUG guard. These fire in all builds including production, so missing native component registrations are reported to error dashboards instead of being completely silent.Files changed:
RCTUnimplementedViewComponentView.mm— primary Fabric fallback view (iOS)RCTUnimplementedNativeComponentView.mm— UnimplementedNativeView component (iOS)ReactUnimplementedView.kt— Android equivalentReviewed By: javache
Differential Revision: D101001824