Uh oh!
There was an error while loading. Please reload this page.
Pin clang-format 21.1.2 for OSS formatting (#58001) - #58001
Closed
Abbondanzo wants to merge 1 commit into
Closed
Conversation
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116500359. |
Summary: The existing npm `clang-format` wrapper bundles LLVM 15, causing `yarn clang-format` to disagree with the formatting of checked-in headers. Replace it with checksum-pinned DotSlash artifacts for `clang-format` 21.1.2 across Linux, macOS, and Windows. Add a chunked formatting runner and remove the obsolete npm dependency. The runner skips generated sources and ignores dirsynchronized or vendored subtrees that maintain their own formatting. Changelog: [Internal] Differential Revision: D116500359
clang-format 21.1.2 for OSS formattingclang-format 21.1.2 for OSS formatting (#58001)Abbondanzoforce-pushed
the
export-D116500359
branch
from
August 18, 2026 22:03
08e788c to
0b69827CompareThis pull request has been merged in 22e0eaf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The existing npm
clang-formatwrapper bundles LLVM 15, causingyarn clang-formatto disagree with the formatting of checked-in headers.Replace it with checksum-pinned DotSlash artifacts for
clang-format21.1.2 across Linux, macOS, and Windows. Add a chunked formatting runner and remove the obsolete npm dependency. The runner skips generated sources and ignores dirsynchronized or vendored subtrees that maintain their own formatting.Changelog: [Internal]
Differential Revision: D116500359