Uh oh!
There was an error while loading. Please reload this page.
Add strict API support for react/renderer/components/* private targets (#58009) - #58009
Closed
coado wants to merge 3 commits into
Closed
Add strict API support for react/renderer/components/* private targets (#58009)#58009coado wants to merge 3 commits into
react/renderer/components/* private targets (#58009)#58009coado wants to merge 3 commits into
Conversation
Differential Revision: D109849952
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116298251. |
Summary: Pull Request resolved: react#57312 This change rolls the umbrella-header + include-guard mechanism across the `react/renderer/components/*` modules, classifying each target as public, for-frameworks, or private. The change includes: - react/renderer/components/progressbar:androidprogressbar - `private`, - react/renderer/components/switch:androidswitch - `private`, - react/renderer/components/image:image - `public`, - react/renderer/components/inputaccessory:inputaccessory - `private`, - react/renderer/components/legacyviewmanagerinterop:legacyviewmanagerinterop - `private` - react/renderer/components/modal:modal - `public`, - react/renderer/components/text:text - `public`, - react/renderer/components/root:root - `public`, - react/renderer/components/safeareaview:safeareaview - `private`, - react/renderer/components/scrollview:scrollview - `public`, - react/renderer/components/unimplementedview:unimplementedview - `private`, - react/renderer/components/view:view - `public`, - react/renderer/components/virtualview:virtualview - `private`, - react/renderer/components/textinput:textinput - `for frameworks`, Changelog: [Internal] Differential Revision: D109316840
…ets (react#58009) Summary: Pull Request resolved: react#58009 This change adds the umbrella-header and include-guard mechanism across `react/renderer/components/*` private modules. The change includes: - react/renderer/components/inputaccessory:inputaccessory - `private`, - react/renderer/components/legacyviewmanagerinterop:legacyviewmanagerinterop - `private`, - react/renderer/components/progressbar:androidprogressbar - `private`, - react/renderer/components/safeareaview:safeareaview - `private`, - react/renderer/components/switch:androidswitch - `private`, - react/renderer/components/unimplementedview:unimplementedview - `private`, - react/renderer/components/virtualview:virtualview - `private`, Changelog: [Internal] Differential Revision: D116298251
react/renderer/components/* private targetsreact/renderer/components/* private targets (#58009)This pull request has been merged in b2cd5ea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds the umbrella-header and include-guard mechanism across
react/renderer/components/*private modules. The change includes:private,private,private,private,private,private,private,Changelog: [Internal]
Differential Revision: D116298251