Uh oh!
There was an error while loading. Please reload this page.
Add umbrella for react/renderer/uimanager subtree (#58025) - #58025
Closed
coado wants to merge 2 commits into
Closed
Conversation
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116763079. |
react/renderer/uimanager subtreereact/renderer/uimanager subtree (#58025)coado added a commit
to coado/react-native
that referenced
this pull request
Aug 20, 2026
Summary: Pull Request resolved: react#58025 Rolls the umbrella-header + include-guard mechanism across the `react/renderer/uimanager` module, classifying the target as public. - Adds `<React/UIManager.h>`, re-exporting the module's public interface headers. - Adds `<react/cxxstableapi/UmbrellaGuard.h>` to the module's public headers. - Wires the umbrella header directory into the Buck, CMake, CocoaPods, Gradle, and iOS prebuild header configurations. - Deprecated `SurfaceRegistryBinding.h` does not include umbrella guard because it will fail anyway when included directly (it includes AppRegistryBinding that does include guard). React Native's own sources keep using the fine-grained `<react/renderer/uimanager/...>` includes; only outside consumers use the umbrella. Changelog: [Internal] Differential Revision: D116763079
coado added a commit
to coado/react-native
that referenced
this pull request
Aug 20, 2026
Summary: Pull Request resolved: react#58025 Rolls the umbrella-header + include-guard mechanism across the `react/renderer/uimanager` module, classifying the target as public. - Adds `<React/UIManager.h>`, re-exporting the module's public interface headers. - Adds `<react/cxxstableapi/UmbrellaGuard.h>` to the module's public headers. - Wires the umbrella header directory into the Buck, CMake, CocoaPods, Gradle, and iOS prebuild header configurations. - Deprecated `SurfaceRegistryBinding.h` does not include umbrella guard because it will fail anyway when included directly (it includes AppRegistryBinding that does include guard). React Native's own sources keep using the fine-grained `<react/renderer/uimanager/...>` includes; only outside consumers use the umbrella. Changelog: [Internal] Differential Revision: D116763079
Summary: Add `<React/MapBuffer.h>` as the public C++ entry point for MapBuffer and MapBufferBuilder. Guard direct leaf-header inclusion for strict API consumers while preserving existing React Native builds and legacy include paths. Export and stage the umbrella consistently through Buck, CMake, Android Prefab, CocoaPods, and the Apple prebuilt-header inventory. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116632721
Summary: Rolls the umbrella-header + include-guard mechanism across the `react/renderer/uimanager` module, classifying the target as public. - Adds `<React/UIManager.h>`, re-exporting the module's public interface headers. - Adds `<react/cxxstableapi/UmbrellaGuard.h>` to the module's public headers. - Wires the umbrella header directory into the Buck, CMake, CocoaPods, Gradle, and iOS prebuild header configurations. - Deprecated `SurfaceRegistryBinding.h` does not include umbrella guard because it will fail anyway when included directly (it includes AppRegistryBinding that does include guard). React Native's own sources keep using the fine-grained `<react/renderer/uimanager/...>` includes; only outside consumers use the umbrella. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116763079
This pull request has been merged in 6bee68d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Rolls the umbrella-header + include-guard mechanism across the
react/renderer/uimanagermodule, classifying the target as public.<React/UIManager.h>, re-exporting the module's public interface headers.<react/cxxstableapi/UmbrellaGuard.h>to the module's public headers.and iOS prebuild header configurations.
SurfaceRegistryBinding.hdoes not include umbrella guard because it will fail anyway when included directly (it includes AppRegistryBinding that does include guard).React Native's own sources keep using the fine-grained
<react/renderer/uimanager/...>includes; only outside consumers use theumbrella.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D116763079