Skip to content

Cover react/runtime/hermes:hermes with Stable API guards#58050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
+4 −0
Closed

Cover react/runtime/hermes:hermes with Stable API guards #58050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/runtime/React-RuntimeHermes.podspec
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ Pod::Spec.new do |s|

resolve_use_frameworks(s, header_mappings_dir: "../../", module_name: "React_RuntimeHermes")

s.dependency "React-cxxstableapi"
s.dependency "React-jsitracing"
s.dependency "React-jsi"
s.dependency "React-utils"
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/runtime/hermes/CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ target_link_libraries(bridgelesshermes
jsi
jsitooling
jsinspector
react_cxxstableapi
${reactnative}
)

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/hermes/HermesInstance.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <cxxreact/MessageQueueThread.h>
#include <hermes/hermes.h>
#include <jsi/jsi.h>
Expand Down
Loading