Android WebSocket: include cookies with request by bradleyboy · Pull Request #6067 · react/react-native

bradleyboy · 2016-02-22T00:00:24Z

This commit brings Android in line with iOS WebSockets by sending along cookies from the shared CookieManager. See: #5630

facebook-github-bot · 2016-02-22T00:01:20Z

By analyzing the blame information on this pull request, we identified @satya164 and @aprock to be potential reviewers.

vmakhaev · 2016-02-24T08:05:32Z

LGTM. Any chances to merge this soon?

satya164 · 2016-02-24T12:30:07Z

@bradleyboy Can you provide a test plan?

bradleyboy · 2016-02-25T00:00:38Z

@satya164 I've been working on a IRC client that authenticates the user via a WebView, then opens a WebSocket for the rest of the communication thereafter. This worked fine on iOS (once #5630 landed), but did not work on Android as the cookies aren't passed currently. With this patch applied, I've confirmed that the behavior is consistent between both platforms.

satya164 · 2016-02-25T12:11:56Z

@bradleyboy Would be awesome to have an example in UIExplorer that we could test.

facebook-github-bot · 2016-03-13T05:07:19Z

@bradleyboy updated the pull request.

facebook-github-bot · 2016-03-13T20:13:14Z

@bradleyboy updated the pull request.

facebook-github-bot · 2016-03-14T23:31:19Z

@bradleyboy updated the pull request.

ghost · 2016-04-06T17:00:27Z

@satya164 would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

vmakhaev · 2016-04-10T09:23:33Z

Would be happy to see it merged finally. This blocks using cookies for auth.

dentrado · 2016-05-11T19:48:46Z

Any news regarding this? I saw that a similar PR is open for iOS, maybe some examples and/or tests can be shared: #7167

mkonicek · 2016-09-09T09:45:27Z

Let's merge this since we do the same on iOS:
https://github.com/facebook/react-native/blob/2f788524112d59f62a295e7f4b0c1cfa0f6203fe/Libraries/WebSocket/RCTSRWebSocket.m#L293

It would be ideal to have an example in the UI Explorer but the test plan @bradleyboy provided looks good.

@facebook-github-bot shipit

mkonicek · 2016-09-09T09:46:47Z

@bradleyboy Let's see if the patch still applies on top of master.

facebook-github-bot · 2016-09-09T09:47:04Z

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

ghost · 2016-09-09T23:48:10Z

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

This commit brings Android in line with iOS WebSockets by sending along cookies from the shared CookieManager. See: react#5630

ghost · 2016-09-10T18:10:50Z

@bradleyboy updated the pull request - view changes - changes since last import

bradleyboy · 2016-09-10T19:38:38Z

@mkonicek Just rebased and force pushed this, so it should be clean now. CI looks 👍

mkonicek · 2016-09-20T12:07:58Z

Thanks for the patience @bradleyboy :)

Summary: This commit brings Android in line with iOS WebSockets by sending along cookies from the shared CookieManager. See: #5630Closes#6067 Differential Revision: D3841122 Pulled By: wutalman fbshipit-source-id: 6dae03bdf1c4599f12c0b191fcc56a61952fb59e

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 22, 2016

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2016

mkonicek self-assigned this Sep 9, 2016

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016

ghost added Import Failed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Sep 9, 2016

Android WebSocket: include cookies with request
259d728
This commit brings Android in line with iOS WebSockets by sending along cookies from the shared CookieManager. See: react#5630

bradleyboy force-pushed the patch-1 branch from 98875ee to 259d728Compare September 10, 2016 18:09

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2016

ghost closed this in 04392f2Sep 19, 2016

This pull request was closed.

Uh oh!

Conversation

bradleyboy commented Feb 22, 2016

Uh oh!

facebook-github-bot commented Feb 22, 2016

Uh oh!

vmakhaev commented Feb 24, 2016

Uh oh!

satya164 commented Feb 24, 2016

Uh oh!

bradleyboy commented Feb 25, 2016

Uh oh!

satya164 commented Feb 25, 2016

Uh oh!

facebook-github-bot commented Mar 13, 2016

Uh oh!

facebook-github-bot commented Mar 13, 2016

Uh oh!

facebook-github-bot commented Mar 14, 2016

Uh oh!

ghost commented Apr 6, 2016

Uh oh!

vmakhaev commented Apr 10, 2016

Uh oh!

dentrado commented May 11, 2016

Uh oh!

mkonicek commented Sep 9, 2016

Uh oh!

mkonicek commented Sep 9, 2016

Uh oh!

facebook-github-bot commented Sep 9, 2016

Uh oh!

ghost commented Sep 9, 2016

Uh oh!

ghost commented Sep 10, 2016

Uh oh!

bradleyboy commented Sep 10, 2016

Uh oh!

mkonicek commented Sep 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants