Skip to content

Deleted unnecessary 'use strict' in new project templates - #6322

Closed
wwwsevolod wants to merge 2 commits into
react:masterfrom
wwwsevolod:patch-1
Closed

Deleted unnecessary 'use strict' in new project templates#6322
wwwsevolod wants to merge 2 commits into
react:masterfrom
wwwsevolod:patch-1

Conversation

@wwwsevolod

@wwwsevolodwwwsevolod commented Mar 6, 2016

Copy link
Copy Markdown
Contributor

Hello there!

Since React Native generates index.*.js files with usage of ES6 modules, 'use strict' became unnecessary.

http://www.ecma-international.org/ecma-262/6.0/#sec-strict-mode-code

Module code is always strict mode code.

@facebook-github-bot

facebook-github-bot commented Mar 6, 2016

Copy link
Copy Markdown
Contributor

By analyzing the blame information on this pull request, we identified @mkonicek, @foghina and @Purii to be potential reviewers.

@facebook-github-bot

facebook-github-bot commented Mar 6, 2016

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@vjeux

vjeux commented Mar 6, 2016

Copy link
Copy Markdown
Contributor

@facebook-github-bot shipit

@facebook-github-bot

facebook-github-bot commented Mar 6, 2016

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: accepted and removed GH Review: review-needed labels Mar 6, 2016
@facebook-github-bot

facebook-github-bot commented Mar 6, 2016

Copy link
Copy Markdown
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghostghost closed this in 081a413Mar 6, 2016
@corbt

corbt commented Mar 9, 2016

Copy link
Copy Markdown
Contributor

Just a note, I think this was premature. Until #5796 lands 'use strict' is still necessary in modules in RN by default.

grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Vsevolod IvanovFacebook Github Bot 2
Deleted unnecessary 'use strict' in new project templates
d63bb8f
Summary:Hello there!
Since React Native generates `index.*.js` files with usage of ES6 modules, `'use strict'` became unnecessary.
http://www.ecma-international.org/ecma-262/6.0/#sec-strict-mode-code
> Module code is always strict mode code.
Closesreact/react-native#6322
Differential Revision: D3017181
Pulled By: vjeux
fb-gh-sync-id: 39e0fe703b8d8a0093b952f2c18a36d0d28e1020
shipit-source-id: 39e0fe703b8d8a0093b952f2c18a36d0d28e1020
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wwwsevolod@facebook-github-bot@vjeux@corbt