[AdSupportIOS] better module exports for AdSupportIOS by lvyile · Pull Request #666 · react/react-native

lvyile · 2015-04-04T12:41:46Z

Before:

varAdSupportIOS=require('AdSupportIOS');

After:

varReact=require('react-native');var{//...
AdSupportIOS,//...}=React;

better var { AdSupportIOS, } = React;

lvyile · 2015-04-04T14:42:31Z

Why I test succeed on my device, but build failed on Travis CI ?

ccheever · 2015-05-30T00:16:54Z

I think the code for this looks good but @lvyile you should probably squash your commits.

Someone from Facebook or more of a decision maker on the project probably needs to say whether

varAdSupportIOS=require('AdSupportIOS');

or

varReact=require('react-native');var{//...
AdSupportIOS,//...}=React;

is preferred. @brentvatne ?

brentvatne · 2015-05-30T00:30:49Z

I think the latter example is preferred in this case @ccheever.

One thing that we will want to do in addition to this is add some documentation in AdSupportIOS.js so that we can have it under the APIs section in the docs. If you're up for it @ccheever ;)

Agreed re:squashing, can you squash your commits into one @lvyile?

nicklockwood · 2015-11-17T16:12:54Z

Seems like this now works as intended.

facebook-github-bot · 2015-11-17T16:13:16Z

@lvyile updated the pull request.

* Bump bs-platform to 7.2.0 * Record as objects * Update src/apis/NetInfo.md Co-Authored-By: Max Thirouin <git@moox.io> * Update src/apis/CameraRoll.re Co-Authored-By: Max Thirouin <git@moox.io> * Update documentation file VirtualizedSectionList * Update documentation files * Add missing bs.meth decorator * Documentation fixes * Documentation fixes * Documentation updates Co-authored-by: Max Thirouin <git@moox.io>

* change back to localhost * boost path gradlew change * whitespace

…in truncated text range (#55518) Summary: ### Title [iOS] Inline attachments in truncated Text still visible (Fabric) --- ### Description On iOS with the New Architecture (Fabric), inline attachments in a `<Text>` that lie beyond the `numberOfLines` limit are still being rendered instead of being clipped. As a result, the attachment that should be clipped appears just above its wrapper. See screenshots below. --- ### MANDATORY Reproducer https://snack.expo.dev/kamildelekta/truncatedtextattachmentvisiblebug --- ### Screenshots of issue Only `maxLines` changes between these two screenshots. You can check it yourself in the expo snack above. | Text | Truncated Text | | --------- | ------- | |<img width="250" height="1027" alt="maxLines4" src="https://github.com/user-attachments/assets/bc93a03a-7819-4ec6-84ab-dea2bd7cbe6c" /> | <img width="250" height="1029" alt="maxLines3" src="https://github.com/user-attachments/assets/25eee68d-ef10-40d2-a657-b9dc9e158c1b" /> | ### React Native Version ``` "react-native": "0.83.0" ``` --- ### Affected Platforms only IOS New Arch --- Pull Request resolved: #55518 Test Plan: **Visible cases** Tested multiple layouts where the attachment is in range; the attachment is shown and laid out correctly. **Clipped cases** Tested both clipping paths: (1) attachment after the last visible line → `isOutsideVisibleRange`; (2) attachment in the truncated "..." range → `isInTruncatedRange`. In both cases the attachment is correctly clipped. **Context** Before this change we only had `isInTruncatedRange`. Handling for `isOutsideVisibleRange` was added. The example below shows that these two clipping cases are mutually exclusive; in the app, both cases correctly clip the attachments. Testing code: ``` <View style={{ flex: 1, justifyContent: 'center', padding: 16, alignItems: 'stretch' }}> <Text style={{ fontSize: 20, fontWeight: 'bold', marginBottom: 8, color: '#333' }}> Correctly clipped </Text> {/* Case 1: isOutsideVisibleRange: 1, isInTruncatedRange: 0 */} <Text numberOfLines={3} style={{ fontSize: 18, borderWidth: 1, marginBottom: 16, textAlign: 'justify' }}> Line 1{'\n'}Line 2{'\n'}Line 3{'\n'} <View style={{ width: 20, height: 20, backgroundColor: 'red' }} /> </Text> {/* Case 2: isOutsideVisibleRange: 0, isInTruncatedRange: 1 */} <Text numberOfLines={1} style={{ fontSize: 18, width: 200, borderWidth: 1, marginBottom: 8 }}> Long text that truncates with ellipsis <View style={{ width: 20, height: 20, backgroundColor: 'blue' }} /> </Text> <Text style={{ fontSize: 20, fontWeight: 'bold', marginTop: 16, marginBottom: 8, color: '#333' }}> Visible </Text> <Text style={{ fontSize: 12, color: '#666', marginBottom: 4, marginTop: 8 }}>First char</Text> <Text numberOfLines={2} style={{ fontSize: 18, borderWidth: 1, marginBottom: 16, textAlign: 'justify' }}> <View style={{ width: 20, height: 20, backgroundColor: 'green' }} /> text after attachment </Text> <Text style={{ fontSize: 12, color: '#666', marginBottom: 4 }}>Middle of line</Text> <Text numberOfLines={3} style={{ fontSize: 18, borderWidth: 1, marginBottom: 16, textAlign: 'justify' }}> Line 1{'\n'}Line 2 with <View style={{ width: 20, height: 20, backgroundColor: 'green' }} /> {'\n'}Line 3 </Text> <Text style={{ fontSize: 12, color: '#666', marginBottom: 4 }}>End of line 1</Text> <Text numberOfLines={3} style={{ fontSize: 18, borderWidth: 1, marginBottom: 16, textAlign: 'justify' }}> Line 1 <View style={{ width: 20, height: 20, backgroundColor: 'orange' }} /> {'\n'}Line 2{'\n'}Line 3 </Text> <Text style={{ fontSize: 12, color: '#666', marginBottom: 4 }}>Short text, end</Text> <Text style={{ fontSize: 18, borderWidth: 1, marginBottom: 16, textAlign: 'justify' }}> Short text <View style={{ width: 20, height: 20, backgroundColor: 'orange' }} /> </Text> <Text style={{ fontSize: 12, color: '#666', marginBottom: 4 }}>Only attachment on line</Text> <Text numberOfLines={2} style={{ fontSize: 18, borderWidth: 1, textAlign: 'justify' }}> <View style={{ width: 20, height: 20, backgroundColor: 'purple' }} /> {'\n'}Second line </Text> </View> ``` and here some examples: | oldArch | newArch | newArch fixed | --------- | ------- | ------- | |<img width="250" height="2622" alt="oldArch" src="https://github.com/user-attachments/assets/aaffac4c-f3da-43ff-9560-7eb6e5258eb3" /> | <img width="250" height="2622" alt="newArch" src="https://github.com/user-attachments/assets/8905bb4e-8431-4f4d-ae46-770705520a61" /> | <img width="250" height="2622" alt="newArchFixed" src="https://github.com/user-attachments/assets/f786178e-438d-4a90-8ccf-9802181b5d8c" />| --- ## Changelog: [iOS] [Fixed] - Inline attachments after the last visible line in truncated text are now correctly marked as clipped. --- ### Output of `npx react-native-community/cli info` ``` System: OS: macOS 26.2 CPU: (12) arm64 Apple M4 Pro Memory: 982.39 MB / 48.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 22.14.0 path: /nix/store/04fc23dsflkxl4s9p6lkigia1hq3vjp2-nodejs-22.14.0/bin/node Yarn: version: 1.22.19 path: /Users/kamil/.nix-profile/bin/yarn npm: version: 10.9.2 path: /nix/store/04fc23dsflkxl4s9p6lkigia1hq3vjp2-nodejs-22.14.0/bin/npm Watchman: version: 2024.03.11.00 path: /Users/kamil/.nix-profile/bin/watchman Managers: CocoaPods: version: 1.15.2 path: /Users/kamil/.nix-profile/bin/pod SDKs: iOS SDK: Platforms: - DriverKit 25.2 - iOS 26.2 - macOS 26.2 - tvOS 26.2 - visionOS 26.2 - watchOS 26.2 Android SDK: Not Found IDEs: Android Studio: Not Found Xcode: version: 26.2/17C52 path: /usr/bin/xcodebuild Languages: Java: Not Found Ruby: version: 2.6.10 path: /usr/bin/ruby npmPackages: "react-native-community/cli": installed: 20.0.0 wanted: 20.0.0 react: installed: 19.2.0 wanted: 19.2.0 react-native: installed: 0.83.0 wanted: 0.83.0 react-native-macos: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: true newArchEnabled: true iOS: hermesEnabled: true newArchEnabled: true info React Native v0.83.2 is now available (your project is running on v0.83.0). ``` --- Reviewed By: NickGerleman Differential Revision: D92991293 Pulled By: CalixTang fbshipit-source-id: ebd097c4311a18e0f628fe5dd3eec353582ce423

…scales (#57825) Summary: `saveAssets` filters an asset's scales through `filterPlatformAssetScales`, but `getImageSet` indexes the unfiltered `asset.files`, so an asset with scales `[1, 1.5, 2, 3]` gets the 1.5x file in its 2x catalog slot and the 2x file in its 3x slot: `Assets.car` ships the wrong images. An asset with no standard scale at all (only `1.5x`, say) produces an imageset actool silently drops from the car, which makes the image unloadable when `RCTUseAssetCatalog` is on, since the catalog runtime has no filesystem fallback (#30129). Fix, in `assetCatalogIOS.js`: - Each catalog slot (1x/2x/3x) is paired with its own file. - An asset with no valid scale maps its closest variant into the nearest valid slot, the same "closest larger" rule loose files already get, and warns in the build log. Every imageset now holds at least one rendition actool will compile. Related: expo/expo#48525 applies the same fix to Expo CLI's mirrored implementation. ## Changelog: [IOS] [FIXED] - Asset catalog imagesets paired wrong files for assets with non-standard scales Pull Request resolved: #57825 Test Plan: New unit tests in `assetCatalogIOS-test.js`: standard 1x/2x/3x pairing, mixed `[1, 1.5, 2, 3]` (regression for the file shift), fractional-only `[1.5]`, and `[4]` clamping to the 3x slot. ``` yarn jest packages/community-cli-plugin/src/commands/bundle Tests: 18 passed, 18 total ``` ### End-to-end Bundled a test app through the real pipeline (Metro → `saveAssets` → actool → `assetutil --info` on the compiled `Assets.car`) with two assets: `logo` at scales `[1, 1.5, 2, 3]` (100/150/200/300 px) and `star` with only a `1.5x` file (150 px). | Rendition in `Assets.car` | before | after | |---|---|---| | `img_logo` 1x | 100 px | 100 px | | `img_logo` 2x | **150 px (the 1.5x file)** | 200 px | | `img_logo` 3x | **200 px (the 2x file)** | 300 px | | `img_star` | **absent (actool dropped the `1.5x` imageset)** | 150 px in the 2x slot, with a build-log warning | Running on an iPhone 17 Pro simulator (3x), same app built with the buggy and fixed CLI — the labeled tiles show which file the catalog actually served, and `star` goes from missing to rendering: | Before | After | |---|---| | <img src="https://github.com/user-attachments/assets/4ebdbd33-74ec-4731-a2c4-f1a2d9b5838b" width="320" /> | <img src="https://github.com/user-attachments/assets/cd461b0a-5763-4388-8771-1ae6df383817" width="320" /> | <details> <summary>Repro app used for the screenshots</summary> Built `private/helloworld` (Release, simulator) with `RCTUseAssetCatalog` set to `true` in its Info.plist, and these assets in `img/`, where each file is a solid tile with its scale label and pixel size baked into the image so a screenshot shows exactly which file got served: `logo.png` (100px, "1x"), `logo@1.5x.png` (150px, "1.5x"), `logo@2x.png` (200px, "2x"), `logo@3x.png` (300px, "3x"), and `star@1.5x.png` (150px, "STAR") with no other variants. ```js // index.js import React from 'react'; import {AppRegistry, Image, Text, View, StyleSheet} from 'react-native'; const styles = StyleSheet.create({ root: {flex: 1, backgroundColor: '#111', alignItems: 'center', justifyContent: 'center'}, label: {color: '#fff', fontSize: 16, marginTop: 24, marginBottom: 8, fontWeight: '600'}, box: {width: 100, height: 100, borderWidth: 2, borderColor: '#666'}, img: {width: 100, height: 100}, }); const App = () => ( <View style={styles.root}> <Text style={styles.label}>logo.png (has 1x/1.5x/2x/3x)</Text> <View style={styles.box}> <Image style={styles.img} source={require('./img/logo.png')} /> </View> <Text style={styles.label}>star.png (only 1.5x)</Text> <View style={styles.box}> <Image style={styles.img} source={require('./img/star.png')} /> </View> </View> ); AppRegistry.registerComponent('HelloWorld', () => App); ``` On the 3x simulator JS resolves `logo` to the 3x variant, so the tile that renders is the file the catalog's 3x slot actually contains: the 2x-labeled tile before the fix, the 3x tile after. `star` resolves to its only variant (`1.5x`); before the fix its imageset is dropped by actool and the box renders empty. </details> Reviewed By: christophpurrer Differential Revision: D116956049 Pulled By: javache fbshipit-source-id: 4405c235098ea7f8a4ebc03ca6876a3981894e71

lvyile added 3 commits April 4, 2015 20:32

Update AdSupportIOS.js
3a5c567
better var { AdSupportIOS, } = React;

Update AdSupportIOSExample.js
8edd262

Update react-native.js
be12a3d

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2015

vjeux added Needs Review and removed Needs Review labels Apr 17, 2015

brentvatne changed the title ~~better module exports for AdSupportIOS~~[AdSupportIOS] better module exports for AdSupportIOSJun 1, 2015

brentvatne self-assigned this Jun 1, 2015

brentvatne added GH Review: needs-revision and removed GH Review: review-needed labels Jun 1, 2015

nicklockwood closed this Nov 17, 2015

facebook-github-bot added GH Review: review-needed and removed GH Review: needs-revision labels Nov 17, 2015

seph14 mentioned this pull request Feb 25, 2016
[iOS] applying LayoutAnimation to resize a View with shadow will result in artifacts #6151
Closed

roselind mentioned this pull request Feb 14, 2017
fetch ， When a request is not completed, the resulting memory leaks(iOS and Andriod) #12377
Closed

AlexKitC mentioned this pull request Jan 7, 2020
[iOS] TextInput default text color change to white when running on real device #27696
Closed

mganandraj pushed a commit to mganandraj/react-native that referenced this pull request Jan 16, 2021
change back to localhost (react#666)
b2afdfd
* change back to localhost * boost path gradlew change * whitespace

c2d5c6 mentioned this pull request Sep 19, 2025
newArchEnabled #53859
Closed

Navigation Menu

Uh oh!

[AdSupportIOS] better module exports for AdSupportIOS - #666

[AdSupportIOS] better module exports for AdSupportIOS#666
lvyile wants to merge 3 commits into
react:masterfrom
lvyile:patch-2

lvyile commented Apr 4, 2015

Uh oh!

lvyile commented Apr 4, 2015

Uh oh!

ccheever commented May 30, 2015

Uh oh!

brentvatne commented May 30, 2015

Uh oh!

nicklockwood commented Nov 17, 2015

Uh oh!

facebook-github-bot commented Nov 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

lvyile commented Apr 4, 2015

Before:

After:

Uh oh!

lvyile commented Apr 4, 2015

Uh oh!

ccheever commented May 30, 2015

Uh oh!

brentvatne commented May 30, 2015

Uh oh!

nicklockwood commented Nov 17, 2015

Uh oh!

facebook-github-bot commented Nov 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants