Uh oh!
There was an error while loading. Please reload this page.
[React Native] Use react-native instead of React on hmr config - #6696
Closed
martinbigio wants to merge 1 commit into
Closed
[React Native] Use react-native instead of React on hmr config#6696martinbigio wants to merge 1 commit into
react-native instead of React on hmr config#6696martinbigio wants to merge 1 commit into
Conversation
martinbigio
commented
Mar 28, 2016
ContributorAuthor
cc @satya164, @skevy, @bestander |
facebook-github-bot
commented
Mar 28, 2016
Contributor
By analyzing the blame information on this pull request, we identified @skevy, @davidaurelio and @martinbigio to be potential reviewers. |
skevy
commented
Mar 28, 2016
Contributor
FYI @bestander we're getting some type of weird transient error on the Buck tests here. |
bestander
commented
Mar 28, 2016
Contributor
@skevy thanks for being on top of CI errors! |
martinbigio
commented
Mar 28, 2016
ContributorAuthor
Cool, just updated the PR rebasing. |
bestander
commented
Mar 29, 2016
Contributor
@facebook-github-bot shipit |
facebook-github-bot
commented
Mar 29, 2016
Contributor
Thanks for importing. If you are an FB employee go to Phabricator to review. |
9 tasks
martinbigio
commented
Mar 29, 2016
ContributorAuthor
We still need to push a new version of the preset. I'll do it later today. |
martinbigio
commented
Mar 30, 2016
ContributorAuthor
just release babel-preset-react-native@1.5.5 |
zebulgar pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:Check react#6640 for details Closesreact#6696 Differential Revision: D3109128 fb-gh-sync-id: b80ff44f0dbc063870dc1dc7de9bf3c814ac9a12 fbshipit-source-id: b80ff44f0dbc063870dc1dc7de9bf3c814ac9a12
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check #6640 for details