Uh oh!
There was an error while loading. Please reload this page.
Display component methods on the website and tweak the documentation - #6890
Closed
janicduplessis wants to merge 4 commits into
Closed
Display component methods on the website and tweak the documentation#6890janicduplessis wants to merge 4 commits into
janicduplessis wants to merge 4 commits into
Conversation
facebook-github-bot
commented
Apr 9, 2016
Contributor
By analyzing the blame information on this pull request, we identified @vjeux, @ericvicenti and @sahrens to be potential reviewers. |
vjeux
commented
Apr 9, 2016
Contributor
@facebook-github-bot shipit |
facebook-github-bot
commented
Apr 9, 2016
Contributor
Thanks for importing. If you are an FB employee go to Phabricator to review. |
facebook-github-bot
commented
Apr 9, 2016
Contributor
@janicduplessis updated the pull request. |
facebook-github-bot
commented
Apr 9, 2016
Contributor
@janicduplessis updated the pull request. |
facebook-github-bot
commented
Apr 9, 2016
Contributor
@janicduplessis updated the pull request. |
janicduplessis
commented
Apr 9, 2016
ContributorAuthor
@vjeux CI found a few pages that were broken, fixed now. |
vjeux
commented
Apr 9, 2016
Contributor
@facebook-github-bot shipit |
facebook-github-bot
commented
Apr 9, 2016
Contributor
Thanks for importing. If you are an FB employee go to Phabricator to review. |
This was referenced Apr 10, 2016
zebulgar pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:The website now displays public methods on components. This was implemented mostly in react-docgen via react#66. This adds a <Method> component that is used by the component and API doc pages to display documentation for a method. It also adds some missing documentation and tweak some existing one to integrate with this feature. I also prefixed some component methods with an '_' so they don't show up in the doc. **Test plan (required)** Tested every component page locally to make sure the methods doc was displayed properly. Tested an API page to make sure it still worked properly. Closesreact#6890 Differential Revision: D3159911 Pulled By: vjeux fb-gh-sync-id: 1e6a4640cda6794496d9844c1af6a1451c017dcc fbshipit-source-id: 1e6a4640cda6794496d9844c1af6a1451c017dcc
zebulgar pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:Oups, forgot to remove a test in react#6890 :) Closesreact#6898 Differential Revision: D3161421 Pulled By: mkonicek fb-gh-sync-id: a7e6b4f31822e67dcf1d898306851a112160d20f fbshipit-source-id: a7e6b4f31822e67dcf1d898306851a112160d20f
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The website now displays public methods on components. This was implemented mostly in react-docgen via reactjs/react-docgen#66. This adds a component that is used by the component and API doc pages to display documentation for a method.
It also adds some missing documentation and tweak some existing one to integrate with this feature. I also prefixed some component methods with an '_' so they don't show up in the doc.
Test plan (required)
Tested every component page locally to make sure the methods doc was displayed properly.
Tested an API page to make sure it still worked properly.